Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 13:50
    kapilt closed #6628
  • 13:43
    zzzeek unlabeled #6628
  • 13:43
    zzzeek labeled #6628
  • 13:39
    kapilt labeled #6628
  • 13:39
    kapilt opened #6628
  • 11:34
    qianxuanyon opened #332
  • Jun 12 20:29
    gordthompson assigned #842
  • Jun 12 14:27
    nurgasemetey edited #858
  • Jun 12 10:16
    CaselIT assigned #856
  • Jun 11 22:00
    CaselIT review_requested #6624
  • Jun 11 18:20
    sonthonaxrk opened #6624
  • Jun 11 15:53
    CaselIT unlabeled #857
  • Jun 11 15:16
    zzzeek locked #861
  • Jun 11 15:16
    zzzeek closed #861
  • Jun 11 15:13
    jtpavlock labeled #861
  • Jun 11 15:13
    jtpavlock opened #861
  • Jun 11 14:41
    zzzeek closed #6616
  • Jun 11 13:55
    zzzeek milestoned #6621
  • Jun 11 13:55
    zzzeek labeled #6621
  • Jun 11 13:55
    zzzeek labeled #6621
mike bayer
@zzzeek
yeah i had not been able to figure out a way to do that
Federico Caselli
@CaselIT
but I'm not sure how the best way would be for it. My idea was to make it return something that identifies the fact that's a once, since is is cheap and should not cause too much overhead
that part is really hard to follow btw. I'm still not sure what half of the stuff does
mike bayer
@zzzeek
yah me neithr :)
Federico Caselli
@CaselIT
do you think the return thing would work?
mike bayer
@zzzeek
im not really sure i hitnk overall some system outside of the event.call() has to know to remove it
Federico Caselli
@CaselIT
yes. the next step was to recreate the event key from the callback
so I can call remove on it
not figured out that part yet
also is only_once public or can I move it around?
mike bayer
@zzzeek
yeah i would ahve to dig into that code again and im a little too headachy today
the...keyword arugment to event.listen() ? i think it's public but nobody uses it
Federico Caselli
@CaselIT
no the wrapper thing in utils
mike bayer
@zzzeek
oh, that's whatever
Federico Caselli
@CaselIT
ok.
I think I'll start by passing the stuff to create the event key when creating the wrapper, just to see what breaks with that change. when in review you can point to better alternative
mike bayer
@zzzeek
ok
Federico Caselli
@CaselIT
thanks
@bryanforbes are you working on sqlalchemy/sqlalchemy2-stubs#51 ? If not I think it can be merged and anything that I mentioned could be done in a later pr
Bryan Forbes
@bryanforbes
yeah, I’ll take care of it
Federico Caselli
@CaselIT
ok

yeah, I’ll take care of it

sorry, rereading I wonder if I understood wrong. are you working on it or you can take care of it later. sorry :)

Bryan Forbes
@bryanforbes
I’m working on it now
Federico Caselli
@CaselIT
ok
Bryan Forbes
@bryanforbes
@CaselIT pushed
Federico Caselli
@CaselIT

do you think the return thing would work?

it does not, since retvat=True is a thing, that while not really useful with once=True works at least once

mike bayer
@zzzeek
I would just be adding the listener to some collection somewhere
Federico Caselli
@CaselIT
oh retval=True event behave differently
meaning thay are not called by the event but explicetly
Federico Caselli
@CaselIT
Bryan Forbes
@bryanforbes
@zzzeek the update to strict mode is large, but no new functionality is added
mike bayer
@zzzeek
@bryanforbes whichj is this
I just pushed it
mike bayer
@zzzeek
wow mr fast
Bryan Forbes
@bryanforbes
lol
I’ve been working on it since late last week
mike bayer
@zzzeek
so, "strict mode", meaning the plugin itself passes mypy --strict ?
Bryan Forbes
@bryanforbes
yup
mike bayer
@zzzeek
failed orderinglist1
err 2
Bryan Forbes
@bryanforbes
lies
mike bayer
@zzzeek
well both
test_mypy[orderinglist1.py] FAILED [ 69%]
test/ext/mypy/test_mypy_plugin_py3k.py::MypyPluginTest::test_mypy[orderinglist2.py] FAILED [ 72%]
Bryan Forbes
@bryanforbes
ok, I’ll look into it tomorrow
mike bayer
@zzzeek
ok
once we have all tyour stubs2 prs in i should put out a release
Bryan Forbes
@bryanforbes
I wonder if it’s a problem with mypy 0.812
hmmm… it passes just fine with 0.812 and the latest stubs release
I’m not sure why it’s failing in jenkins