Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 08:08
    bigjools labeled #6823
  • 08:08
    bigjools opened #6823
  • Jul 28 19:38
    CaselIT edited #5987
  • Jul 28 18:11
    zzzeek review_requested #334
  • Jul 28 17:53
    CaselIT closed #6820
  • Jul 28 17:53
    CaselIT locked #6820
  • Jul 28 17:14
    jvanasco synchronize #334
  • Jul 28 16:03
    zzzeek milestoned #6821
  • Jul 28 16:03
    zzzeek labeled #6821
  • Jul 28 16:03
    zzzeek labeled #6821
  • Jul 28 16:03
    zzzeek unlabeled #6821
  • Jul 28 15:30
    EvanWMorton labeled #6821
  • Jul 28 15:30
    EvanWMorton opened #6821
  • Jul 28 13:17
    zzzeek labeled #6820
  • Jul 28 12:49
    zzzeek labeled #6820
  • Jul 28 12:49
    zzzeek unlabeled #6820
  • Jul 28 07:29
    franck-serot labeled #6820
  • Jul 28 07:29
    franck-serot opened #6820
  • Jul 27 23:52
    huntfx closed #6811
  • Jul 27 20:47
    jvanasco opened #334
Federico Caselli
@CaselIT
ok.
I think I'll start by passing the stuff to create the event key when creating the wrapper, just to see what breaks with that change. when in review you can point to better alternative
mike bayer
@zzzeek
ok
Federico Caselli
@CaselIT
thanks
@bryanforbes are you working on sqlalchemy/sqlalchemy2-stubs#51 ? If not I think it can be merged and anything that I mentioned could be done in a later pr
Bryan Forbes
@bryanforbes
yeah, I’ll take care of it
Federico Caselli
@CaselIT
ok

yeah, I’ll take care of it

sorry, rereading I wonder if I understood wrong. are you working on it or you can take care of it later. sorry :)

Bryan Forbes
@bryanforbes
I’m working on it now
Federico Caselli
@CaselIT
ok
Bryan Forbes
@bryanforbes
@CaselIT pushed
Federico Caselli
@CaselIT

do you think the return thing would work?

it does not, since retvat=True is a thing, that while not really useful with once=True works at least once

mike bayer
@zzzeek
I would just be adding the listener to some collection somewhere
Federico Caselli
@CaselIT
oh retval=True event behave differently
meaning thay are not called by the event but explicetly
Federico Caselli
@CaselIT
Bryan Forbes
@bryanforbes
@zzzeek the update to strict mode is large, but no new functionality is added
mike bayer
@zzzeek
@bryanforbes whichj is this
I just pushed it
mike bayer
@zzzeek
wow mr fast
Bryan Forbes
@bryanforbes
lol
I’ve been working on it since late last week
mike bayer
@zzzeek
so, "strict mode", meaning the plugin itself passes mypy --strict ?
Bryan Forbes
@bryanforbes
yup
mike bayer
@zzzeek
failed orderinglist1
err 2
Bryan Forbes
@bryanforbes
lies
mike bayer
@zzzeek
well both
test_mypy[orderinglist1.py] FAILED [ 69%]
test/ext/mypy/test_mypy_plugin_py3k.py::MypyPluginTest::test_mypy[orderinglist2.py] FAILED [ 72%]
Bryan Forbes
@bryanforbes
ok, I’ll look into it tomorrow
mike bayer
@zzzeek
ok
once we have all tyour stubs2 prs in i should put out a release
Bryan Forbes
@bryanforbes
I wonder if it’s a problem with mypy 0.812
hmmm… it passes just fine with 0.812 and the latest stubs release
I’m not sure why it’s failing in jenkins
Bryan Forbes
@bryanforbes
I’ll snag 3.7.9 and test the plugin there
yeah, it fails on 3.7.9
so weird
mike bayer
@zzzeek
@bryanforbes looks like the orderinglist fail is in master, maybe it's from the other PR I merged?
Bryan Forbes
@bryanforbes
nah, it fails for me if I run the tests in 3.7.9
mike bayer
@zzzeek
that's the older mypy right?
Bryan Forbes
@bryanforbes
no, it’s 0.812
mike bayer
@zzzeek
oh 3.7.9 == python 3.7.9 ?
Bryan Forbes
@bryanforbes
yup
mike bayer
@zzzeek
oh
I think this was passing yesterday, is what im saying
yeah
started failing for unknown reasons