Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 19:49
    umbrae opened #932
  • 19:05
    jvanasco edited #7086
  • 18:45
    jvanasco edited #7086
  • 18:18
    jvanasco labeled #7086
  • 18:18
    jvanasco labeled #7086
  • 18:18
    jvanasco opened #7086
  • 16:41
    zzzeek labeled #931
  • 16:41
    zzzeek unlabeled #931
  • 16:33
    abitrolly opened #931
  • 16:33
    abitrolly labeled #931
  • 15:14
    gordthompson assigned #7065
  • 15:08
    sqla-tester closed #926
  • 13:49
    sqlalchemy-bot closed #3086
  • 13:49

    sqlalchemy-bot on master

    Fixes: #3086 show that `server… (compare)

  • 12:45
    CaselIT labeled #7083
  • 12:45
    CaselIT labeled #7083
  • 12:44
    CaselIT opened #7083
  • 10:15
    JonathanWylie edited #341
  • 07:19
    CaselIT labeled #7082
  • 07:19
    CaselIT labeled #7082
mike bayer
@zzzeek
@bryanforbes whichj is this
I just pushed it
mike bayer
@zzzeek
wow mr fast
Bryan Forbes
@bryanforbes
lol
I’ve been working on it since late last week
mike bayer
@zzzeek
so, "strict mode", meaning the plugin itself passes mypy --strict ?
Bryan Forbes
@bryanforbes
yup
mike bayer
@zzzeek
failed orderinglist1
err 2
Bryan Forbes
@bryanforbes
lies
mike bayer
@zzzeek
well both
test_mypy[orderinglist1.py] FAILED [ 69%]
test/ext/mypy/test_mypy_plugin_py3k.py::MypyPluginTest::test_mypy[orderinglist2.py] FAILED [ 72%]
Bryan Forbes
@bryanforbes
ok, I’ll look into it tomorrow
mike bayer
@zzzeek
ok
once we have all tyour stubs2 prs in i should put out a release
Bryan Forbes
@bryanforbes
I wonder if it’s a problem with mypy 0.812
hmmm… it passes just fine with 0.812 and the latest stubs release
I’m not sure why it’s failing in jenkins
Bryan Forbes
@bryanforbes
I’ll snag 3.7.9 and test the plugin there
yeah, it fails on 3.7.9
so weird
mike bayer
@zzzeek
@bryanforbes looks like the orderinglist fail is in master, maybe it's from the other PR I merged?
Bryan Forbes
@bryanforbes
nah, it fails for me if I run the tests in 3.7.9
mike bayer
@zzzeek
that's the older mypy right?
Bryan Forbes
@bryanforbes
no, it’s 0.812
mike bayer
@zzzeek
oh 3.7.9 == python 3.7.9 ?
Bryan Forbes
@bryanforbes
yup
mike bayer
@zzzeek
oh
I think this was passing yesterday, is what im saying
yeah
started failing for unknown reasons
oh, things were committed to sqlalhcemy2-stubs re: ordering list
that's it
Federico Caselli
@CaselIT
what's ProperType?
Bryan Forbes
@bryanforbes
it’s the base of most of the internal types except for Type and TypeAliasType
get_proper_type() solves aliases for us
Federico Caselli
@CaselIT
so issubclass(x, type) and x != type
Bryan Forbes
@bryanforbes
when I said Type above, I meant mypy.types.Type
they’re mypy types
Federico Caselli
@CaselIT
ah ok.
I thought python ones
so it's basically mypy any
Bryan Forbes
@bryanforbes
so you’ve got things like TypeAliasType, Instance, and UnionType
eh, kind of
but not really
@zzzeek do you want me to do a separate fix for the orderinglist stuff? or just include it in the strict mode one?
mike bayer
@zzzeek
@bryanforbes i think it might be just the tests that have a problem im triyng to see if i can fix them now
Bryan Forbes
@bryanforbes
that’d be nice