Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Sep 18 15:26
    abitrolly review_requested #926
  • Sep 18 15:24
    abitrolly synchronize #926
  • Sep 18 15:23
    abitrolly synchronize #926
  • Sep 18 15:23
    abitrolly synchronize #926
  • Sep 18 14:56

    sqlalchemy-bot on master

    pin asyncmy>=0.2.0 and remove c… Merge "pin asyncmy>=0.2.0 and r… (compare)

  • Sep 18 14:51
    zzzeek review_requested #926
  • Sep 18 14:31
    abitrolly opened #926
  • Sep 18 14:30
    zzzeek review_requested #7047
  • Sep 18 14:00
    sqlalchemy-bot closed #6832
  • Sep 18 14:00

    sqlalchemy-bot on master

    Surface driver connection objec… Merge "Surface driver connectio… (compare)

  • Sep 18 11:55
    CaselIT closed #924
  • Sep 18 11:55
    CaselIT locked #924
  • Sep 18 11:55
    CaselIT unlabeled #924
  • Sep 18 11:50
    CaselIT closed #5831
  • Sep 18 08:48
    abitrolly opened #924
  • Sep 18 08:48
    abitrolly labeled #924
  • Sep 18 05:32
    grooverdan opened #7047
  • Sep 17 23:08
    shdai12 edited #923
  • Sep 17 21:30

    sqlalchemy-bot on rel_1_2

    add attribute sphinx is breakin… (compare)

  • Sep 17 21:30

    sqlalchemy-bot on rel_1_3

    add attribute sphinx is breakin… (compare)

Bryan Forbes
@bryanforbes
hmmm… it passes just fine with 0.812 and the latest stubs release
I’m not sure why it’s failing in jenkins
Bryan Forbes
@bryanforbes
I’ll snag 3.7.9 and test the plugin there
yeah, it fails on 3.7.9
so weird
mike bayer
@zzzeek
@bryanforbes looks like the orderinglist fail is in master, maybe it's from the other PR I merged?
Bryan Forbes
@bryanforbes
nah, it fails for me if I run the tests in 3.7.9
mike bayer
@zzzeek
that's the older mypy right?
Bryan Forbes
@bryanforbes
no, it’s 0.812
mike bayer
@zzzeek
oh 3.7.9 == python 3.7.9 ?
Bryan Forbes
@bryanforbes
yup
mike bayer
@zzzeek
oh
I think this was passing yesterday, is what im saying
yeah
started failing for unknown reasons
oh, things were committed to sqlalhcemy2-stubs re: ordering list
that's it
Federico Caselli
@CaselIT
what's ProperType?
Bryan Forbes
@bryanforbes
it’s the base of most of the internal types except for Type and TypeAliasType
get_proper_type() solves aliases for us
Federico Caselli
@CaselIT
so issubclass(x, type) and x != type
Bryan Forbes
@bryanforbes
when I said Type above, I meant mypy.types.Type
they’re mypy types
Federico Caselli
@CaselIT
ah ok.
I thought python ones
so it's basically mypy any
Bryan Forbes
@bryanforbes
so you’ve got things like TypeAliasType, Instance, and UnionType
eh, kind of
but not really
@zzzeek do you want me to do a separate fix for the orderinglist stuff? or just include it in the strict mode one?
mike bayer
@zzzeek
@bryanforbes i think it might be just the tests that have a problem im triyng to see if i can fix them now
Bryan Forbes
@bryanforbes
that’d be nice
mike bayer
@zzzeek
but i am failing
Bryan Forbes
@bryanforbes
let me check
aha, when I blew away my tox environment, I’m getting the error on 3.9 now
I think I see the problem
collection_class needs to take a class
mike bayer
@zzzeek
yeah but that was a bug that i thougfht i fixed
the whole issue was, haveit take a callable
Bryan Forbes
@bryanforbes
right
mike bayer
@zzzeek
ijust fixedit wrong
Bryan Forbes
@bryanforbes
but the test isn’t updated ;)
mike bayer
@zzzeek
b.c. i didnt bother to look how ordering_list works
Bryan Forbes
@bryanforbes
yeah, the plugin needs to be updated
I’ll take care of it in the morning
Federico Caselli
@CaselIT
ok, nothing broke in https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/2629
could you take a look mike? Not sure how to get back the event key
mike bayer
@zzzeek
@CaselIT i have no idea
the _EventKey is...the key. has to have the oiriginal fn inside of it
that was listened