Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Sep 25 18:43
    zzzeek review_requested #7087
  • Sep 25 15:21
    zkl2 edited #7087
  • Sep 25 15:21
    zkl2 edited #7087
  • Sep 25 15:19
    zkl2 synchronize #7087
  • Sep 25 15:16
    zkl2 edited #7087
  • Sep 25 14:20
    jvanasco commented on 52e8545
  • Sep 25 13:51
    zkl2 opened #7087
  • Sep 25 07:24
    lelit commented on 52e8545
  • Sep 25 06:27
    grooverdan synchronize #7047
  • Sep 24 19:55
    sqlalchemy-bot closed #932
  • Sep 24 19:55

    sqlalchemy-bot on master

    MultiDB README: Add a bit more … (compare)

  • Sep 24 19:49
    umbrae opened #932
  • Sep 24 19:05
    jvanasco edited #7086
  • Sep 24 18:45
    jvanasco edited #7086
  • Sep 24 18:18
    jvanasco labeled #7086
  • Sep 24 18:18
    jvanasco labeled #7086
  • Sep 24 18:18
    jvanasco opened #7086
  • Sep 24 16:41
    zzzeek labeled #931
  • Sep 24 16:41
    zzzeek unlabeled #931
  • Sep 24 16:33
    abitrolly opened #931
Bryan Forbes
@bryanforbes
yeah, it fails on 3.7.9
so weird
mike bayer
@zzzeek
@bryanforbes looks like the orderinglist fail is in master, maybe it's from the other PR I merged?
Bryan Forbes
@bryanforbes
nah, it fails for me if I run the tests in 3.7.9
mike bayer
@zzzeek
that's the older mypy right?
Bryan Forbes
@bryanforbes
no, it’s 0.812
mike bayer
@zzzeek
oh 3.7.9 == python 3.7.9 ?
Bryan Forbes
@bryanforbes
yup
mike bayer
@zzzeek
oh
I think this was passing yesterday, is what im saying
yeah
started failing for unknown reasons
oh, things were committed to sqlalhcemy2-stubs re: ordering list
that's it
Federico Caselli
@CaselIT
what's ProperType?
Bryan Forbes
@bryanforbes
it’s the base of most of the internal types except for Type and TypeAliasType
get_proper_type() solves aliases for us
Federico Caselli
@CaselIT
so issubclass(x, type) and x != type
Bryan Forbes
@bryanforbes
when I said Type above, I meant mypy.types.Type
they’re mypy types
Federico Caselli
@CaselIT
ah ok.
I thought python ones
so it's basically mypy any
Bryan Forbes
@bryanforbes
so you’ve got things like TypeAliasType, Instance, and UnionType
eh, kind of
but not really
@zzzeek do you want me to do a separate fix for the orderinglist stuff? or just include it in the strict mode one?
mike bayer
@zzzeek
@bryanforbes i think it might be just the tests that have a problem im triyng to see if i can fix them now
Bryan Forbes
@bryanforbes
that’d be nice
mike bayer
@zzzeek
but i am failing
Bryan Forbes
@bryanforbes
let me check
aha, when I blew away my tox environment, I’m getting the error on 3.9 now
I think I see the problem
collection_class needs to take a class
mike bayer
@zzzeek
yeah but that was a bug that i thougfht i fixed
the whole issue was, haveit take a callable
Bryan Forbes
@bryanforbes
right
mike bayer
@zzzeek
ijust fixedit wrong
Bryan Forbes
@bryanforbes
but the test isn’t updated ;)
mike bayer
@zzzeek
b.c. i didnt bother to look how ordering_list works
Bryan Forbes
@bryanforbes
yeah, the plugin needs to be updated
I’ll take care of it in the morning
Federico Caselli
@CaselIT
ok, nothing broke in https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/2629
could you take a look mike? Not sure how to get back the event key
mike bayer
@zzzeek
@CaselIT i have no idea
the _EventKey is...the key. has to have the oiriginal fn inside of it
that was listened
two EventKey w/ same state can add /remove that event
i will say this whole area has to be super careful b.c. it has to automatically GC itself when the thing being listened is GC'ed
@CaselIT I would say, when you have an only_once function, as it runs, at that point it should add it's key to some global (thread local?) collection , then the registry thing should just be checking that every time and emptying it out