Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 15:35
    zzzeek milestoned #9222
  • 15:35
    zzzeek labeled #9222
  • 15:35
    zzzeek labeled #9222
  • 15:35
    zzzeek unlabeled #9222
  • 15:35
    zzzeek labeled #9222
  • 15:35
    gordthompson closed #19
  • 15:29
    zzzeek closed #9224
  • 15:29
    zzzeek locked #9224
  • 15:29
    alicanyuksel edited #9224
  • 15:28
    alicanyuksel edited #9224
  • 15:28
    alicanyuksel edited #9224
  • 15:27
    alicanyuksel labeled #9224
  • 15:27
    alicanyuksel opened #9224
  • 15:10
    zzzeek labeled #9220
  • 15:10
    zzzeek labeled #9220
  • 15:10
    zzzeek labeled #9220
  • 14:25
    zzzeek closed #9221
  • 14:18
    zzzeek labeled #9220
  • 14:18
    zzzeek labeled #9220
  • 14:18
    zzzeek milestoned #9220
Federico Caselli
@CaselIT
there be async dragons in this case
Federico Caselli
@CaselIT

" send in the dragons on async_scoped_session " sqlalchemy/sqlalchemy@ac46321

ahahah

Alex Grönholm
@agronholm
yup, scoped sessions are problematic exactly because people don't think to close them...just the other day I was advising somebody who thought scoped sessions were "automatically managed" and didn't need to be closed.
2 replies
Federico Caselli
@CaselIT
@zzzeek the dataclasses stuff seems pretty easy to extend
mike bayer
@zzzeek
@CaselIT im sure it's not too hard as long as you arent doing slots
Federico Caselli
@CaselIT
yes, I think slots would require support in the orm
since you would need to add the _sa_... slot too
Federico Caselli
@CaselIT
but since there is basically no change compared with a plain class, I think we can live without supporting them
mike bayer
@zzzeek
I got ranges and multiranges working on asyncpg etc
was MUCH easier than I thought, psycopg has lots of complex stuff that isn't needed
@CaselIT re: slots, yes we'd need a big attribute change, since the InstanceState needs to have a "dict", so it would need to know how to get a "dict" from a slots class
@CaselIT all very doable, but a lot of work and also InstanceState kind of defeats the "performance" goal
@CaselIT having a "dict" over a slots class has to be a cython thing otherwise it's much slower than not using slots
Federico Caselli
@CaselIT
I'm really not sure it's worth it, since the performance change is negligible compared with a normal class
mike bayer
@zzzeek
just tried to release and twine upload seems to be silently failing
Jonathan Vanasco
@jvanasco
is it maybe from that new "protected projects" thing?
mike bayer
@zzzeek
@jvanasco seems very likely
pypi/warehouse#12041
Federico Caselli
@CaselIT
Strange, we use a token to upload
the github action haa still not run. lets see if that fails, but in any case its strange that twine is happy but nothing happens
Federico Caselli
@CaselIT
I think there is something strange going on on pypi side. This errors https://test.pypi.org/project/SQLAlchemy/
Federico Caselli
@CaselIT
It seem to be working now
mike bayer
@zzzeek
they pushed a front-end thing that broke the view
so we were seeing cdn cached
and twine upload happily says nothing if file already exists
Federico Caselli
@CaselIT
Well at least it's not our fault
mike bayer
@zzzeek
nope
it's jsut twine's silent failure made me unsure if upload was just afiling
instead of dumb UX bug
Federico Caselli
@CaselIT
Still twine could say something when the file already exists even if it still exists with success
mike bayer
@zzzeek
yes
Federico Caselli
@CaselIT
we seem to have comments also on mssql
mike bayer
@zzzeek
hey folks just making berakfast will be there in 5
Gord Thompson
@gordthompson

we seem to have comments also on mssql

@CaselIT - Where?

Federico Caselli
@CaselIT
hi all
Gord Thompson
@gordthompson
hey
Federico Caselli
@CaselIT
I've added as reviewer in the change https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/4016
Gord Thompson
@gordthompson
oh, ok. I thought you meant comments in an issue/discussion.
Federico Caselli
@CaselIT
nope
Gord Thompson
@gordthompson
The thing about table comments, etc. in mssql is that nobody uses them.
Federico Caselli
@CaselIT
btw, maybe this could be an alternative to zimports that let us avoid maintaining it? https://github.com/asottile/reorder_python_imports

The thing about table comments, etc. in mssql is that nobody uses them.

you have to do wired things to use them

Gord Thompson
@gordthompson
Perhaps I should have said "nobody uses them with DDL", esp. because of the "weirdness". If you add a comment in SSMS then you're already using SSMS so it's way easier to just change it there. (Although I must confess that I don't use them myself so I don't know how good SSMS is at managing such things.)
mike bayer
@zzzeek
awrite
Federico Caselli
@CaselIT
hey mike
mike bayer
@zzzeek
@gordthompson nobody uses 90% of the silly stuff we support
comments in SQL on any backend. weird
Federico Caselli
@CaselIT
the issue is that everyone uses a different 10%
mike bayer
@zzzeek
yes!
Federico Caselli
@CaselIT
re-posting since mike is the intended target