SQLAlchemy weekly dev meetings: https://docs.google.com/document/d/1WuzZwV_aIV_ltDR3cJ-bXxXMZ9zCfr5pFSXZGZOSSQw/edit?usp=sharing
2 replies
since you would need to add the
_sa_... slot too
was MUCH easier than I thought, psycopg has lots of complex stuff that isn't needed
@CaselIT re: slots, yes we'd need a big attribute change, since the InstanceState needs to have a "dict", so it would need to know how to get a "dict" from a slots class
@CaselIT all very doable, but a lot of work and also InstanceState kind of defeats the "performance" goal
@CaselIT having a "dict" over a slots class has to be a cython thing otherwise it's much slower than not using slots
the github action haa still not run. lets see if that fails, but in any case its strange that twine is happy but nothing happens
I think there is something strange going on on pypi side. This errors https://test.pypi.org/project/SQLAlchemy/
so we were seeing cdn cached
and twine upload happily says nothing if file already exists
it's jsut twine's silent failure made me unsure if upload was just afiling
instead of dumb UX bug
btw, maybe this could be an alternative to zimports that let us avoid maintaining it? https://github.com/asottile/reorder_python_imports
The thing about table comments, etc. in mssql is that nobody uses them.
you have to do wired things to use them
Perhaps I should have said "nobody uses them with DDL", esp. because of the "weirdness". If you add a comment in SSMS then you're already using SSMS so it's way easier to just change it there. (Although I must confess that I don't use them myself so I don't know how good SSMS is at managing such things.)
comments in SQL on any backend. weird
btw, maybe this could be an alternative to zimports that let us avoid maintaining it? https://github.com/asottile/reorder_python_imports