Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 13:39
    flapili labeled #806
  • 13:39
    flapili opened #806
  • Feb 27 17:51
    zzzeek milestoned #765
  • Feb 27 17:50
    zzzeek milestoned #803
  • Feb 27 17:05
    sqlalchemy-bot closed #805
  • Feb 27 17:05

    sqlalchemy-bot on master

    Add async template to Alembic … (compare)

  • Feb 26 20:31

    sqlalchemy-bot on master

    Add missing colon before code b… (compare)

  • Feb 26 18:13
    CaselIT labeled #805
  • Feb 26 18:13
    CaselIT labeled #805
  • Feb 26 15:57
    CaselIT labeled #805
  • Feb 26 15:57
    CaselIT labeled #805
  • Feb 26 15:57
    CaselIT unlabeled #805
  • Feb 26 15:48
    crotaoryx edited #805
  • Feb 26 15:47
    crotaoryx labeled #805
  • Feb 26 15:47
    crotaoryx opened #805
  • Feb 26 15:28

    sqlalchemy-bot on master

    document declarative base made … Merge "document declarative bas… (compare)

  • Feb 26 15:27
    CaselIT milestoned #5987
  • Feb 26 15:27
    CaselIT labeled #5987
  • Feb 26 15:27
    CaselIT labeled #5987
  • Feb 26 15:27
    CaselIT labeled #5987
mike bayer
@zzzeek
that's in zzzeeksphinx
Federico Caselli
@CaselIT
ok, will have to look at what that thing does
Federico Caselli
@CaselIT
or would that be rude?
mike bayer
@zzzeek
hmm
Federico Caselli
@CaselIT
I mean seriously...
how hard can that be
mike bayer
@zzzeek
i dont undersrtand awaht this person wants to do
there's no "threads" in asyncio
the Session is not concurrency safe even if the connection is
everyone seems to misundersatnd that asyncpg document
mike bayer
@zzzeek
I think what they want to do is exactly the pattern we've taken away which is "autocommit=True"
mike bayer
@zzzeek
I answered
we're going to ahve a flood of users like this
trying to get something for nothing
Federico Caselli
@CaselIT
I saw
mike bayer
@zzzeek
where asyncio means "FREE SPEED!" to them
so dumb
Federico Caselli
@CaselIT
I hope not, but I guess we will in any case :(
Federico Caselli
@CaselIT
@zzzeek updated the zimports pr sqlalchemyorg/zimports#19
mike bayer
@zzzeek
@CaselIT OK. i have a few things i have to get committed and today is a moving slow kind of day overall
Federico Caselli
@CaselIT
no problem. i'll probably rework a bit the vendored file to include flake8 license and all
so there will be another revision for that. the logic should already be final though
I'll open an issue for select in load optimization on secondary relationship, or we will forget
mike bayer
@zzzeek
ok
Federico Caselli
@CaselIT
the target is next week for 1.4?
is it better to release in the weekend or on a weekday?
Federico Caselli
@CaselIT
I guess it was inevitable sqlalchemy/alembic#805 :)
Federico Caselli
@CaselIT
@zzzeek I was thinking for async in alembic, do we have to so something special other than updating the env template so that it's async and runs everything in run_sync?
I mean
def run_migrations_online():
    """Run migrations in 'online' mode.

    In this scenario we need to create an Engine
    and associate a connection with the context.

    """
    engine = getEngine()

    with engine.connect() as connection:
        context.configure(connection=connection, target_metadata=target_metadata, **config_options)

        with context.begin_transaction():
            context.run_migrations()
mike bayer
@zzzeek
i dont know that alembic needs to have an async API ?
Federico Caselli
@CaselIT
no, just the ability to use an async driver
mike bayer
@zzzeek
yes you could use run_Sync in the env.py template
id call this a "recipe"
Federico Caselli
@CaselIT
so, my answer is actually not correct sqlalchemy/alembic#805
maybe we can add a template and docs for the recipe and that's enough
mike bayer
@zzzeek
that's correct, they can do run_sync right now in their env.py
Federico Caselli
@CaselIT
updated
mike bayer
@zzzeek
thanks!
Federico Caselli
@CaselIT
if you like that template I can create a new one
and I think we are 99% of the way of making alembic async
Federico Caselli
@CaselIT
I've updated zimport pr
Gord Thompson
@gordthompson
It looks like I forgot the second colon here so the code block is not rendering the same as the others. If somebody is already working on a patch could they just add the second colon? Seems silly to do a whole new change just for one little docs issue....
It also looks like Sphinx(?) reformatted the block (seen here). I was intending it to look like
    engine = create_engine(
        "mssql+pyodbc://scott:tiger@myhost:port/databasename"
        "?driver=ODBC+Driver+17+for+SQL+Server"
        "&authentication=ActiveDirectoryIntegrated"
    )
Federico Caselli
@CaselIT
I think you can use the """ for for the text
and I think you can just push to gerrit master that change :)
cmq alembic is happy with async env :)
Federico Caselli
@CaselIT
I've added an async template to alembic in https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/2609
Federico Caselli
@CaselIT
@gordthompson fixed here sqlalchemy/sqlalchemy@aae934d
2 replies