by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Aug 14 17:12
    mgrojo commented #2371
  • Aug 14 15:54
    ludwa6 commented #2371
  • Aug 14 15:32
    chrisjlocke commented #2371
  • Aug 14 15:29
    ludwa6 commented #2371
  • Aug 14 15:26
    ludwa6 commented #2371
  • Aug 14 14:43
    MKleusberg commented #2371
  • Aug 14 14:37
    chrisjlocke commented #2371
  • Aug 14 14:36
    chrisjlocke commented #2371
  • Aug 14 13:59
    ludwa6 opened #2371
  • Aug 14 13:07
    justinclift commented #2349
  • Aug 14 12:43
    MKleusberg commented #2349
  • Aug 13 20:57
    scottfurry commented #2354
  • Aug 13 20:56
    scottfurry commented #2354
  • Aug 13 17:42
    chrisjlocke commented #2370
  • Aug 13 17:01
    revolter commented #2354
  • Aug 13 16:56
    revolter commented #2354
  • Aug 13 16:01
    justinclift commented #2370
  • Aug 13 15:58
    afygit opened #2370
  • Aug 13 14:39
    justinclift commented #2349
  • Aug 13 14:37
    justinclift commented #2349
Justin Clift
@justinclift
Nah, it's just the changes since the alpha1 release. #1784 was already included in that.
Looking at the alpha1 release notes, #1784 seems like it was given only a cursory mention instead of a proper entry. eg we mostly missed it. :frowning:
Let's make sure it's included with a proper full line entry in the final release notes. :smile:
Scott Furry
@scottfurry
:thumbsup:
Everytime I think of "releases", head goes back to one of the original (early 90's) email jokes that circulated. http://gradha.sdf-eu.org/textos/klingon_programmer.en.html #6 seems applicable. :D
Justin Clift
@justinclift
Don't think I've come across that before. :)

Heh Heh Heh

This machine is GAGH! I need dual Pentium processors if I am to do battle with this code!

Sitting next to me is an old dual Nocona (Xeon) machine. Technically it's functional, though I've taken out the power supply and used it in another box. But if power supply is put back in, it runs.

It runs Win7 reasonably ok, with it's ECC 5GB of ram. Linux doesn't boot on it, though FreeNAS does.
It was probably made in about the same era as that article. :)
Well, not quite. Nocona Xeon's were from ~2004. But similar level of ancient feel.
Scott Furry
@scottfurry
Proverbial "Stone Tablet" of silicon. :D
Justin Clift
@justinclift
@scottfurry Adding #1784 to the 3.12.0 release notes now. Glad I didn't forget. :smile:
Scott Furry
@scottfurry
@justinclift appreciate the thought. I saw the release notes email a couple hours ago. True that antlr-2 is no longer a requirement?
Justin Clift
@justinclift
I guess so. @MKleusberg would be the better person to check with, as I've not touched that code at all. Didn't really understand parsers until recently, when learning more about how SQLite itself parses stuff. :smile:
Scott Furry
@scottfurry
Believe me, train track diagrams are painful to parse/process mentally.
Martin Kleusberg
@MKleusberg
@scottfurry Yes, antlr2 is no longer a requirement. I replaced the antlr-based parser by a bison-based parser. So we no longer need the antlr2 library. Also the new bison parser doesn't depend on any extra library which means we don't have to add a new dependency instead.
Scott Furry
@scottfurry
@MKleusberg - Just to clarify - there is a bison dependency that replaces antlr. Correct? (asking to clarify build instructions)
Martin Kleusberg
@MKleusberg
No, no new dependency. The Antlr parser generator creates some C++ files which depends on an external library. The bison parser generator creates some C++ files with no dependencies.
You only need bison when changing the parser itself in order to regenerate the C++ files.
Scott Furry
@scottfurry
@MKleusberg - Bison only needed when changing development sources not building. Perfect!
Martin Kleusberg
@MKleusberg
Exactly :smile:
That was one of the intended benefits of the new parser by the way.
Scott Furry
@scottfurry
\o/ \0/ - touchdown - crowd goes wild
Martin Kleusberg
@MKleusberg
Heh heh. I should add though that for developing on the parser you actually need bison and flex. So it's two tools actually. But still, neither of them is a dependency for building.
Justin Clift
@justinclift
No major bugs have been reported for the new DB4S release for the first day, so I just updated the currentrelease file in our GitHub repo to point at it. That'll kick off the "new version is available" message for people running 3.10.x and older. If things still look good tomorrow, I'll do the same for the currentreleasefile on our download server. That'll show the notification for anyone running 3.11.x onwards. :smile:
Justin Clift
@justinclift
Meh, just updated the one on our download server now instead. Download server doesn't seem to be having any issues, though I should probably read the nload man page and figure out how to change the graph limits. eg this is the download server a few seconds ago (inbound and outbound):
202006171857-download_server-nload_graph.png
Scott Furry
@scottfurry
@justinclift @MKleusberg - I got the Cherry-Pick instructions. However, this raises a question in my mind. Does this not lead to multiple PR's? There would be the PR to the master branch. Once that gets approved, would another PR be needed to merge something into the 3.12.x branch where situation warrants?
Justin Clift
@justinclift
Not generally. With most projects, the PR is done to the head of the main development branch. master in our case. That ensures the change is baked in, and part of all future releases. With that done, one of project committers can cherry-pick it from the master branch to whichever other branches need it.
With our project, we seem to really only do stuff with the last major release branch (eg v3.12.x now) and master, so it's fairly straight forward. :smile:
Scott Furry
@scottfurry
Have a PR in the works that addresses resolving obsolescence. Need a dataset that I can stress test application UI.
Probably need to modify Github Issue template: '3.12.0-(alpha or betas)'
Scott Furry
@scottfurry
NM, had a db from helping someone months ago. Met needs. PR to follow.
Justin Clift
@justinclift
Good reminder about the GitHub issue template. Just updated it. :smile:
Ok, the PortableApp for 3.12.0 is online now too. I think all of the bits needed for it are done.
Justin Clift
@justinclift
Just announced that via Twitter too.
Scott Furry
@scottfurry
@justinclift @MKleusberg @chrisjlocke https://www.kdab.com/fixing-a-common-antipattern-when-loading-translations-in-qt/ Seems we can do something different to respect user's locale WRT QTranslator in src/Application.cpp
Justin Clift
@justinclift
@scottfurry Good catch. :smile:
Scott Furry
@scottfurry
Heads up. Qt Korean group has published an English/Korean Qt PDF book - http://qt-dev.com/board.php?board=kkknotice&command=body&no=48&
Justin Clift
@justinclift
Took a look, but there's religious brainwashing/indoctrination crap all through it. eg "Jesus loves you" stuck prominently in the header on every page, quotes from the bible embedded, etc.
That's a real shame, as it could otherwise have been good content for people. In it's current form, very much avoid.
Scott Furry
@scottfurry
Damn. Missed that. I tucked that pdf away for future reading until you mention ^^^. You're right. That makes the PDF difficult to share/distribute.
Scott Furry
@scottfurry
That's what bug reports are for.
Justin Clift
@justinclift
True, but I seriously doubt people that far gone are going be ok with someone asking them to remove it. :wink:
Scott Furry
@scottfurry
@justinclift Re: #2321 - this one seems a touch vexing. I just looked at the DB4S dependencies on Linux and qt5svg doesn't show. But I recall we went back and forth about svg images (mostly for desktop purposes). I suspect the problem encountered is something to do with the default image handlers qt (or us for that matter) that are loaded. And a missing handler for svg images caused the crash (dll not packaged). That's my theory, anyway.
Justin Clift
@justinclift
@scottfurry For the crash aspect, I'm thinking it was more like this:
  1. Qt loads plugins/imageformats/qsvg.dll from the DB4S install directory. Our Qt dll's at the moment are version 5.12.8. Instead of that qsvg.dll being all that's needed, that dll turned out to have a dependency on Qt5Svgd.dll (which we weren't packaging).
  2. So, Qt asks the OS (or whatever) to find and load that Qt5Svgd.dll.
  3. For the case where the user already has an install of Qt 5.9.2, the Qt5Svgd.dll from that was being picked up and loaded.
  4. The crash then happens when DB4S tries to use SVG, as Qt 5.9.2 libraries aren't compatible with Qt 5.12.x ones.
The fix was simply to include the correct version of Qt5Svgd.dll with our packaging, so there's no need for the OS (or whatever) to go looking around for a potentially different one.
Scott Furry
@scottfurry
I haven't actively used a Win box in years but even I know mixing versions of dll's is bad. This sounds like dependency version management malfunction.
Justin Clift
@justinclift
Yeah. :smile:
IoTFier
@IoTFier
Hi, how do I update exiting installation of sqlitebrowser with new version ? The .msi shows change / repair / remove option but it is not upgrading previous .11 one
Justin Clift
@justinclift
@IoTFier Hmmm, in that case it's probably best to choose the "Remove" option for the 3.11 one, and do a fresh install of the 3.12 one.
If that doesn't work either, let us know. :)