Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Dec 12 16:18
    squidfunk commented #1306
  • Dec 12 16:10
    wilhelmer commented #1306
  • Dec 12 15:56
    squidfunk commented #1306
  • Dec 12 15:54
    squidfunk commented #1383
  • Dec 12 15:53
    wilhelmer commented #1306
  • Dec 12 15:17
    dajohi synchronize #1383
  • Dec 12 15:13
    dajohi opened #1383
  • Dec 12 07:20

    squidfunk on gh-pages

    Deployed 993c728 with MkDocs ve… (compare)

  • Dec 12 07:20

    squidfunk on master

    Fixed typo in documentation (#1… (compare)

  • Dec 12 07:20
    squidfunk closed #1382
  • Dec 12 07:17
    coliff opened #1382
  • Dec 12 06:40

    squidfunk on gh-pages

    Deployed fe7bfa2 with MkDocs ve… (compare)

  • Dec 12 06:39
    squidfunk commented #1381
  • Dec 12 06:39

    squidfunk on master

    Fixed URL on revision-date.md (… (compare)

  • Dec 12 06:39
    squidfunk closed #1381
  • Dec 12 00:30
    coliff opened #1381
  • Dec 11 21:55
    looshlee deleted #1380
  • Dec 11 21:40
    Stanzilla commented #1380
  • Dec 11 21:39
    Stanzilla closed #1380
  • Dec 11 21:39
    Stanzilla opened #1380
Martin Donath
@squidfunk
Jep, but probably only for the colors with some solid fallbacks. If adoption is good, we may introduce even more variables for spacing etc.
Benjamin Staneck
@Stanzilla
cool! Like 90% of my diff is
image.png
Martin Donath
@squidfunk
Jep, all that's defined in the config.scss file will be replaced with variables.
Benjamin Staneck
@Stanzilla
oh btw you never increased the version number in the typscript branch, sometimes confuses me :D
Martin Donath
@squidfunk
Didn't merge master back in. Will do when I'm finished
Benjamin Staneck
@Stanzilla
I would love to help you out more with some stuff but I'm not sure I can do it to your standards atm. so much work @work
Martin Donath
@squidfunk
No worries. v5 will take some more time, especially search is tricky to get right with all fallbacks (web worker, no web worker, local storage, no local storage, compression, prebuild indexes etc. etc)
Benjamin Staneck
@Stanzilla
trying to get corp to agree on contributing back to open source is hard
Martin Donath
@squidfunk
Been there. As a freelancer I normally just do it :D
Benjamin Staneck
@Stanzilla
right, I added a webworker as well, doesn't do much atm though. just install website as app
yeah I was going to (as I'm currently doing via feedback which I hope is a bit helpful at least)
Martin Donath
@squidfunk
Absolutely. Your feedback is much appreciated
I currently have to strike a balance between working on Material, earning some money on client projects and working on my own startup. This is why everything takes longer than expected.
Benjamin Staneck
@Stanzilla
that's good to hear. I never worked much with markdown parsing before and it's uhhh weird
oh yeah I wanted to try to get them to support you via patreon or so
it's the least we can do
Martin Donath
@squidfunk
Nah it’s fine. I’ve quite an audience now with Material, think I know a good way how to turn this into opportunities 😊 but pleased to hear that!
Benjamin Staneck
@Stanzilla
:)
markdown linters are the bane of my existence, getting stuff to work consistently and then have your team use it is impossible
yesterday I found out that markdownlint can't use some of it's own configuration format files in the vscode extension but it works fine in CLI, like...whatttttt
Martin Donath
@squidfunk
Haha ive been long enough in this domain to know that in a way, everything is broken. I’m absolutely amazed how stuff keeps working together so well
My last experience was: I’m gonna use storybook! 4 hours later I made my first PR to storybook
Benjamin Staneck
@Stanzilla
haha
Martin Donath
@squidfunk
Ok signing off, must focus on some stuff
Benjamin Staneck
@Stanzilla
I have to babysit our editors and I was getting so mad because their submissions were still in the wrong format even after forcing editor extensions on them for the configs
then I found the format file thing
alright, thanks for your help!
Benjamin Staneck
@Stanzilla
@squidfunk what would be the best way to detect when the page is in hamburger nav mode? from JS that is
Benjamin Staneck
@Stanzilla
basically I want to hide the normal navigation if tabs are enabled and a section only has one page, not sure how to do best
Bhathiya Jayasekara
@bhathiya
it takes about 20-30 seconds to see results when I start typing something on the search bar. we have quite a lot pages. i think time is taken to index at focus. do you see any issues if I index at page load?
Mark Allasread
@markallasread
@bhathiya how many pages btw? Just curious. I'm on the way towards ~300 pages with no issues yet
(but minimal media)
Bhathiya Jayasekara
@bhathiya
3407 :)
Mark Allasread
@markallasread
Oof. k! :p Might need to await that refactor then.
Bhathiya Jayasekara
@bhathiya

I hope this is correct.

[00:32:40] bhathiya@MacBookPro:~/git/docs-apim/en/site$ find . -print | wc -l
3407

ah no, this contains all images as well
Mark Allasread
@markallasread
find . -name '*.md'|wc -l
In docs, that is.
Bhathiya Jayasekara
@bhathiya
hmm. only 697
but a page is a bit long usually. maybe that's why
Bhathiya Jayasekara
@bhathiya
btw, what's the refactor you were talking about?
any changes coming to optimize the indexer?
Benjamin Staneck
@Stanzilla
@bhathiya check the refactor/rxjs-typescript branch
Martin Donath
@squidfunk
@bhathiya search performance should greatly improve with the next release I’m currently working on. Until then you may check out the PR by @wilhelmer which moves search into a web worker to improve performance. If you load it during page load in the main thread, the UI might freeze for a few hundred ms on every load.
@Stanzilla regarding the hamburger menu: you can just use a media query, I think it’s max-width: 1219px - this is at least how it’s done in the themes CSS and JS
Benjamin Staneck
@Stanzilla
alright, I'm sort of happy with using <nav class="md-nav md-nav--primary" data-md-level="1"> though
well actually no, the single pages still look weird
Martin Donath
@squidfunk
I think I’ve seen some installation on the theme achieving what you want but don’t know where actually
Benjamin Staneck
@Stanzilla
oh okay