Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Tuan Do
    @followthesheep
    @AnujAgrawal30 to have a good proposal, you should contribute some PR’s to the project and reference it in your application. See examples of previous successful submissions here: http://opensupernova.org/starkit_gsoc2019/doku.php?id=start
    if you are planning to work on the testing framework, submit a test and show it working
    AnujAgrawal30
    @AnujAgrawal30
    Yeah sorry I though at this stage only gist would work,
    starkit/starkit#52 is the PR for the same. I've also included it in my proposal
    Nimish Khurana
    @Nimishkhurana
    I have made a proposal for Spectral Grid generation and visualization, as suggested by the project mentor @dchu808 and sent it to @dchu808, but he is not active from 2 days. Can anyone else review my proposal.
    Tuan Do
    @followthesheep
    @Nimishkhurana okay, send it to me
    Simranjit Singh Pabla
    @Pabla007
    @wkerzendorf Sir i have made changes in the proposal again as per told by you so have a look on it.
    Jaladh Singhal
    @jaladh-singhal

    @wkerzendorf As I'm resuming my work on resolving errors in wsynphot installation & in its Travis CI. So I need to use similar environment file of starkit for fixing problems in wsynphot (like setuptools downgrade, uniformity in installation procedure in docs), as we discussed before:

    try to make them similar - we also need to upgrade wsynphot to python3

    But I spotted that starkit has upgraded to python3. So I wanted to know if this upgrade of starkit is complete?
    If yes, then we can 1st work on upgrading wsynphot and then I will use starkit_env3.ymlfor completing fixes in wsynphot.
    Otherwise I will use starkit_env27.yml like I was doing earlier to fix it for the current environment (2.7)?

    Jaladh Singhal
    @jaladh-singhal
    @wkerzendorf As pointed earlier by the other members in this channel, I also experienced that installing starkit using env2.7 gives error. To fix it, I created a PR starkit/starkit#54
    Please review it.
    Jaladh Singhal
    @jaladh-singhal
    @wkerzendorf Please review starkit/starkit#55
    It fixes that syntax error in print statement and reconfigures Travis CI to run it for both python2.7 & 3. Also I ensured that the build passes on Travis CI.
    Wolfgang Kerzendorf
    @wkerzendorf
    @jaladh-singhal looks good - btw did you ever make travis build the documentation using doctr? you can look at our sister project github.com/tardis-sn/tardis how this is done.
    Jaladh Singhal
    @jaladh-singhal
    @wkerzendorf Surely I'll look at it & try. But as fixing the wsynphot installation is a priority, I will try to do it after that. Since now starkit installation is error free, I am starting to do same with wsynphot on same lines, a/c to approach as mentioned before.
    Then as planned (in my proposal timeline), when I'll put wsynphot & starkit installation steps in docs, I can carry on with doctr documentation work. Is that fine or should I go for it 1st?
    Wolfgang Kerzendorf
    @wkerzendorf
    sounds good
    Jaladh Singhal
    @jaladh-singhal
    OK :+1:
    And one question, should I focus on making wsynphot installation error free on env2.7 first, or do we need to upgrade it to env3 right now?
    Wolfgang Kerzendorf
    @wkerzendorf
    we should upgrade
    the idea is that we will ditch python2 support for both this year.
    important to note in general - there are no real “users” but most of the use is from us. So we can decide what to do without thinking to much
    Jaladh Singhal
    @jaladh-singhal
    OK :)
    So if upgradation of starkit to python3 is complete, we could try using same env3 file for wsynphot?
    Because I checked that same env27 was working for both.
    Wolfgang Kerzendorf
    @wkerzendorf
    and we’re thinking of switching to Azure -(again tardis can serve as a blueprint)
    azure pipelines
    Jaladh Singhal
    @jaladh-singhal
    You mean we won't be using RTD & Sphinx but Azure & Doctr?
    Wolfgang Kerzendorf
    @wkerzendorf
    yep
    Jaladh Singhal
    @jaladh-singhal
    May I know, are there any problems with RTD & Sphinx?
    Wolfgang Kerzendorf
    @wkerzendorf
    actually only RTD
    yes - RTD has very small workers. That means when we want to make our conda environment they often crash
    we will continue to use Sphinx
    Jaladh Singhal
    @jaladh-singhal
    OK

    So if upgradation of starkit to python3 is complete, we could try using same env3 file for wsynphot?
    Because I checked that same env27 was working for both.

    Is starkit upgradation to 3 finish or there will still any changes pending?

    Wolfgang Kerzendorf
    @wkerzendorf
    I THINK we are done
    but not hundred percent sure
    Jaladh Singhal
    @jaladh-singhal
    OK
    Besides addition of env3 file and changes in python2 syntax, are there any other changes I need to do for upgrading wsynphot to 3?
    Wolfgang Kerzendorf
    @wkerzendorf
    you need to try that out.
    Jaladh Singhal
    @jaladh-singhal
    OK. Travis CI will come to aid :D
    Wolfgang Kerzendorf
    @wkerzendorf
    run the tests locally first.
    you can use the debugger there
    Jaladh Singhal
    @jaladh-singhal
    Yes I'll.
    Same I did in the previous PR. I ran Travis on my fork until build passed before creating PR.
    Jaladh Singhal
    @jaladh-singhal
    @wkerzendorf While working on upgradation of wsynphot to python 3, I found it necessary to 1st resolve the current installation problems in wsynphot & in its Travis CI. So to keep "one PR for one purpose", I've created a PR for those fixes starkit/wsynphot#15 to avoid clutter within the future PR of upgradation.
    Please review it and let me know if there are any changes required.
    Jaladh Singhal
    @jaladh-singhal

    @wkerzendorf I've completed the upgradation of wsynphot to python3 (not sure if it is 100% but Travis CI & I locally, didn't face any problems). Please review the PR starkit/wsynphot#17 and let me know if any further changes are required (But I'll be able to do them after Wednesday due to 3 day end term exams starting from tomorrow ).

    And, since this PR#17 continues the work of PR#15 (previous one) which is not yet merged, so you will see the commits of PR#15 repeated in it. But there won't be any problems, as I will handle this situation as described here.

    Jaladh Singhal
    @jaladh-singhal
    @wkerzendorf is there any work required on PR #15 & #17, or should I begin with building documentation using doctr like you mentioned before?
    Wolfgang Kerzendorf
    @wkerzendorf
    @jaladh-singhal sorry - haven’t had a chance to deal with this yet
    try to the doctr thing - I’m currently at a conference so things are difficult
    Jaladh Singhal
    @jaladh-singhal
    OK
    No problem
    Jaladh Singhal
    @jaladh-singhal

    @wkerzendorf As we discussed (a month ago) that there is need to put installation steps of wsynphot in its docs, I've added some commits in PR starkit/wsynphot#15 to do that. And since past few days, I was trying to make sure that wsynphot can build docs in python 3 env and finally I was able to achieve that today. So I've also added some commits regarding the same in PR starkit/wsynphot#17. When you become free & get time, please review them.

    I've read and understood doctr, it is pretty quick & straight-forward to setup. It needs you (org admin) to generate & add deploy_key. So when you find time and finish key generation, please share the secure key, I will create a PR to setup the deployment from Travis using that key. And since doctr will require us to use python 3 environment, which I've setup for building docs, so there won't be any problem.

    Jaladh Singhal
    @jaladh-singhal
    @wkerzendorf @followthesheep and all the mentors, thank you for letting me be a part of Starkit in this Summer. It will be an incredible learning experience for me. :blush: And I will try my best to achieve my project goals within deadlines.
    So what should be my next task? Should I initiate the discussion about my project?
    Wolfgang Kerzendorf
    @wkerzendorf
    Well done indeed
    Jaladh Singhal
    @jaladh-singhal
    :)
    Soham Gaikwad
    @sohamvg
    @wkerzendorf @followthesheep it was a great experience with starkit so far though I was not selected for GSoC this year. Can you give me some feedback on where things went wrong so that I can improve in future.