Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
Steve Robbins
@steverobbins
Standardizing the output, then based on the output type (json, xml, whatever) it formats it
But your work is the first step
Cameron Chunn
@applehat
I had that thought at well
Since most of the output is tables
could replace the table creation call with an output call of some sort
that could do Tables, or json, or XML
So, this was the first time I ever actually forked and did a pull request
Steve Robbins
@steverobbins
:D
Cameron Chunn
@applehat
Travis-CI failed my build for spacing. hahaha
Steve Robbins
@steverobbins
Yeah I'm pretty OCD about code formatting.
Cameron Chunn
@applehat
Probably a good thing
Im going to fix the stuff and commit again and see what it thinks
Steve Robbins
@steverobbins
You can test without committing too.
Just run vendor/bin/phpcs --standard=./phpcs.xml -v --encoding=utf-8 ./src
Cameron Chunn
@applehat
great. Thank you.
Cameron Chunn
@applehat
Ehh. Tests are failing now.
May have to look at it more tomorrow
Steve Robbins
@steverobbins
Here's what I'm thinking steverobbins/magescan@d2144ce
Steve Robbins
@steverobbins
Woot steverobbins/magescan#118
Cameron Chunn
@applehat
Cool, but the out command doesn't actually output json yet, right?
Cameron Chunn
@applehat
So I forked the latest and im looking at it. I like the way you're going with this way more then my own (the out command) - but it seems json isn't actually an option yet. Gonna mess with it more.
(unless im just missing something, but im pretty sure its not even 7am where you are, so you're probably not around yet ;))
Cameron Chunn
@applehat
ahhhh... Digging around more I figured out that im an idiot =)
Very nice!
Henry van Megen
@hvanmegen
nevermind those pull requests.. I'll create a better pull request to make the code run in PHP 5.3 (sadly enough, Ubuntu 12.04 LTS support demands it)
@steverobbins would you consider pulling those changes for Ubuntu LTS compliancy?
Steve Robbins
@steverobbins
Probably not. It's going to require >=5.5 once this gets merged in https://github.com/steverobbins/magescan/tree/feature/async
Steven Barnes
@salt-lick
Hey you there?
Steve Robbins
@steverobbins
@salt-lick Sure am
Steven Barnes
@salt-lick
Hey - random bug ... on magescan.steverobbins.com if you search + you get a nasty 500 error.
also I submitted a PR on the dev branch today for the readme.md file
Steve Robbins
@steverobbins
Hm, PHP Fatal error: Uncaught exception 'GuzzleHttp\Exception\ConnectException' with message 'cURL error 6: Couldn't resolve host ' '
I guess I should catch those
Okay, I'll take a look
Steven Barnes
@salt-lick
We love your scan tool at our company
Steve Robbins
@steverobbins
:)
Might I ask how/what you use it for? I'm curious about it's applications
Steven Barnes
@salt-lick
I'm a developer at simplehelix.com . We integrated it into an internal portal for our techs to use to just get some basic information about a client's site in a clear and concise picture.
I talked to the guys at MageReport to see if I could work with their API / clone their scan tool to limit the number of Atlantic passages a packet would need but they said no. Also think it had something to do with them being a hosting company also.
Steve Robbins
@steverobbins
Atlantic passages?
Yeah, Mage Report is more SASS oriented. It does a better job at explaining why something is wrong and how to fix it, though. This is tool is just for nerds :P
Steven Barnes
@salt-lick
hops. Most of our customers are in the US and they are in Germany
I did have a question for you... what is your interaction with Magento? Developer, partner, merchant, enthusiast...?
Steve Robbins
@steverobbins
Started as a dev with an agency/partner. Working on internal Magento projects now.
Steven Barnes
@salt-lick
Ah. Any thoughts on 2?
Steve Robbins
@steverobbins
Not really. Haven't dug into it yet. I wish the install was smoother though. And they didn't handle the launch very well (seems rushed). Also documentation still needs work (Rasmus (PHP creator) couldn't figure out how to install).
I am curious about what will happen with Magento Connect though. They said they're going to start auditing/reviewing modules before listing them.
Steven Barnes
@salt-lick
I think it was a ... we are now a new company... let's show everyone our new product and yes... it was rushed. We have been testing it here but not really seeing a huge demand to jump to it right now.
Anyways - another project just landed in my lap. Keep up the great job! Talk to you later.
Steve Robbins
@steverobbins
Thanks for stopping by!