Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Sep 04 13:29
    hawesie synchronize #244
  • Sep 04 13:29

    hawesie on kinetic-devel

    fixed roslaunch command Updated README.md Added packag… Merge pull request #254 from ip… (compare)

  • Sep 04 13:29
    hawesie closed #254
  • Sep 04 13:29
    hawesie commented #254
  • Sep 04 11:23
    ipa-fog opened #254
  • Sep 03 09:32
    knorth55 edited #253
  • Sep 03 09:31
    knorth55 edited #253
  • Sep 02 10:10
    knorth55 edited #253
  • Sep 02 10:08
    knorth55 opened #253
  • Sep 02 08:32
    knorth55 commented #244
  • Sep 02 08:02
    hawesie commented #244
  • Sep 02 07:37
    knorth55 commented #244
  • Sep 02 04:44
    Affonso-Gui commented #251
  • Aug 29 08:53
    hawesie closed #251
  • Aug 29 08:53
    hawesie commented #251
  • Aug 29 08:20
    knorth55 commented #251
  • Aug 17 19:36

    hawesie on melodic-devel

    change host into string Merge pull request #252 from kn… (compare)

  • Aug 17 19:36
    hawesie closed #252
  • Aug 17 19:36
    hawesie commented #252
  • Aug 17 16:00
    knorth55 opened #252
Nick Hawes
@hawesie
good - i think i understand things now! thanks, you're now free to go ;)
Marc Hanheide
@marc-hanheide
cheers!
Marc Hanheide
@marc-hanheide
Oh, did you put an install target for the launch files?
I didn’t see one...
may have missed it
oh nevermind… wrong file
Nick Hawes
@hawesie
# Mark other files for installation (e.g. launch and bag files, etc.)
install(
  DIRECTORY launch/
  DESTINATION ${CATKIN_PACKAGE_SHARE_DESTINATION}
)
Marc Hanheide
@marc-hanheide
all good
I would make that ${CATKIN_PACKAGE_SHARE_DESTINATION}/launch
jsut for consistency
Nick Hawes
@hawesie
but wouldn't that create launch/launch/files.launch ?
Marc Hanheide
@marc-hanheide
now that you say it… I’m not sure enough, try ;-)
Nick Hawes
@hawesie
I have started editing the wiki documentation for the main package: http://wiki.ros.org/mongodb_store
Marc Hanheide
@marc-hanheide
I’m trying to reproduce strands-project/mongodb_store#100
but I can’t… it works for me
Here’s what I did:
  1. apt-get purge for all ros-hydro-mongo-* packages
  2. create catkin workspace A, checked out https://github.com/hawesie/mongodb_store.git, built it, (in a second attempt also installed it)
  3. create catkin workspace B, checked out https://github.com/hawesie/test_store.git, sourced the setup.bash of workspace A, built it, and tried to run it. All fine.
Marc Hanheide
@marc-hanheide
can either of you @hawesie or @cdondrup give me any hints what I might be doing wrong here?
ah… you have MONGODB_CLIENT in your catkin deps in that test_store
I shall try without
OK, now it fails
Marc Hanheide
@marc-hanheide
now I can work on a solution
Marc Hanheide
@marc-hanheide
hands off! I’m working on it!
Marc Hanheide
@marc-hanheide
@jailander and I stumbled about something...
        for extra_client in self.extra_clients:
            if len(entries) == 0:
                extra_collection = extra_client[req.database][req.collection]
                entries =  dc_util.query_message(extra_collection, obj_query, sort_query_tuples, req.single, req.limit)
                if len(entries) > 0:
                    rospy.loginfo("found result in extra datacentre")
            else:
                break
we were not aware that the "extra" clients are not only used for explicit replication, but also are consulted if a query return nothing on the primary... That has enormous side effect. For instance, we dropped a statistics collection on the primary, but still got results... just they took ages to load.
Marc Hanheide
@marc-hanheide
So, we were automatically querying the replication. I don't understand the rationale behind the above behaviour. It looks very dangerous.
So, I understand for replication one has to set these extra clients (why "clients"?), but then one always also buys in this terribly non-transparent behaviour?
Concretely, can we have replication, but really only as backup without this behaviour, @hawesie ?
Nick Hawes
@hawesie
Blimey, I'm not sure I realised it was still doing that. I remember thinking it was pretty dangerous at some point, but didn't think anyone was still using this. I can't imagine anyone uses this "feature" so please cut it out of there.
Marc Hanheide
@marc-hanheide
:smile: :+1:
if this all works we should change the default branch in github to kinetic-devel
Nick Hawes
@hawesie
@marc-hanheide is there an easy way to making that branch release on indigo too but minus the additional mongo package? also, did you branch this from the indigo or jade dev branch?
Marc Hanheide
@marc-hanheide
I branched it from indigo. Wasn't even aware of the jade branch
Marc Hanheide
@marc-hanheide
I have create a PR of the kinetic branch against the hyrdo (that is also indigo) branch, to see if the new version also works with that.
strands-project/mongodb_store#194
the jade branch has some changes that are not conflict-free with neither the hydro-devel nor the new kinetic-devel branch. Maybe you could check that, @hawesie ?
if the kinetic-devel branch also works for indigo, I'd merge it and we could aim to have it all in one branch again.
Marc Hanheide
@marc-hanheide
OK, so strands-project/mongodb_store#194 worked on the new build farm, but not on the old... The old one is outdated so, I wouldn't give too much attention to that. It seems the new kinetic-devel branch also works on indigo then
I have also locally tested that branch in a fresh jade docker image, and all unit tests were passed in that one as well
I think, this indicates we are good to only use the new branch, pending any relevant changes in jade-devel to be ported to that new branch. I'll make the kinetic-devel the new main branch in github already now.
Nick Hawes
@hawesie
jade-devel is out of date anyway, but had a very jade/15.04 specific changes. I propose we drop that now and only support LTS releases anywa
Let me try kinetic-devel locally then I fully support the move to this as the main branch for both indigo and kinetic
Marc Hanheide
@marc-hanheide
:+1:
The new branch worked on jade as well
Nick Hawes
@hawesie
Ok, then we can release that for jade as well. What about releasing these in the main ROS repos?
Marc Hanheide
@marc-hanheide
yes, once you have tested it ;-)
Nick Hawes
@hawesie
I'm just rebuilding the whole ros install on my laptop...
Marc Hanheide
@marc-hanheide
have fun ;-) There's docker for OSX ;-)