Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Alan Pierce
    @alangpierce
    @raylu Hey Ray! I haven't used either of them, mostly I've just seen it on other projects and seems useful. Do you know how they compare with each other?
    I thought those were the big two.
    raylu
    @raylu
    I haven't used codecov much but it seems more featureful than coveralls
    coveralls looks like raylu/levelorm#1
    codecov looks like fossasia/open-event-webapp#2091
    Alan Pierce
    @alangpierce
    Looks like both babel and prettier run codecov in CI but don't have the PR auto-commit (babel has it for old PRs). Might be another config option.
    raylu
    @raylu
    yeah, they're both pretty configurable
    so codecov it is?
    Alan Pierce
    @alangpierce
    Yep, codecov sounds good.
    Thanks!
    Oh also, sucrase is now self-compiled and targets pretty recent JS, so I imagine istanbul might not be happy with it. (I think that's the only popular JS coverage tool?)
    But we could always set up an alternate build that uses tsc (or maybe babel) to compile to ES5 and then run istanbul on that.
    raylu
    @raylu
    halp
    $ uname -a
    Darwin eon 17.7.0 Darwin Kernel Version 17.7.0: Thu Jun 21 22:53:14 PDT 2018; root:xnu-4570.71.2~1/RELEASE_X86_64 x86_64
    
    $ node --version
    v10.11.0
    
    $ yarn test
    yarn run v1.10.1
    $ yarn lint && yarn test-only
    $ sucrase-node script/lint.ts
    > ./node_modules/.bin/tsc --project . --noEmit
    [...]
    > ./node_modules/.bin/eslint './integrations/webpack-object-rest-spread-plugin/src/**/*.ts'
    [...]
    ERROR: /Users/raylu/src/sucrase/integrations/webpack-loader/src/index.ts[7, 28]: This assertion is unnecessary since it does not change the type of the expression.
    
    Unhandled error:
    Error: Command failed: ./node_modules/.bin/tslint --project ./integrations/webpack-loader
    Alan Pierce
    @alangpierce
    @raylu I think you need to do an initial yarn build so it runs yarn in all of the sub-projects.
    raylu @raylu builds
    raylu
    @raylu
    oh hey that worked
    Alan Pierce
    @alangpierce
    :tada:
    raylu
    @raylu
    status update:
    1. upgrading to mojave uninstalls xcode cli
    2. need to https://istanbul.js.org/docs/tutorials/typescript/
    raylu
    @raylu
    status:
    image.png
    raylu
    @raylu
    I've been wondering why travis won't build my branch
    and I just saw
    # Don't do feature branch builds; we only need one build per PR.
    branches:
      only:
        - "master"
    Alan Pierce
    @alangpierce
    Ah yep, the build is sorta heavy since it builds a bunch of separate projects with sucrase and then runs their tests. Travis is only willing to run a certain number of concurrent builds per user (I think), so it was significantly slowing the tests down to build the same thing twice for each PR.
    @raylu I think you can just get rid of that line as part of your commit to do test builds on non-master branches.
    raylu
    @raylu
    eh, I just pushed it to my master
    why was nyc already installed?
    Alan Pierce
    @alangpierce
    :thumbsup:
    Anyway, cool stuff, thanks!
    ts-node/register and sucrase/register accomplish the same thing (with different compilers), so we probably don't want both enabled when we run mocha.
    raylu
    @raylu
    @alangpierce is it time to press the button? :D
    Alan Pierce
    @alangpierce
    @raylu ooh, I didn't see that you updated it, I guess neither the force-push nor the "mark as resolved" generate a notification. I'll take another look.
    raylu
    @raylu
    I tried debugging coverage by adding --show-process-tree to nyc which locally gives me
    nyc
    └─┬ /usr/bin/node /usr/share/yarn/bin/yarn.js test-only
      │   83.75 % Lines
      └─┬ /usr/bin/node /home/raylu/src/sucrase/node_modules/.bin/mocha ./test/**/*.ts
        │   83.75 % Lines
        └── /usr/bin/node /home/raylu/src/sucrase/node_modules/mocha/bin/_mocha --require sucrase/register --require source-map-support/register ./test/**/*.ts
              83.75 % Lines
    but here it just... interleaved horribly or something? https://travis-ci.org/raylu/sucrase/jobs/451718010
    raylu
    @raylu
    oh interesting. it works with node_modules/.bin/nyc yarn test-only but not with yarn test...
    raylu
    @raylu
    ok, "test": "env -i \"PWD=$PWD\" \"PATH=/bin:/usr/bin\" node_modules/.bin/nyc --show-process-tree yarn test-only", also works...
    and I don't really understand what the issue is
    Alan Pierce
    @alangpierce
    It's also unclear what changed to cause the regression. Thanks for taking a look!
    raylu
    @raylu
    ooh nice
    also good job fixing the example exit codes :D
    Alan Pierce
    @alangpierce
    Haha, yeah, a little embarrassing, ideally there would be a way to make sure it's impossible forget the exit code thing.
    raylu
    @raylu
    Jean Jorge Michel
    @jeanjmichel
    Hi guys

    I'm trying debug my TS Node app, where I compile JS with sucrase.
    But it is not working.
    The VS Code do not stop on the break points.

    Looking for a fix in the web, I find some texts saying I need a sourceMap...

    Using TS libs, it created tsconfig.json, but Sucrase do not created this.

    Some tip that how I can debbug in VS Code?]

    Thanks
    Dmitry Sharshakov
    @sh7dm
    hello
    @alangpierce who designed the website? I want to talk to them about website enhancements I could make
    Dmitry Sharshakov
    @sh7dm
    anybody here?
    Dmitry Sharshakov
    @sh7dm
    Opened PR with website mobile update alangpierce/sucrase#451
    Julian Delerme
    @Delerme

    Hey there, I plan on adding some functionality to the cli.

    • Support passing in a list of files instead of just a root directory. Useful for when only a small set of files should be processed (i.e. a few jsx templates)
    • Process files with the ".jsx" extension when transforms includes "jsx"

    Any concerns with these changes?