Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Nov 18 2020 19:48
    PatrickSachs commented #100
  • Nov 18 2020 19:48
    PatrickSachs commented #100
  • Nov 18 2020 19:48
    PatrickSachs commented #100
  • Nov 18 2020 00:18
    YellowApple commented #100
  • Nov 17 2020 20:58
    PatrickSachs closed #100
  • Nov 17 2020 20:58
    PatrickSachs commented #100
  • Nov 13 2020 06:15
    YellowApple commented #100
  • Jul 18 2020 17:21
    PatrickSachs opened #100
  • Mar 11 2020 08:32
    heinrich-fresh edited #99
  • Mar 11 2020 08:31
    heinrich-fresh edited #99
  • Mar 11 2020 08:30
    heinrich-fresh closed #99
  • Mar 11 2020 08:30
    heinrich-fresh opened #99
  • May 31 2019 19:29
    decasm closed #7
  • May 31 2019 17:51
    decasm closed #98
  • May 31 2019 17:51
    decasm closed #8
  • May 31 2019 17:42
  • May 31 2019 17:39
  • May 31 2019 17:37
    decasm opened #98
  • May 31 2019 17:37
    decasm opened #7
  • May 31 2019 17:37
    decasm opened #8
Anne-Gwenn Kettunen
@Annwenn
\o/
Ryan S. Northrup (RyNo)
@YellowApple
Writing that made me realize that some mechanism for params validation would be useful if one doesn't already exist. I suppose guards could work for simple cases, but I reckon that would get unwieldy in more complex cases.
Anne-Gwenn Kettunen
@Annwenn
that's up the coder's imagination =)
Anne-Gwenn Kettunen
@Annwenn
@YellowApple I found something a bit concerning while reading the docs.
and if I test it with http -j POST "http://localhost:4000/shorten/json" url='http://github.com', I see that there is a params: %{"url" => "http://github.com"} but nothing in the arguments
I must have missed something, but what?
Ryan S. Northrup (RyNo)
@YellowApple
So in total you're getting something like [format: "json", params: %{"url" => "http://github.com"}] in your args?
YellowApple @YellowApple will be the first to admit that he was too lazy to actually pull up one of his projects and verify things...
Anne-Gwenn Kettunen
@Annwenn
I'm just having [json: "json"]
Ryan S. Northrup (RyNo)
@YellowApple
Well that's interesting.
Anne-Gwenn Kettunen
@Annwenn
indeed? :)
Ryan S. Northrup (RyNo)
@YellowApple
So they're being stored in the Plug.Conn itself.
Anne-Gwenn Kettunen
@Annwenn
*isn't it?
_>
Ryan S. Northrup (RyNo)
@YellowApple
But aren't being pulled into args, contrary to what @slogsdon just suggested :)
Shane Logsdon
@slogsdon
it's been a while. it's a definite possibility that i could be wrong
it does use Plug parsers after all
Ryan S. Northrup (RyNo)
@YellowApple
Well at least we know that they're being separated out in the Plug.Conn.
Do we want to go ahead and see if they can be spliced in whenever the path-related args are?
YellowApple @YellowApple is spelunking through the relevant code right now
Shane Logsdon
@slogsdon
yeah, that makes more sense now that i think of it more. the args parameter to a controller action is the result of bindings/0, which pulls out all variables coming about from pattern matching in the path
so if there was /my/:cool/:path
that gets parsed to ["my", cool, path]
so bindings/0 would result in [cool: "value1", path: "value2"] when hitting /my/value1/value2
Anne-Gwenn Kettunen
@Annwenn
@slogsdon but it's not a desperate situation, right? :)
Ryan S. Northrup (RyNo)
@YellowApple
For now, it looks like it they should be accessible as a Map in conn.params, so I'll update the docs accordingly.
Anne-Gwenn Kettunen
@Annwenn
oki doki :)
(god I hate those smileys.)
Ryan S. Northrup (RyNo)
@YellowApple
I know, right?
Anne-Gwenn Kettunen
@Annwenn
ffs…
:(
Shane Logsdon
@slogsdon
%{"url" => url} = conn[:params] should be %{"url" => url} = conn.params
and we can always merge the keyword list of path params into the conn.params map
Anne-Gwenn Kettunen
@Annwenn
facepalm
I didn't the difference until now
*didn't see
Shane Logsdon
@slogsdon
i've done the same thing at times
just the other week i was trying to fix an issue in some javascript. it took me about 3-4 days to realize that the "alleged cause" of it wasn't even the problem. it was just a simple data serialization error that was getting muted
Anne-Gwenn Kettunen
@Annwenn
:'D
Ryan S. Northrup (RyNo)
@YellowApple
Aight, docs are fixed.
I think.
I'm still waiting for Erlang to compile on this machine, so I don't know for sure. :/
Anne-Gwenn Kettunen
@Annwenn
\o/
Shane Logsdon
@slogsdon
@YellowApple is your machine hot enough to cook an egg yet?
Ryan S. Northrup (RyNo)
@YellowApple
Not yet, but it's making for a nice space heater under my desk :)
Anne-Gwenn Kettunen
@Annwenn
hmmmm
okay now that I have to define a .html.eex file, the errors appears again