Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Nov 18 2020 19:48
    PatrickSachs commented #100
  • Nov 18 2020 19:48
    PatrickSachs commented #100
  • Nov 18 2020 19:48
    PatrickSachs commented #100
  • Nov 18 2020 00:18
    YellowApple commented #100
  • Nov 17 2020 20:58
    PatrickSachs closed #100
  • Nov 17 2020 20:58
    PatrickSachs commented #100
  • Nov 13 2020 06:15
    YellowApple commented #100
  • Jul 18 2020 17:21
    PatrickSachs opened #100
  • Mar 11 2020 08:32
    heinrich-fresh edited #99
  • Mar 11 2020 08:31
    heinrich-fresh edited #99
  • Mar 11 2020 08:30
    heinrich-fresh closed #99
  • Mar 11 2020 08:30
    heinrich-fresh opened #99
  • May 31 2019 19:29
    decasm closed #7
  • May 31 2019 17:51
    decasm closed #98
  • May 31 2019 17:51
    decasm closed #8
  • May 31 2019 17:42
  • May 31 2019 17:39
  • May 31 2019 17:37
    decasm opened #98
  • May 31 2019 17:37
    decasm opened #7
  • May 31 2019 17:37
    decasm opened #8
Anne-Gwenn Kettunen
@Annwenn
:(
Shane Logsdon
@slogsdon
%{"url" => url} = conn[:params] should be %{"url" => url} = conn.params
and we can always merge the keyword list of path params into the conn.params map
Anne-Gwenn Kettunen
@Annwenn
facepalm
I didn't the difference until now
*didn't see
Shane Logsdon
@slogsdon
i've done the same thing at times
just the other week i was trying to fix an issue in some javascript. it took me about 3-4 days to realize that the "alleged cause" of it wasn't even the problem. it was just a simple data serialization error that was getting muted
Anne-Gwenn Kettunen
@Annwenn
:'D
Ryan S. Northrup (RyNo)
@YellowApple
Aight, docs are fixed.
I think.
I'm still waiting for Erlang to compile on this machine, so I don't know for sure. :/
Anne-Gwenn Kettunen
@Annwenn
\o/
Shane Logsdon
@slogsdon
@YellowApple is your machine hot enough to cook an egg yet?
Ryan S. Northrup (RyNo)
@YellowApple
Not yet, but it's making for a nice space heater under my desk :)
Anne-Gwenn Kettunen
@Annwenn
hmmmm
okay now that I have to define a .html.eex file, the errors appears again
deps/templates/lib/sugar/templates/engines/eex.ex:13: warning: variable assigns is unused
** (CompileError) deps/templates/lib/sugar/templates/engines/eex.ex:13: cannot define module :"Elixir.Sugar.Templates.CompiledTemplates.EEx.not_found.html.eex" because it is currently being defined in deps/templates/lib/sugar/templates/engines/eex.ex:13
(templates) lib/sugar/templates/engines/eex.ex:20: Sugar.Templates.Engines.EEx.compile/1
(sugar) lib/mix/tasks/compile/sugar.ex:62: anonymous fn/2 in Mix.Tasks.Compile.Sugar.do_compile/1
(elixir) lib/enum.ex:1043: anonymous fn/3 in Enum.map/2
(elixir) lib/enum.ex:1385: Enum."-reduce/3-lists^foldl/2-0-"/3
which is very weird because I don't have it on my previous project using Sugar…
Annwenn @Annwenn randomly pokes @YellowApple and @slogsdon
Shane Logsdon
@slogsdon
that happens randomly because the templates library was shoddily created
it's supposed to create a new module for each template file, but for some reason, it doesn't quite work, causing the collisions you see
Anne-Gwenn Kettunen
@Annwenn
:s
okay
Shane Logsdon
@slogsdon
sorry i don't have a better answer for you
the only real way to fix the warnings and errors is to rewrite it or to use EEx manually
the latter can be a simple, interim solution for you
Anne-Gwenn Kettunen
@Annwenn
that's alright I can consider using EEx =)
Anne-Gwenn Kettunen
@Annwenn
or even using static/2.
Anne-Gwenn Kettunen
@Annwenn
@slogsdon silly question but still: How do I configure Sugar to listen exclusively on ::1/127.0.0.1 ?
Shane Logsdon
@slogsdon
you'll want to pass the :ip option to Cowboy (https://github.com/elixir-lang/plug/blob/master/lib/plug/adapters/cowboy.ex#L7) via the :http/:https Sugar options
Anne-Gwenn Kettunen
@Annwenn
Thank you (: It could be wise to include it in the default configuration in mix sugar.init (I think)
Shane Logsdon
@slogsdon
would that prevent request coming in from an externally accessible network interface? what I wouldn't want to happen is allowing only local connections to access the application
Anne-Gwenn Kettunen
@Annwenn
What I want is Nginx to handle external connections ;)
Shane Logsdon
@slogsdon
i should have added "as a default". i totally see the benefit, but i don't want to add an additional hoop for those that don't want to have their application sitting behind a reverse proxy
i think an option for the sugar.init mix task to allow for this setting to be added automatically would be a nice compromise
Anne-Gwenn Kettunen
@Annwenn
I see :)
Shane Logsdon
@slogsdon
what do you think about that?
Anne-Gwenn Kettunen
@Annwenn
(That's a pity that the Cowboy adapter doesn't support IPv6 tuples…)
Shane Logsdon
@slogsdon
it looks like it can support ipv6 tuples: http://erlang.org/doc/man/inet.html#type-ip_address
that's what is accepted by :gen_tcp, and ranch/cowboy just pass the :ip option on to it
Anne-Gwenn Kettunen
@Annwenn
oh, okay, because line 8 was showing a 4-elements tuple.
Shane Logsdon
@slogsdon
might just be a bit that can be improved in the docs. i would give it a go to see if it works. I traced everything through and didn't see anything that would enforce a 4 element tuple
Anne-Gwenn Kettunen
@Annwenn
:)
thanks
Shane Logsdon
@slogsdon
np!
@Annwenn @YellowApple would you two like push privileges for the hex packages?
Anne-Gwenn Kettunen
@Annwenn
oh my… what a promotion :O
@slogsdon I'd be honoured.
Shane Logsdon
@slogsdon
haha i figured it would be better if it wasn't just me. pm me your email used for your hex account, and i'll add you