by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • May 02 14:55
    matteobortolazzo commented #448
  • May 02 05:40
    bebraw commented #448
  • May 01 21:03
    matteobortolazzo commented #448
  • Feb 02 2019 22:45
    danielhamngren opened #448
  • Nov 18 2018 04:43
    McWatt commented #447
  • Sep 27 2018 18:26
    bebraw commented #447
  • Sep 27 2018 17:45
    jordancclive opened #447
  • Mar 13 2018 16:18
    skarlinski commented #446
  • Mar 13 2018 15:33
    bebraw commented #446
  • Mar 13 2018 15:32

    bebraw on master

    fix(language-features): Drop we… Removed redundant spread operat… Merge pull request #446 from sk… and 2 more (compare)

  • Mar 13 2018 15:32

    bebraw on v2.5.13

    (compare)

  • Mar 13 2018 15:32

    bebraw on dev

    chore: Bump version 2.5.13 (compare)

  • Mar 13 2018 15:29

    bebraw on dev

    Removed redundant spread operat… Merge pull request #446 from sk… (compare)

  • Mar 13 2018 15:29
    bebraw closed #446
  • Mar 12 2018 17:50
    skarlinski opened #446
  • Mar 07 2018 14:47

    bebraw on dev

    fix(language-features): Drop we… (compare)

  • Mar 07 2018 14:46

    bebraw on dev

    chore: Thank @skarlinski chore: Bump version 2.5.12 (compare)

  • Feb 26 2018 08:55
    bebraw commented #445
  • Feb 26 2018 08:54

    bebraw on master

    Changed `const` to `let` in es6… Merge pull request #445 from sk… chore: Thank @skarlinski and 2 more (compare)

  • Feb 26 2018 08:54

    bebraw on v2.5.12

    (compare)

Juho Vepsäläinen
@bebraw
@ANSHUMAN96_gitlab https://www.pesto.tech/contact - there's email and address :)
@asdfkerub could you open a stack overflow question with more detail and context and then link to that?
Juho Vepsäläinen
@bebraw
Viliam Elischer
@vireliam_twitter

Hey guys, I'm looking for some good code review checklist, preferably the one you use at daily basis on CRs, I'd like to compile something and there is a ton of resources of vague quality around the internet.
Thx for any link/idea/feedback.

Sry that's off topic of webpack, but it's good to ask in a place where are smart people ;)

Juho Vepsäläinen
@bebraw
@vireliam_twitter you can push formatting + basic checks to tooling (prettier + eslint for JS mainly) and implement custom checks (eslint rules) for anything app specific to capture conventions. https://survivejs.com/maintenance is my starting point for some of the setups (it needs some updates but most is valid). what kind of reviews are you doing exactly?
PR-size is one thing - the longer the PR, the harder it is to review
so enforcing that can help. with good design, you can also avoid merge conflicts although that's unavoidable sometimes
how many people are you working with?
Viliam Elischer
@vireliam_twitter

@bebraw the team is max 5 ppl now, I was looking for some specific steps. I have my own procedure which isn't formalised yet anywhere. There are several step-by-step guides what to check in CR.

What I'm looking for is a "cheatsheet" :)

Juho Vepsäläinen
@bebraw
@vireliam_twitter i think it's hard to give any specific guidelines. the main benefit is that you get input from different levels of people. i work mainly with one other dev so we review each other's work and just reviewing your own work can be useful. the primary things to look at 1. scope (can the pr be split? sometimes useful) 2. clarity (do the changes make sense) 3. functionality (does it work? is it tested?). you can push some of the 3. category to CI and i suspect the same applies for 2. too (complexity analysis)
i know one company that used to put their devs to review code in the morning before starting other work
they might still do it as it's a good practice
interestingly one of the main points is in keeping the amount of code to review quite small - defects slip in more easily when there's more to review
lightweight code review takes less than 20% the time of formal reviews and finds just as many bugs
so just having a review process in place will help (people are more accountable i think)
Kerub Querubin
@asdfkerub
Whats better isomorphic or splitting client side and api side on their own ec2 instances? How well will SEO work for isomorphic vs splitting? I just discovered isomorphic. And I might need to redo my site just to for the client and api side to work together.
Juho Vepsäläinen
@bebraw
@asdfkerub i've been using next.js for a while now and it seems like they take care of a lot of these kind of concerns for you
my personal favorite is ssr + interactive regions for logic in react
i baked my own solution for that
you get a static site + "widgets" where you need them
the gotcha is that you lose client side routing but apart from that it's :ok:
Viliam Elischer
@vireliam_twitter
:point_up: July 22, 2019 6:09 PM :thumbsup: thank you for the answer! I create a gist and will probably RFC oni it
Juho Vepsäläinen
@bebraw
cool, let me know what you end up with
there are also techniques like pair coding and mobbing that are useful for both training people (shared experience and understanding) and getting work done
Juho Vepsäläinen
@bebraw
Juho Vepsäläinen
@bebraw
brinka
@brinka
hi, @bebraw I have a question regarding partial application (chapter 4.2) in your React book. I am not sure, this is the correct place to ask, but I would be grateful for any input. Why are you using partial application for the onDelete function? Is there particular use case for it? Can it be done in a different way, for example using arrow functions? Thank you for the explanation.
Ryan Stegmann
@rstegg
@brinka it does the same thing. I think at the time of writing, arrow functions were not fully integrated in JavaScript, so it was safer to teach the bind method.
brinka
@brinka
@rstegg thank you!
Ryan Stegmann
@rstegg
There are use cases for the bind function you can look into if you want, but in regards to React, it basically does the same thing as arrow functions
syedsameerali
@syedsameerali
Hello, hope everyone is doing well, I am following the Survive Webpack book online. I noticed thepurifycss-webpack package which is mentioned in the "eliminating unused CSS" section of the book is no longer maintained. I was wondering if this might be an issue, and if so are there any alternative webpack plugins that can help with unused css? Many thanks
Juho Vepsäläinen
@bebraw
i'll have to update the book to that. super busy atm unfortunately
syedsameerali
@syedsameerali
@bebraw Thank you very much for your help, the Survive js series is truly a God send. I have struggled with Webpack for a long time, but after reading Survive Webpack, suddenly it is not intimidating anymore. The structure, pacing and teaching approach makes a complex topic easy to follow. I only wished the other books on programming concepts out there could follow your teaching method as an example. With much thanks and appreciation.
Juho Vepsäläinen
@bebraw
cool, great to hear :+1:
syedsameerali
@syedsameerali
@bebraw Tested purgecss-webpack-plugin with bootstrap and it is working perfectly, thank you!
Ahmed Rebai
@Rebaiahmed
Hi
Juho Vepsäläinen
@bebraw
:+1:
Juho Vepsäläinen
@bebraw
Logan Valentine
@krandom
Anyone else using sublime and getting the highlighting all broken after using </> ???
Juho Vepsäläinen
@bebraw
i've moved on to vs code. there's a period of adaptation for sure but after that you won't want to go back
borlek
@borlek
I'm setting up the first example in the book and running

react-boilerplate@2.5.6 start C:\Users\boris.lekht\kanban-app
webpack-dev-server

http://localhost:8080/
webpack result is served from /
content is served from C:\Users\boris.lekht\kanban-app
404s will fallback to /index.html
Child html-webpack-plugin for "index.html":

webpack: Compiled successfully.

nothing comes up in the browser
Juho Vepsäläinen
@bebraw
resolved through email. i was busy running a conf yesterday :)
Mahesh
@maheshdeploy
How to get emails from my react portfolio to my Gmail inbox.
elinet2010
@elinet2010
how to configure intonation variables other than with ".env"?
Juho Vepsäläinen
@bebraw
what's your use case?