Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 23 13:58
    scala-steward synchronize #134
  • Jan 23 12:19

    cquiroz on master

    Update utest to 0.7.7 Merge pull request #138 from sc… (compare)

  • Jan 23 12:19
    cquiroz closed #138
  • Jan 23 11:41
    scala-steward closed #137
  • Jan 23 11:41
    scala-steward commented #137
  • Jan 23 11:41
    scala-steward opened #138
  • Jan 21 10:26
    scala-steward opened #137
  • Jan 11 23:28

    cquiroz on master

    Update sbt-scalajs, scalajs-com… Merge pull request #136 from sc… (compare)

  • Jan 11 23:28
    cquiroz closed #136
  • Jan 11 22:12
    scala-steward opened #136
  • Dec 24 2020 12:13

    cquiroz on master

    Update sbt to 1.4.6 Merge pull request #135 from sc… (compare)

  • Dec 24 2020 12:13
    cquiroz closed #135
  • Dec 24 2020 11:51
    scala-steward opened #135
  • Dec 20 2020 04:36
    scala-steward closed #128
  • Dec 20 2020 04:36
    scala-steward opened #134
  • Dec 14 2020 12:00

    cquiroz on master

    Update sbt to 1.4.5 Merge pull request #133 from sc… (compare)

  • Dec 14 2020 12:00
    cquiroz closed #133
  • Dec 14 2020 09:57
    scala-steward opened #133
  • Dec 04 2020 20:17

    cquiroz on master

    Update sbt-ci-release to 1.5.5 Merge pull request #132 from sc… (compare)

  • Dec 04 2020 20:17
    cquiroz closed #132
Carlos Quiroz
@cquiroz
thanks
Otto Chrons
@ochrons
fingers crossed! :D
you can access the Actions logs in github, right?
Carlos Quiroz
@cquiroz
yes I do
Carlos Quiroz
@cquiroz
Ok it failed becase the pgp key is not found in the keyservers pool
Sometimes it takes a while to do it
I mean to propagate, but did you post it /
Otto Chrons
@ochrons
I did
Carlos Quiroz
@cquiroz
Then I’ll retry later today
Otto Chrons
@ochrons
:ok_hand:
shadice
@shadice6_twitter
thanks!
Carlos Quiroz
@cquiroz
Still doesn’t work
the error is in promoting the repo, not with PGP key though? Failed: RepositoryWritePolicy, failureMessage:Artifact updating: Repository ='releases:Releases' does not allow updating artifact='/io/suzaku/diode-data_sjs1_2.12/1.1.9/diode-data_sjs1_2.12-1.1.9.pom'
also, I can see Diode 1.1.9 in Maven Central, so it seems to have published just fine at some point
Carlos Quiroz
@cquiroz
Ah ok
Didn’t drill into the logs
So presumably it went through at least once
👏👏
Thanks
Raúl Piaggio
@rpiaggio
thank you for the new release! I see diode and diode-data in maven but not the new diode-react. It was built in the process but it seems it didn't get published because of the error with diode-data I think
Andreas Gabor
@an-tex
wohoo awsm thx!!
yep updated diode-react is missing for me tll
Carlos Quiroz
@cquiroz
Checking the build it seems diode-react sholud have been included btu we had troubles on the last automated release
We may want to do 1.1.10 tag
Vladimir Bodnartchouk
@Fraer
Hello, we like diode so much and the latest ScalaJS too :) could expect a release of diode-react_sjs1_2.13 anytime soon ?
Carlos Quiroz
@cquiroz
I’ll try another release
Carlos Quiroz
@cquiroz
diode-react is not being published yet, the build needs an update
Otto Chrons
@ochrons
I can also release the react version manually
Carlos Quiroz
@cquiroz
It seems the problem is with the custom version number for diodeReact
in that case local publication works but it doesn’t try to upload to sonatype
Carlos Quiroz
@cquiroz
The idea for the version number was to decouple diode from the scalajs-react release cycle
but since it is much easier to release it maybe ok to use the same version everywhere
Otto Chrons
@ochrons
yea, sounds good that way... Diode itself is probably not getting lots of changes, but keeping up with scalajs-react might need more frequent updates
Carlos Quiroz
@cquiroz
Ok, sent a PR removing the version
Carlos Quiroz
@cquiroz
@ochrons could you check my PR to get another release out?
Carlos Quiroz
@cquiroz
@ochrons would it be ok to make a new release including my Last PR?
Otto Chrons
@ochrons
sure, go ahead
I've been offline from Gitter for a couple of weeks :)
Carlos Quiroz
@cquiroz
Ok thanks
Carlos Quiroz
@cquiroz
There is a PR updating scalajs-react. I’ll be making new releases every time this happens, unless there is any objection
Armin Keyvanloo
@arminio
Hi @ochrons, how is things?
Any tips on how to go about unit testing with Diode and sjs-react in the mix? We have followed the design pattern that you provided in the SPA tutorial for the react component to:
  • emit a RefreshData from server action
  • the handler makes an ajax call on case RefreshData => and when results are returned by the server, it dispatches another action (a case class) with the list of data (just like your Todo component in the SPA tutorial)
  • the same handler class handles this event also (the data from server) and the component is now successfully initialised
    The issue that we are facing now is that in the unit tests, we don't know how to wait for these steps to be completed by Diode before we do our assertions.
    Any help would be much appreciated!
Otto Chrons
@ochrons
hey Armin, noticed your ping on Twitter, but I'm not really active working on Diode myself at the moment (too busy CEOing at an e-bike startup :) )
Armin Keyvanloo
@arminio
Ok, no worries @ochrons.
Given that I have had no responses here, what do you suggest I should do if I have questions about Diode?
Otto Chrons
@ochrons
at least @cquiroz is actively working with Diode :)
Armin Keyvanloo
@arminio
Cheers @ochrons
Good luck with your startup venture
Carlos Quiroz
@cquiroz
@arminio I only test individual handlers/messages, basically testing the return value. I’m not sure how could you test several messages in succession
Andreas Gabor
@an-tex
Hi. When I Circuit.connect a react component, the component is always rendered twice. To me the issue seems to lie in ReactConnector.didMount which calls .setState(modelReader()) ( https://github.com/suzaku-io/diode/blob/master/diode-react/src/main/scala/diode/react/ReactConnector.scala#L107 ) unnecessarily as it's already set in .initialState(modelReader()) ( https://github.com/suzaku-io/diode/blob/master/diode-react/src/main/scala/diode/react/ReactConnector.scala#L129 ). Is there another reason to re-set the state?
Jeaye Wilkerson
@jeaye
Seems like some examples use ScalaTags for views and other examples use React. Does Diode perform efficiently with the former, or is React necessary?
Carlos Quiroz
@cquiroz
Diode is independent of react, it only cares about handling state, not what you use as view