Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Oct 06 08:33

    ochrons on master

    Remove componentWillMount as it… dist: trusty for travis.yml Merge pull request #89 from reg… (compare)

  • Oct 06 08:33
    ochrons closed #89
  • Oct 06 08:32

    ochrons on master

    drops scala 2.11 support and ad… add 2.13.0 for travis remove 2.11 for travis and 13 more (compare)

  • Oct 06 08:32
    ochrons closed #87
  • Sep 24 11:22
    erinmez commented #87
  • Sep 23 09:06
    registrs synchronize #89
  • Sep 23 08:50
    registrs opened #89
  • Sep 23 08:49
    registrs closed #88
  • Sep 23 08:27
    registrs opened #88
  • Jul 11 13:54
    russwyte edited #87
  • Jul 11 13:52
    russwyte synchronize #87
  • Jul 11 13:49
    russwyte synchronize #87
  • Jul 11 13:38
    russwyte synchronize #87
  • Jul 11 13:34
    russwyte synchronize #87
  • Jul 11 13:00
    russwyte synchronize #87
  • Jul 10 23:59
    russwyte synchronize #87
  • Jul 10 23:57
    russwyte synchronize #87
  • Jul 10 19:59
    russwyte synchronize #87
  • Jul 10 19:50
    russwyte synchronize #87
  • Jul 10 18:35
    russwyte synchronize #87
Russ White
@russwyte
it will work fine - but you will get a lot of deprecation warnings if you use those heavily in tests :)
Carlos Quiroz
@cquiroz
thanks for the heads up. I have fatal-warnings setup everywhere
Russ White
@russwyte
glad to help
Russ White
@russwyte
there are some deprecation warnings I am just not sure how to get around right now
like this one:
[warn] /Users/rwhite/projects/diode/diode-core/shared/src/test/scala/diode/util/RetryTests.scala:32:9: method right in class Either is deprecated (since 2.13.0): Either is now right-biased, use methods directly on Either [warn] r.right.get._2.toFuture.flatMap { n =>
and this one:
[warn] /Users/rwhite/projects/diode/diode-core/shared/src/main/scala/diode/Effect.scala:150:51: type CanBuildFrom in package generic is deprecated (since 2.13.0): Use scala.collection.BuildFrom instead [warn] Future.traverse(tail + head)(f(_))(implicitly[CanBuildFrom[Set[Effect], A, Set[A]]], ec) [warn] ^
I can’t really fix those for 2.13 without breaking 2.12 - unless I resort to changing the impl
Russ White
@russwyte
I think in those cases we should just live with the warnings or maybe provide seperate impls?
Russ White
@russwyte
We could add something like this to the build:
unmanagedSourceDirectories in Compile += {
  val sourceDir = (sourceDirectory in Compile).value
  CrossVersion.partialVersion(scalaVersion.value) match {
    case Some((2, n)) if n >= 13 => sourceDir / "scala-2.13+"
    case _ => sourceDir / "scala-2.12-"
  }
}
Otto Chrons
@ochrons
separate impls is fine, same as in Boopickle
it also uses CBF, which needs to be done differently in 2.13
Russ White
@russwyte
awesome! I am trying to do that right now - but I am bumping my head against cross-project
it does not seem honor the 2.13 directory in the share part of of the js cross-project
I will look how you did it in Bookpickle
Otto Chrons
@ochrons
I didn't do it, but some other helpful contributor did :wink:
Russ White
@russwyte
:smiley:
Otto Chrons
@ochrons
frankly, I haven't even had the time/energy to look into 2.13 properly due to having so many other things going ATM :smile:
Russ White
@russwyte
This has been fun for me - so I don’t mind
Russ White
@russwyte
@ochrons Ok I managed to tackle all of the warnings - it seems we have a good clean sbt clean +test cycle
Carlos Quiroz
@cquiroz
How are you going to do the scalajs-react dependency? That is not in 2.13 yet
Russ White
@russwyte
It is simply not available for 2.13 only the core and data subprojects are. When that library is ready we can add it.
The crossversions for that subproject only includes 2.12.8
People who don't need that integration will be able to use diode on 2.13 without missing it.
Russ White
@russwyte
@ochrons I think my PR is good to go - let me know if you agree - or if I should make more changes.
Otto Chrons
@ochrons
ok, I'll take a closer look later, currently on vacation in London :)
Russ White
@russwyte
Thanks! No rush - enjoy your vacation! :airplane: :palm_tree:
Russ White
@russwyte
@ochrons just checking in. Any feedback?
Otto Chrons
@ochrons
ah, forgot about it :sweat_smile: too busy vacation this year :wink:
Russ White
@russwyte
I understand! :smile:
You might enjoy seeing why I am so interested:
I will probably pull that out into it’s own subproject - but it’s there for now.
Russ White
@russwyte
@ochrons hoping you have some time to review soon.
Russ White
@russwyte
@ochrons are you open to crossbuild support for SJS 1.x?
I need to move to 1.x and I am trying to avoid forking if I don’t have to! :)
Otto Chrons
@ochrons
sure thing, sorry for not been able to react on these things, we have a big event coming next week for my startup :sweat_smile:
Russ White
@russwyte
Totally understand!
Russ White
@russwyte
If I get some time to work on it - would it be ok to add to this PR - or would you prefer to handle it seperately later.
Otto Chrons
@ochrons
you can put in the same PR, no problem
Otto Chrons
@ochrons
btw, if you're interested what keeps me busy, check out https://revonte.com :wink:
Russ White
@russwyte
Wow! That is very cool!
Ramnivas Laddad
@ramnivas
Wow!
Artsiom Miklushou
@mikla
Please, have a look this PR suzaku-io/diode#89
Henry Ong
@1mdc
Hi, I'm new here and I really love architecture of diode. how is diode performance? is there any benchmark out there? Given using immutable state, it seems it may need to rewrite the whole html every state change, does it affect much performance?
Vitaly Lavrov
@lavrov

README says

Add following dependency declaration to your Scala project.

"io.suzaku" %% "diode" % "1.1.6"

but this version does seem to be published

Otto Chrons
@ochrons
hm, yeah, some merges were done that update the version, but it has not yet been published
Vitaly Lavrov
@lavrov
Looking forward to the next release :)