These are chat archives for svandecappelle/jQPlot

14th
Aug 2015
Vandecappelle
@svandecappelle
Aug 14 2015 07:41
@johanbove your pull request #54 on src/plugins/axis/jqplot.canvasAxisTickRenderer.js: code formatting show me jslint errors on unexpected character spaces Did you well formatted the file (and others on the pull request) ?
sry... saw the modified code. You just format a small part not jslint errors ;)
@RubenOlsen I think: On each plugin after resolving jslint, write a jsdoc is a good procedure.
Ruben Olsen Lærk
@RubenOlsen
Aug 14 2015 08:19

We should need a QA step during the build where we some automatic checking of the quality of JSDoc. Maybe we could use some kind of JS Static Code analysis which will report on how good our JSDoc is? Maybe JSLint can do this?

I'm not very well versed in static code analysis for JavaScript - I have manged quite a number of such analysis for Java teams using Checkstyle/FindBugs/PMD/Squale with SonarQube. Ideally we should have something that could report to SonarCube, or equivalent, to get some trending of quality going :-)

Johan Bové
@johanbove
Aug 14 2015 08:24
Thanks for PR merge. @svandecappelle
About QA step: we do have Travis-CI which can be used for QA testing, but currently it is not actually not doing much.
Travis is not executing any tests at this time. :smirk:
Ruben Olsen Lærk
@RubenOlsen
Aug 14 2015 08:27
Ok. We'll postpone this :-)
Vandecappelle
@svandecappelle
Aug 14 2015 08:27
yeah we need to create automated tests checking into travis
it currently only check the build minimized files success
Johan Bové
@johanbove
Aug 14 2015 08:28
I am running the mocha tests "manually": QPlot/test/view.html
Ruben Olsen Lærk
@RubenOlsen
Aug 14 2015 08:28
Travis CI is new for me - I only have experience with using and managing Apache Continuum (4+ years), TeamCity (3+ years) and Bamboo (6+ years)
Vandecappelle
@svandecappelle
Aug 14 2015 08:29
I don't know how to test User interface into travis. Is it work well with mocha and chai test library?
Johan Bové
@johanbove
Aug 14 2015 08:31
Honestly, I don't have any real experience with Travis-CI; But what I do know is to test an application like jQPlot we'll need phantomjs
Vandecappelle
@svandecappelle
Aug 14 2015 08:32
same for me.
Johan Bové
@johanbove
Aug 14 2015 08:33
Don't like the "coffee" script this project is using - I'm old-skool - but this is the idea: we need to run a "head-less" browser on Travis-CI to execute our tests.
Ruben Olsen Lærk
@RubenOlsen
Aug 14 2015 08:34
Phantomjs is very good (I use it quite a lot), but might be painfull to set up. Also, we need to check if PJS kan run on Travis-CI as this is a hosted platform (it's possible to execute arbitrary code under PJS - which may mess up the Travis platform.
@johanbove you can use plain old JS with PhanthomJS.
Johan Bové
@johanbove
Aug 14 2015 08:35
I see.
Well, best resource article I could find on the topic is this: https://medium.com/@_jh3y/getting-started-with-mocha-bfa20d403186
Ruben Olsen Lærk
@RubenOlsen
Aug 14 2015 08:36
(doing a quick read)
Johan Bové
@johanbove
Aug 14 2015 08:37
It's not the best written article, but at least it looks more complete than any other Google was giving me. Lots of half-baked information out there.
Ruben Olsen Lærk
@RubenOlsen
Aug 14 2015 08:37
so mocha is a functional testing framework?
Vandecappelle
@svandecappelle
Aug 14 2015 08:39
I think it is. Like I saw, lots of open-source projects use it.
Johan Bové
@johanbove
Aug 14 2015 08:39
It's a test framework
Ruben Olsen Lærk
@RubenOlsen
Aug 14 2015 08:39
Travis CI is solving automatick headless browser tesing by relying on Suace Labs - which is a good choice (http://docs.travis-ci.com/user/gui-and-headless-browsers/)
Johan Bové
@johanbove
Aug 14 2015 08:39
I can run mocha test/core/test.js -u tdd from my command line, but the mocha fails because of the $dependency of our code. We would have to load in jQuery, or mock it for the tests to succeed but I'm not sure how to do this.
Johan Bové
@johanbove
Aug 14 2015 08:45
I think this is going to be a weekend project :smile:
Out of curiosity: what OS are you guys using? I'm on Windows (10) myself.
Vandecappelle
@svandecappelle
Aug 14 2015 08:47
Linux distrib ;)
Johan Bové
@johanbove
Aug 14 2015 08:47
Oh cool, Ubuntu?
Vandecappelle
@svandecappelle
Aug 14 2015 08:48
@RubenOlsen I'm currently writing jsdoc for text plugin. We could make a generation test today. :smile:
Archlinux fork and BodhiLinux
Cause I am a g33k open-source purist.
Ruben Olsen Lærk
@RubenOlsen
Aug 14 2015 08:49
OSX on my desktop, Linux on my servers, anything out in the client land (where anything is Linux (Ubuntu/CentOS/RedHat), FreeBSD, OpenBSD, Solaris, AIX, Windows (but I try to avoid that))
Johan Bové
@johanbove
Aug 14 2015 08:49
Nice mix of operating systems we have here :smirk:
Vandecappelle
@svandecappelle
Aug 14 2015 08:50
I have on FreeBSD (but I didn't work on it (A very old machine))
Ruben Olsen Lærk
@RubenOlsen
Aug 14 2015 08:50
yeah :-) - as DevOps is one, of serveral, big parts of my daily work I tend to get exposed to a lot of different stuff. Personally I like OSX, Ubuntu and Solaris.
Vandecappelle
@svandecappelle
Aug 14 2015 09:33
@RubenOlsen check the svandecappelle/jQPlot@fcaf1d5 commit. And try a jsDoc generation. And give me your feedback. Is it the right way you recommend ?
Ruben Olsen Lærk
@RubenOlsen
Aug 14 2015 12:09
@svandecappelle AFAIK this looks really nice. I'll only know when we have done a JSDoc generation test... I'll try to do this during the weekend (however, I'm on vacation from sunday - and wife is not too happy with me hacking away in the evenings while on vacation ;-) - so I might be a bit slow in communcation the next two weeks)
Vandecappelle
@svandecappelle
Aug 14 2015 12:20
@RubenOlsen no problem all of us have a social life behind the coding life.
Ruben Olsen Lærk
@RubenOlsen
Aug 14 2015 13:07
Check out a screencap on the JSDoc genreation on https://db.tt/TRJh1CPy
Vandecappelle
@svandecappelle
Aug 14 2015 13:08
It seems not bad ;)
I will search for create a script for auto generated doc (maybe using grunt, if possible)
Ruben Olsen Lærk
@RubenOlsen
Aug 14 2015 13:37
jsdoc -r src -c conf.json is all that is needed to create the API documentation.
however - this must be done from within the gh-pages branch (which makes stuff a bit more interessting - but I have a plan for that also)
Vandecappelle
@svandecappelle
Aug 14 2015 14:32
After these jslint point and jsdocs points. We should create a release Tag and add it into the gh-pages. (we could then generate the jsdoc for all sources)
Paul Pritchard
@ppritcha
Aug 14 2015 14:48
Hi guys. I invited you all to the jqPlot team and project, and I'm looking for your feedback on the roadmap discussion on the jqplot-dev forum. Meanwhile, can you get me up to speed on what changes you've made?
Ruben Olsen Lærk
@RubenOlsen
Aug 14 2015 15:07
I have done a lot on the gh-pages.
and continue working on that.
next up is converting the current examples into jekyll (not a very big job)
Check out current the last version at http://svandecappelle.github.io/jQPlot/
(it's a start :)
Vandecappelle
@svandecappelle
Aug 14 2015 15:08
And a lot on sources: gruntfile build system. Refactoring. JsLint. Merge original pull requests (see https://github.com/svandecappelle/jQPlot/wiki/Pull-request-merged-from-bitbucket-original-project).
Also unit tests, new site, new doc and new demo site
Paul Pritchard
@ppritcha
Aug 14 2015 15:15
what refactoring have you done? What were the goals of the refactoring?
Vandecappelle
@svandecappelle
Aug 14 2015 15:17
To make packages (separate sources core and each plugins)
Paul Pritchard
@ppritcha
Aug 14 2015 15:17
ok
Vandecappelle
@svandecappelle
Aug 14 2015 15:18
I think a merge on your repository will be very complexe because of the high number of structural modification
Paul Pritchard
@ppritcha
Aug 14 2015 15:19
is the current version "releaseable" in the sense that all of the existing functionality still works the same way, all of the examples work, no breaking changes to the API? So if people replace their current version it will work properly?
Vandecappelle
@svandecappelle
Aug 14 2015 15:20
I think so. But cause of there is no unit tests on the original jqplot project and there is not yet a lot on the new one. I can be 100% affirmative.
I can't be % affirmative*
Paul Pritchard
@ppritcha
Aug 14 2015 15:20
right, understood
Vandecappelle
@svandecappelle
Aug 14 2015 15:21
You can currently chekout the last demo build here: http://svandecappelle.github.io/jQPlot/demo/index.html
Paul Pritchard
@ppritcha
Aug 14 2015 15:22
It would help if the examples pages were there since they are the best test of all of the functionality
Vandecappelle
@svandecappelle
Aug 14 2015 15:23
Ruben works on the automated re-integration of all old exemples of the jqplot site.
Paul Pritchard
@ppritcha
Aug 14 2015 15:24
is he working on the examples from the old site (which are out of date), or the examples from the repository? Best to be working from the repository
Vandecappelle
@svandecappelle
Aug 14 2015 15:25
Don't know, we should tell him that the old site is out of date. <-- if you saw that: @RubenOlsen
Paul Pritchard
@ppritcha
Aug 14 2015 15:26
regarding merging changes to the jqPlot repository -- do you think it's possible at all? It's better to have a continuation of the project, with all of the history of changes there.
Ruben Olsen Lærk
@RubenOlsen
Aug 14 2015 15:27
I'm not 100% decided. I'm thinking of using the examples as a starting point and then amend those.
Paul Pritchard
@ppritcha
Aug 14 2015 15:27
Ruben, which examples are you using? The ones from the web site (out of date), or the newer ones from the repo?
Ruben Olsen Lærk
@RubenOlsen
Aug 14 2015 15:28
Repository (sorry about short sentence - on mobile )
Paul Pritchard
@ppritcha
Aug 14 2015 15:28
excellent, ok