These are chat archives for symengine/symengine

3rd
Mar 2015
Ondřej Čertík
@certik
Mar 03 2015 05:28
@shivamvats great!
@swachhandl excellent! There is plenty of work on the polynomial module. See my notes above --- just porting from SymPy is not enough, we need to nail the speed, so that it is as fast as other codes like Piranha.
Ondřej Čertík
@certik
Mar 03 2015 16:09
@isuruf can you explain what you are asking for by "Any ideas on what the options should be when testing for shared libs?"?
Isuru Fernando
@isuruf
Mar 03 2015 16:10
in the tests in .travis.yml, what type of cmake options to use for testing with build_share_libs
Ondřej Čertík
@certik
Mar 03 2015 16:11
Ah I see. I think the current way in the PR is fine, isn't it?
Isuru Fernando
@isuruf
Mar 03 2015 16:11
yeah
Sumith Kulal
@Sumith1896
Mar 03 2015 16:30
Guys, are there any new issues to work on?
Isuru Fernando
@isuruf
Mar 03 2015 16:33
@Sumith1896, you could take a look at https://github.com/sympy/csympy/blob/master/src/add.cpp#L120
Sumith Kulal
@Sumith1896
Mar 03 2015 16:34
Thanks!
Shivam Vats
@shivamvats
Mar 03 2015 18:15

@certik I have written a very basic implementation of Polynomial class here https://github.com/shivamvats/csympy/tree/poly_initial. It just has a constructor as of now. Figuring out the Visitor pattern took some time :)

I've derived Polynomial from Basic. I was wondering if there is a better inheritance structure (writing polynomial as an independent class, for example).

Ondřej Čertík
@certik
Mar 03 2015 18:19
Right, that's why we implemented the single dispatch, we are keeping the visitor pattern alive due to performance for some people (for me visitor is slower, for @isuruf it is faster)
I think it's fine to derive from Basic, so that it can be used in expressions.
Thanks for the effort, you can send a PR, add [WIP] and we can discuss the code there.
Shivam Vats
@shivamvats
Mar 03 2015 18:20
Yeah sure.
So, will we continue with visitor for poly?
Ondřej Čertík
@certik
Mar 03 2015 19:40
I don't think that poly needs any single dispatch at all, does it?