These are chat archives for symengine/symengine

21st
May 2015
Sumith Kulal
@Sumith1896
May 21 2015 16:16
@certik Continuing the previous discussion, is there a necessity to change
RCP<const Basic> z = rcp(new Symbol("z"));
to
RCP<const Basic> z = symbol("z");
in other occurrences, or will this still do?
Ondřej Čertík
@certik
May 21 2015 16:18
Both are valid, but we should change it.
Isuru Fernando
@isuruf
May 21 2015 16:18
@Sumith1896, we should definitely change those. There are 87 occurrences and one which should be kept as it is
Ondřej Čertík
@certik
May 21 2015 16:18
As I said, the less we use new and rcp directly, the better.
Sumith Kulal
@Sumith1896
May 21 2015 16:18
Okay I'll do that
Ondřej Čertík
@certik
May 21 2015 16:19
Thanks, that would be very useful.
Sumith Kulal
@Sumith1896
May 21 2015 16:19
Is there any similar method/changes for Integer etc?
Ondřej Čertík
@certik
May 21 2015 16:20
yes, integer should be used instead
Sumith Kulal
@Sumith1896
May 21 2015 16:20
Okay
Ondřej Čertík
@certik
May 21 2015 16:22
However, for things like Mul, we cannot just use mul, because the mul method is slow, it does all kinds of checks and simplifications, while rcp(new Mul(coef, dict)) is fast and we want to use it when you know the coef and dict are in canonical form.
This is mostly used internally anyway.
Sumith Kulal
@Sumith1896
May 21 2015 16:32
Also could anybody have a second check sympy/symengine#438, I ran the patch in a separate file for various cases, seems to pass.
Ondřej Čertík
@certik
May 21 2015 16:47
Let me have a look
Ondřej Čertík
@certik
May 21 2015 23:27
I didn't get to it today, I'll try tonight or tomorrow, sorry about that.