These are chat archives for symengine/symengine

20th
Jul 2015
Sumith Kulal
@Sumith1896
Jul 20 2015 02:09
Sumith Kulal
@Sumith1896
Jul 20 2015 12:05
I am writing tests for Polynomial printing, I keep hitting this error
/home/sumith/github/csympy/symengine/tests/basic/test_polynomial.cpp:222:49: error: cannot bind ‘SymEngine::hash_set {aka piranha::hash_set<SymEngine::m_pair, SymEngine::pair_hash, SymEngine::pair_eq>}’ lvalue to ‘SymEngine::hash_set&& {aka piranha::hash_set<SymEngine::m_pair, SymEngine::pair_hash, SymEngine::pair_eq>&&}’
     RCP<const Polynomial> P = polynomial(vars, s);
Shivam Vats
@shivamvats
Jul 20 2015 12:06
@Sumith1896 Did you manage to resolve the compile time errors?
Sumith Kulal
@Sumith1896
Jul 20 2015 12:08
I think there is some problem with the constructors, once I resolve that then doing create methods would be better.
The compile time errors were due to create
Any help here @shivamvats
I followed the lines of UnivariatePolynomial, only difference that being a std::map we have hash_set here
Shivam Vats
@shivamvats
Jul 20 2015 12:10
Removing the && seemed to have helped a bit.
Does it work after removing create?
Sumith Kulal
@Sumith1896
Jul 20 2015 12:12
After removing create, the only error that pops is calling the constructor
No compile time errors
Shivam Vats
@shivamvats
Jul 20 2015 12:12
Ok
I'll let you know if there is any progress.
Sumith Kulal
@Sumith1896
Jul 20 2015 12:13
Did it work for you after removing &&?
For me, it still doesn't
Shivam Vats
@shivamvats
Jul 20 2015 12:13
It didn't. But the error message was more readable
Shivam Vats
@shivamvats
Jul 20 2015 12:14
Yes
This is mostly caused due to undefined virtual methods.
Sumith Kulal
@Sumith1896
Jul 20 2015 12:15
Yes, I'll investigate
Sumith Kulal
@Sumith1896
Jul 20 2015 12:23
There are only two virtual methods, isn't it?
get_args and accept
Shivam Vats
@shivamvats
Jul 20 2015 12:39
__hash__, __eq__ , compare also
Sumith Kulal
@Sumith1896
Jul 20 2015 12:39
Okay, let me write them then, for hash_set they are ready anyways
Shivam Vats
@shivamvats
Jul 20 2015 12:56
@Sumith1896 It is compiling now
Sumith Kulal
@Sumith1896
Jul 20 2015 13:00
Sorry, didn't have notifications turned on :smile:
Did you write __hash__, __eq__, compare?
Shivam Vats
@shivamvats
Jul 20 2015 13:02
Yes. Just to make it compile. I'll push it in a minute. You can modify them, then.
Sumith Kulal
@Sumith1896
Jul 20 2015 13:02
Cool, you can push to my branch
Do you need write access?
Or better, send in a PR
Shivam Vats
@shivamvats
Jul 20 2015 13:03
Cool
Sumith Kulal
@Sumith1896
Jul 20 2015 13:37
@shivamvats What happened?
I wrote __hash__, __eq__, compare
It prints finally
Shivam Vats
@shivamvats
Jul 20 2015 13:40
I was merging with master
Your pr has merge conflicts
Sumith Kulal
@Sumith1896
Jul 20 2015 13:41
Oh yes that takes time :smile:
Send in a PR anyways, I'll add my changes on top of that
Shivam Vats
@shivamvats
Jul 20 2015 13:41
Cool
Shivam Vats
@shivamvats
Jul 20 2015 13:47
@Sumith1896 I've sent a PR.
Sumith Kulal
@Sumith1896
Jul 20 2015 14:27
@shivamvats Thanks for the help
I'll get back to you in some time
Shivam Vats
@shivamvats
Jul 20 2015 14:30
I have left some comments on my and your PRs.
Sumith Kulal
@Sumith1896
Jul 20 2015 14:31
Yes, will get back to you
Ondřej Čertík
@certik
Jul 20 2015 19:49
@bluescarni can you expand (x**y + y**z + z**x)**100 using Piranha, and if so, how would you do that?
Ondřej Čertík
@certik
Jul 20 2015 19:57
@abinashmeher999 let me know if you need any help with the Ruby wrappers. I saw you updated #487. I think this is the last major improvement, then we can start having expressions in Ruby and we should ask people to try it out.
@shivamvats sorry about not having time to meet with you. If you want, we can do it now.
Or later tonight.
(Mountain time, so that would be your morning)
Abinash Meher
@abinashmeher999
Jul 20 2015 21:04
@certik Sure! I am trying to finish these as soon as possible so that we can move to other classes too.
And also I will update the notebooks, then it will be easier for others to try it out.
Ondřej Čertík
@certik
Jul 20 2015 21:35
Perfect. Keep me updated.
Ondřej Čertík
@certik
Jul 20 2015 23:02
@Sumith1896 if you had time, I would love to know one benchmark: if you change mpz_class for piranha::integer (I think it should be possible to just change it), how long do our benchmarks (e.g. expand2) run before and after on your machine?