These are chat archives for symengine/symengine

20th
Oct 2015
Sumith Kulal
@Sumith1896
Oct 20 2015 10:29
Hi
I wanted to what is the purpose .py.in files in general use cases?
Sumith Kulal
@Sumith1896
Oct 20 2015 13:44
*know
Isuru Fernando
@isuruf
Oct 20 2015 13:50
@Sumith1896, you can generate version.py in different ways.
  1. Code the content in python file like you did, fill in the appropriate values and write it
  2. Read the content from version.py.in, fill in the appropriate values and write to version.py
Sumith Kulal
@Sumith1896
Oct 20 2015 13:52
So in our case version.py.in is not needed, is it?
Isuru Fernando
@isuruf
Oct 20 2015 13:53
No, but I think 2. is a better approach. We use 2 in other places like symengine_config.h.in
Sumith Kulal
@Sumith1896
Oct 20 2015 13:56
Yes, I recollect
I'll look into that
But why does NumPy have version.py.in, I can't find where they are using it
Isuru Fernando
@isuruf
Oct 20 2015 13:59
That's a file left over from using approach 2. They are now using approach 1.
Sumith Kulal
@Sumith1896
Oct 20 2015 13:59
Oh okay, cool
Thank you @isuruf
Isuru Fernando
@isuruf
Oct 20 2015 14:00
Np
In approach 1, a release has a version.py and git version has no file.
In approach 2, a release has a version.py and git version has version.py.in. This avoids confusion
Isuru Fernando
@isuruf
Oct 20 2015 14:21
@certik, Looking at #395 which approach do you think is better?
  1. Calling make install from setup.py
  2. Current method
Sumith Kulal
@Sumith1896
Oct 20 2015 14:22
Also @isuruf , this issue is taken care of I think symengine/symengine#93
Isuru Fernando
@isuruf
Oct 20 2015 16:20
@Sumith1896, I think we should add cython to setup.py as a setup_requires before closing it
something like cython>=0.19.1
Sumith Kulal
@Sumith1896
Oct 20 2015 16:29
Yes, agreed. I noticed mpmath in SymPy's setup.py
Ondřej Čertík
@certik
Oct 20 2015 17:51
@isuruf as I just commented, I think it's better to call make install from setup.py.