These are chat archives for symengine/symengine

15th
Jan 2016
Ralf Stephan
@rwst
Jan 15 2016 06:55
@isuruf I will now remove the old expansion code. I'll keep the series and series_invfunc global functions but will change the return type to umap_int_basic. The functions will have calls to the Piranha implementations at the moment. What do you think?
Isuru Fernando
@isuruf
Jan 15 2016 06:58
Having series return a UPSeriesPiranha would enable the user to perform operations on it right
Maybe we can have a AbstractSeries class which UPSeriesPiranha inherits from and has methods like as_basic as_dict get_coef
Ralf Stephan
@rwst
Jan 15 2016 07:00
It's about the interface to the Py,Ruby etc interfaces. Don't you need something that is always convertible?
Isuru Fernando
@isuruf
Jan 15 2016 07:02
I'm not sure I understand
Ralf Stephan
@rwst
Jan 15 2016 07:04
Never mind. I'm still not fully into the whole system. Another thing: Do we want to have that old UnivariateSeries code in symengine? If so, I would take it out of series.* and into another file.
Ralf Stephan
@rwst
Jan 15 2016 07:49
Pardon me but type_codes.inc not including the types it needs is a real PITA. Where should the include go for new types?
Isuru Fernando
@isuruf
Jan 15 2016 07:51
Hmm, can you explain a bit?
Ralf Stephan
@rwst
Jan 15 2016 07:56
Starting from symengine/symengine#759 (which has duplicate code in series.h which is now in series_generic.h I wanted to remove what is no longer needed in series.h. This causes UnivariateSeries to become unknown in types_codes.inc. Where would I put the #include <symengine/series_generic.h> to resolve the error?
And in general, where to put includes for any new type.
I mean I would include it with type_codes.incbut that doesn't seem to be wanted.
Isuru Fernando
@isuruf
Jan 15 2016 08:23
Ah. you have to include in visitor.h
Ralf Stephan
@rwst
Jan 15 2016 08:35
Ah got it. I DID include in visitor.h but forgot to change the #ifndef to #ifndef SYMENGINE_SERIES_GENERIC_H.
Ralf Stephan
@rwst
Jan 15 2016 16:13
@isuruf I will just let SeriesBase inherit from an abstract base having these members (as_dict etc).
Isuru Fernando
@isuruf
Jan 15 2016 16:14
+1