These are chat archives for symengine/symengine

6th
Feb 2016
Akash Trehan
@CodeMaxx
Feb 06 2016 06:59
@isuruf What does expand_as_exp function do here
Isuru Fernando
@isuruf
Feb 06 2016 07:00
It writes Tanh function as exponentials
Akash Trehan
@CodeMaxx
Feb 06 2016 07:01
oh...cool ... also check does is_exact() do on Basic exp?
Isuru Fernando
@isuruf
Feb 06 2016 07:02
I didn't get you
Akash Trehan
@CodeMaxx
Feb 06 2016 07:03
Isuru Fernando
@isuruf
Feb 06 2016 07:04
See Number::is_exact it's true for Integer, Rational and Complex but false for RealDouble, ComplexDouble
Akash Trehan
@CodeMaxx
Feb 06 2016 07:05
Got it... thanx
Ralf Stephan
@rwst
Feb 06 2016 07:26
@isuruf Will you submit the SymPy patch?
Isuru Fernando
@isuruf
Feb 06 2016 07:27
Just wanted to check that you get the same speedup
Ralf Stephan
@rwst
Feb 06 2016 07:31
Confirm! (4.7s-->3.3s)
Isuru Fernando
@isuruf
Feb 06 2016 07:32
Great
Ralf Stephan
@rwst
Feb 06 2016 07:36
That should speed up SymPy as a whole.
Ralf Stephan
@rwst
Feb 06 2016 08:41
And with symengine/symengine#791 we're down to 2.8s.
With symengine taking only 0.1s of that.
Akash Trehan
@CodeMaxx
Feb 06 2016 09:44
@isuruf Can you review #792
Isuru Fernando
@isuruf
Feb 06 2016 09:47
Can you add the derivatives as well?
Sumith Kulal
@Sumith1896
Feb 06 2016 09:47
And tests of course :)
Isuru Fernando
@isuruf
Feb 06 2016 09:47
printing as well
Akash Trehan
@CodeMaxx
Feb 06 2016 09:48
@Sumith1896 I'll add the tests. The PR is not yet complete
@isuruf derivatives for all the trigonometric functions?
Isuru Fernando
@isuruf
Feb 06 2016 09:49
Just for the functions you added. Others are there
Akash Trehan
@CodeMaxx
Feb 06 2016 09:50
Yeah I surely will
and printing too
Akash Trehan
@CodeMaxx
Feb 06 2016 10:56
are there any tests for complex_mpc.cpp ?
Akash Trehan
@CodeMaxx
Feb 06 2016 12:11
How do I find modulus of a Basic argument ? I need to write the derivative of acsch
currently I am using sqrt(pow(self.get_arg(),2))
Isuru Fernando
@isuruf
Feb 06 2016 13:08
Use abs
Akash Trehan
@CodeMaxx
Feb 06 2016 13:14
changed to abs
what is the link for?
Akash Trehan
@CodeMaxx
Feb 06 2016 13:20
oh..cool
Isuru Fernando
@isuruf
Feb 06 2016 13:35
@CodeMaxx, I left a few comments
Akash Trehan
@CodeMaxx
Feb 06 2016 18:16
@isuruf Why in derivative.cpp the derivative is returned after multiplying with self.get_arg()->diff(x) ?
Isuru Fernando
@isuruf
Feb 06 2016 18:23
Where?
Isuru Fernando
@isuruf
Feb 06 2016 18:24
Ah. what is the derivative of sin(x^2) w.r.t x?
Akash Trehan
@CodeMaxx
Feb 06 2016 18:25
cos(x^2)*2*x
Isuru Fernando
@isuruf
Feb 06 2016 18:26
That's the reason to multiply by the derivative of the arg
Akash Trehan
@CodeMaxx
Feb 06 2016 18:27
oh got it.
Was thinking with respect to the argument itself
I made the changes according to your comments
Isuru Fernando
@isuruf
Feb 06 2016 18:31
@CodeMaxx, did you compile the code locally?
Akash Trehan
@CodeMaxx
Feb 06 2016 18:31
I just did... I am fixing the errors
Sorry didn't compile it before upload
I'll fix it asap
Isuru Fernando
@isuruf
Feb 06 2016 18:34
No problem. let me know when it's ready to review
Akash Trehan
@CodeMaxx
Feb 06 2016 18:34
yeah, will do
Akash Trehan
@CodeMaxx
Feb 06 2016 22:41
@rwst is -DWITH_ARB=yes by default ?