These are chat archives for symengine/symengine

6th
Feb 2016
Akash Trehan
@CodeMaxx
Feb 06 2016 06:59 UTC
@isuruf What does expand_as_exp function do here
Isuru Fernando
@isuruf
Feb 06 2016 07:00 UTC
It writes Tanh function as exponentials
Akash Trehan
@CodeMaxx
Feb 06 2016 07:01 UTC
oh...cool ... also check does is_exact() do on Basic exp?
Isuru Fernando
@isuruf
Feb 06 2016 07:02 UTC
I didn't get you
Akash Trehan
@CodeMaxx
Feb 06 2016 07:03 UTC
Isuru Fernando
@isuruf
Feb 06 2016 07:04 UTC
See Number::is_exact it's true for Integer, Rational and Complex but false for RealDouble, ComplexDouble
Akash Trehan
@CodeMaxx
Feb 06 2016 07:05 UTC
Got it... thanx
Ralf Stephan
@rwst
Feb 06 2016 07:26 UTC
@isuruf Will you submit the SymPy patch?
Isuru Fernando
@isuruf
Feb 06 2016 07:27 UTC
Just wanted to check that you get the same speedup
Ralf Stephan
@rwst
Feb 06 2016 07:31 UTC
Confirm! (4.7s-->3.3s)
Isuru Fernando
@isuruf
Feb 06 2016 07:32 UTC
Great
Ralf Stephan
@rwst
Feb 06 2016 07:36 UTC
That should speed up SymPy as a whole.
Ralf Stephan
@rwst
Feb 06 2016 08:41 UTC
And with symengine/symengine#791 we're down to 2.8s.
With symengine taking only 0.1s of that.
Akash Trehan
@CodeMaxx
Feb 06 2016 09:44 UTC
@isuruf Can you review #792
Isuru Fernando
@isuruf
Feb 06 2016 09:47 UTC
Can you add the derivatives as well?
Sumith Kulal
@Sumith1896
Feb 06 2016 09:47 UTC
And tests of course :)
Isuru Fernando
@isuruf
Feb 06 2016 09:47 UTC
printing as well
Akash Trehan
@CodeMaxx
Feb 06 2016 09:48 UTC
@Sumith1896 I'll add the tests. The PR is not yet complete
@isuruf derivatives for all the trigonometric functions?
Isuru Fernando
@isuruf
Feb 06 2016 09:49 UTC
Just for the functions you added. Others are there
Akash Trehan
@CodeMaxx
Feb 06 2016 09:50 UTC
Yeah I surely will
and printing too
Akash Trehan
@CodeMaxx
Feb 06 2016 10:56 UTC
are there any tests for complex_mpc.cpp ?
Akash Trehan
@CodeMaxx
Feb 06 2016 12:11 UTC
How do I find modulus of a Basic argument ? I need to write the derivative of acsch
currently I am using sqrt(pow(self.get_arg(),2))
Isuru Fernando
@isuruf
Feb 06 2016 13:08 UTC
Use abs
Akash Trehan
@CodeMaxx
Feb 06 2016 13:14 UTC
changed to abs
what is the link for?
Akash Trehan
@CodeMaxx
Feb 06 2016 13:20 UTC
oh..cool
Isuru Fernando
@isuruf
Feb 06 2016 13:35 UTC
@CodeMaxx, I left a few comments
Akash Trehan
@CodeMaxx
Feb 06 2016 18:16 UTC
@isuruf Why in derivative.cpp the derivative is returned after multiplying with self.get_arg()->diff(x) ?
Isuru Fernando
@isuruf
Feb 06 2016 18:23 UTC
Where?
Isuru Fernando
@isuruf
Feb 06 2016 18:24 UTC
Ah. what is the derivative of sin(x^2) w.r.t x?
Akash Trehan
@CodeMaxx
Feb 06 2016 18:25 UTC
cos(x^2)*2*x
Isuru Fernando
@isuruf
Feb 06 2016 18:26 UTC
That's the reason to multiply by the derivative of the arg
Akash Trehan
@CodeMaxx
Feb 06 2016 18:27 UTC
oh got it.
Was thinking with respect to the argument itself
I made the changes according to your comments
Isuru Fernando
@isuruf
Feb 06 2016 18:31 UTC
@CodeMaxx, did you compile the code locally?
Akash Trehan
@CodeMaxx
Feb 06 2016 18:31 UTC
I just did... I am fixing the errors
Sorry didn't compile it before upload
I'll fix it asap
Isuru Fernando
@isuruf
Feb 06 2016 18:34 UTC
No problem. let me know when it's ready to review
Akash Trehan
@CodeMaxx
Feb 06 2016 18:34 UTC
yeah, will do
Akash Trehan
@CodeMaxx
Feb 06 2016 22:41 UTC
@rwst is -DWITH_ARB=yes by default ?