These are chat archives for symengine/symengine

10th
Feb 2016
Akash Trehan
@CodeMaxx
Feb 10 2016 16:01
@isuruf @Sumith1896 #792 - Tests added for csch, sech, acsch
Isuru Fernando
@isuruf
Feb 10 2016 17:05
@CodeMaxx, can you also add tests for eval_mpfr, eval_mpc, real_mpfr, real_double, complex_double and complex_mpc?
Akash Trehan
@CodeMaxx
Feb 10 2016 17:09
@isuruf Sure.
Also with respect to #795 , is there any way to detect if the user specified the value of WITH_FLINT or not?
Isuru Fernando
@isuruf
Feb 10 2016 17:10
I'm not sure. Does Maybe work?
Akash Trehan
@CodeMaxx
Feb 10 2016 17:10
The Maybe solution doesn't work.
The cache is set to Maybe only on the first run... otherwise the variable retains the value of the previous run
if I use FORCE then the cache remains Maybe no matter what the user specifies.
Akash Trehan
@CodeMaxx
Feb 10 2016 17:20
@isuruf Is there any specific reason why eval_mpfrand others you mentioned have no tests for any of hyperbolic and inverse hyperbolic functions?
Isuru Fernando
@isuruf
Feb 10 2016 17:22
nope. I simply forgot to do that. Can you add a few tests just for the three functions you implemented and then maybe in another PR, add missing tests?
Akash Trehan
@CodeMaxx
Feb 10 2016 17:23
yeah, I was thinking of doing the same.
Srajan Garg
@srajangarg
Feb 10 2016 18:01
master contains two trailing whitespaces
symengine/series_flint.h:25:    
symengine/series.cpp:47:
@isuruf @certik can you finsih reviewing #772 , it also fixes these whitespaces
Srajan Garg
@srajangarg
Feb 10 2016 18:11
Any reason as to why Travis isn't catching these trailing white spaces?
Akash Trehan
@CodeMaxx
Feb 10 2016 18:55
The code test_travis.sh seems correct ...strange its not detecting it.