These are chat archives for symengine/symengine

8th
Mar 2016
Isuru Fernando
@isuruf
Mar 08 2016 01:35
@chenchfort, UnivariatePolynomial::from_dict is different from UnivariateIntPolynomial::from_dict. Can you fix that?
Also is_canonical methods
Charles Chen
@chenchfort
Mar 08 2016 01:36
Ok.
Isuru Fernando
@isuruf
Mar 08 2016 01:39
Also there are unnecessary changes like this, https://github.com/symengine/symengine/pull/857/files#diff-24b25e13254d2ee9c30c9de4b209fcc8L198 which makes it harder to review. I don't mind the formatting, but it should be done in a new PR to make this PR easy to review
Charles Chen
@chenchfort
Mar 08 2016 01:45
Now that the implementation of from_dict are the same, I’m getting a seg vio in one of the test cases
Isuru Fernando
@isuruf
Mar 08 2016 01:56
Can you push the changes?
Charles Chen
@chenchfort
Mar 08 2016 01:57
Done.
Charles Chen
@chenchfort
Mar 08 2016 04:53
@isuruf Should get_args() also have the same implementation?
Isuru Fernando
@isuruf
Mar 08 2016 06:50
Yes
Charles Chen
@chenchfort
Mar 08 2016 08:40
Can you take a look at the updated #857 ?
Abhinav Agarwal
@abhinavagarwal07
Mar 08 2016 17:38
@isuruf
I was thinking of getting started with integration.
I see sympy in trigonometry.py handles integration of sin-cos etc.
what architecture should fit this implementation?