These are chat archives for symengine/symengine

12th
Mar 2016
Nishant Nikhil
@nishnik
Mar 12 2016 11:44
@isuruf
Please look into #846
Acha Bill
@achabill
Mar 12 2016 16:56
Hello, working on Assumptions module for SymEngine. First, I'm thinking if it's ok to have this module in a namespace nested in SymEngine e.g SymEngine::Assumptions::ask.
Isuru Fernando
@isuruf
Mar 12 2016 16:57
Not really necessary. It would be easier if it was in the SymEngine namespace
Acha Bill
@achabill
Mar 12 2016 16:59
ok. Also wondering if everything should be in assumption.h or should be separated into its related classes and implemented in separated files all stored in some assumptions directory in the source.
Isuru Fernando
@isuruf
Mar 12 2016 17:00
Let's start with everything in assumptions.h. We can re-think the directory structure when it becomes larger
Acha Bill
@achabill
Mar 12 2016 17:00
great
Looking at this, BooleanFunction, AppliedPredicate, bool, BooleanAtom etc... are part SymPy's logic module. I don't think SymEngine has a logic module. I porting this module to SymEngine necessary? Can SymEngine's assumptions bypass this module?
Isuru Fernando
@isuruf
Mar 12 2016 17:06
It's up to you to decide
Isuru Fernando
@isuruf
Mar 12 2016 17:52
@chenchfort, travis build not showing up is some error on travis part. I left one last comment. If you can fix that, then we can merge
Charles Chen
@chenchfort
Mar 12 2016 18:13
@isuruf Ok. However on my repo travis ran my commit and there are 2 build errors from printer.cpp.
Build 14 fails because you don't have coveralls configured
Charles Chen
@chenchfort
Mar 12 2016 18:21
Can you cancel my previous build job, 1181, on AppVeyor CI?
Isuru Fernando
@isuruf
Mar 12 2016 18:21
Done
Charles Chen
@chenchfort
Mar 12 2016 18:21
Thanks.
So is there anything else to change in #857? @isuruf
Isuru Fernando
@isuruf
Mar 12 2016 18:24
No. looks good to me
parthparashar1647
@parthparashar1647
Mar 12 2016 19:08
This message was deleted