These are chat archives for symengine/symengine

14th
Mar 2016
Nishant Nikhil
@nishnik
Mar 14 2016 02:21
Thank you @isuruf
parthparashar1647
@parthparashar1647
Mar 14 2016 03:14
thanks
Iris Lui
@irislq
Mar 14 2016 03:42
@isuruf For UnivariateSeries::pow, are we going to have to deal with negative exponents? The same goes for UnivariateExprPolynomial
Isuru Fernando
@isuruf
Mar 14 2016 05:20
You only need to handle var**-exp case. Throw an error if the polynomial is not x or a constant
Nishant Nikhil
@nishnik
Mar 14 2016 14:30
@isuruf
Here set_weak_self_ptr is a private member function, so we can't call it like here.
But anyways, it passes travis build ?
What should I do ?
Else, please review it.
Isuru Fernando
@isuruf
Mar 14 2016 14:32
Don't use rcp directly. Use make_rcp
Can you also replace tabs with spaces and format according to style guide?
Nishant Nikhil
@nishnik
Mar 14 2016 15:04
Sorry. Will do that.
I can't use make_rcp as it needs a call to constructor, which is private for Singleton class.
Isuru Fernando
@isuruf
Mar 14 2016 15:14
You can make the make_rcp method a friend of your class
Nishant Nikhil
@nishnik
Mar 14 2016 16:27
@isuruf
Done! Please review!
parthparashar1647
@parthparashar1647
Mar 14 2016 17:52
working on sympy/sympy#10803 need assitance
Isuru Fernando
@isuruf
Mar 14 2016 17:52
@badcoderparashar, you'll have better luck in the SymPy room
parthparashar1647
@parthparashar1647
Mar 14 2016 17:55
thanks
Nishant Nikhil
@nishnik
Mar 14 2016 19:26
@isuruf
I added the compare functionality in interval based on their length.
Please check.