These are chat archives for symengine/symengine

20th
Mar 2016
Isuru Fernando
@isuruf
Mar 20 2016 02:51
What is FiniteSet?
Akash Trehan
@CodeMaxx
Mar 20 2016 05:50
Oh sorry for the confusion. Set with finite no. of elements…. I mean its yet to be implemented but like we had Number as the boundary of Intervals, do we want FiniteSet to also have elements of type Number
Isuru Fernando
@isuruf
Mar 20 2016 05:50
Depends on what the elements are
Akash Trehan
@CodeMaxx
Mar 20 2016 05:52
I’m not sure I understand. Can you elaborate?
Isuru Fernando
@isuruf
Mar 20 2016 05:52

Set with finite no. of elements

What are the elements?

Akash Trehan
@CodeMaxx
Mar 20 2016 05:52
I mean we should have functionality to store any kind of elements right
Oh… like solutions to a UnivariatePolynomial and stuff
Isuru Fernando
@isuruf
Mar 20 2016 05:53
So, are they numbers? or any symbolic type?
Akash Trehan
@CodeMaxx
Mar 20 2016 05:55
Depends on what we input actually…but Number won’t support symbolic right?
Isuru Fernando
@isuruf
Mar 20 2016 05:55
Yes
Akash Trehan
@CodeMaxx
Mar 20 2016 05:55
So what alternative can we have? We want to represent the solutions in any case.
Isuru Fernando
@isuruf
Mar 20 2016 05:56
Then, a Basic can be used
Akash Trehan
@CodeMaxx
Mar 20 2016 05:58
Does Basic store things like mpfr_class ?
Isuru Fernando
@isuruf
Mar 20 2016 05:58
Number is a subclass of Basic. So, yes
Akash Trehan
@CodeMaxx
Mar 20 2016 06:00
Oh right! I missed that somehow. Thanx! :smile:
Akash Trehan
@CodeMaxx
Mar 20 2016 06:09
@isuruf Can you update the description on #871 ? See my comment on #876
Isuru Fernando
@isuruf
Mar 20 2016 06:10
You can also comment on #871
Akash Trehan
@CodeMaxx
Mar 20 2016 06:11
:+1:
Charles Chen
@chenchfort
Mar 20 2016 06:12
@nishnik What’s the status on #873? Ready to merge?
Nishant Nikhil
@nishnik
Mar 20 2016 06:20
@chenchfort Yeah!
Will be good if someone reviews it again.
Akash Trehan
@CodeMaxx
Mar 20 2016 13:18
@isuruf @Sumith1896 Do we have any functions for polynomial manipulation as of now? E.g. Square free decomposition or GCD ?
Isuru Fernando
@isuruf
Mar 20 2016 13:18
Nope
Francesco Biscani
@bluescarni
Mar 20 2016 13:48
@CodeMaxx FYI in Piranha there is initial support for polynomial GCD, see bluescarni/piranha#55 Performance-wise it still needs a lot of work and probably it cannot be a solution for symengine, as Piranha is an optional dependency. But maybe if someone starts working on this in symengine we can join forces and compare implementations/algorithms/results.
I'd like to have also factorization and things like partial fraction decomposition eventually, but it's a long road
Nishant Nikhil
@nishnik
Mar 20 2016 14:11
@bluescarni I was already thinking of implementing finite field (Galois field) for univariate polynomials. And after that we can proceed to factorisation using square free decomposition and modulus Algorithms like Chinese remainder theorem. As I have already taken a course on it. It will be intuitive for me to do it.
But for that many a design considerations must be taken.
Akash Trehan
@CodeMaxx
Mar 20 2016 14:16
@nishnik Great! I’ve been thinking along the same lines. I was thinking of implementing the same things and finally moving on to implement the Cantor-Zassenhaus algorithm for polynomial factorisation after all the required components are in place.
Design will be decided on-the-way through some discussions before we implement each piece required to complete the Factorisation picture.
Francesco Biscani
@bluescarni
Mar 20 2016 14:50
@nishnik I am not too familiar with abstract algebra, I am mostly learning as I implement algorithms in Piranha. In this context when you talk about finite fields, you are basically referring to implementing an integral type with modular algebra over primes or something else?
Akash Trehan
@CodeMaxx
Mar 20 2016 14:54
@bluescarni Yes we’ll be working on GCD this summer. What GCD algorithm are you using in Piranha ?
Nishant Nikhil
@nishnik
Mar 20 2016 14:54
I am actually referring to implementing an integral type with modular algebra.
@CodeMaxx its there in bluescarni/piranha#55
Sorry bluescarni/piranha#52
Currently, there are two GCD algorithms available: subresultant sequence with pseudo-remainders and heuristic GCD.
Akash Trehan
@CodeMaxx
Mar 20 2016 14:58
Cool.
Francesco Biscani
@bluescarni
Mar 20 2016 14:59
@nishnik right, I meant that :)
I was asking because that's needed for modular GCD algorithms and I'll eventually implement it
but first it's needed to implement good data structures for polys
Nishant Nikhil
@nishnik
Mar 20 2016 15:01
@bluescarni Oh! cool. Yeah! I saw that paper also you had mentioned in the issue.
Nishant Nikhil
@nishnik
Mar 20 2016 18:37
@isuruf Do we have division functionality for univariate polynomials ?
Akash Trehan
@CodeMaxx
Mar 20 2016 19:15
No we don’t.
@chenchfort @irislq Are you planning to implement division for UnivariatePolynomial in near future ?
Charles Chen
@chenchfort
Mar 20 2016 19:55
Sure. However I think @isuruf mentioned that we don’t need to have it? I might be wrong.
Do you guys know how to pass the codecov test? Is it like the quality has to match or exceed symengine’s?
Akash Trehan
@CodeMaxx
Mar 20 2016 20:32
The whole code has to be covered by tests I think.
Which PR are you facing the problem on?
@chenchfort Ok so from what I observe the coverage has to be greater( in %) than what is on master branch.
Charles Chen
@chenchfort
Mar 20 2016 20:51
#868 Ok I’ll see what I can do.