These are chat archives for symengine/symengine

15th
May 2016
Srajan Garg
@srajangarg
May 15 2016 08:37
@isuruf can you give me a brief on what I should be starting with right now? Any pointers? I am free today, and can discuss anytime you want.
Isuru Fernando
@isuruf
May 15 2016 08:43
We need to get #940 finished, before everything else
Srajan Garg
@srajangarg
May 15 2016 08:46
Okay, will start reading through it
Isuru Fernando
@isuruf
May 15 2016 08:54
You could also restart work on #938 with UnivariateBase instead of UnivariateIntBase
This needs to be on top of #940 though
@srajangarg, are you here?
Srajan Garg
@srajangarg
May 15 2016 09:21
Yes
So, I'll read through #940, get that merged. And then work on #938. I don't think it will be possible to start work on a base, before the changes are merged in.
Srajan Garg
@srajangarg
May 15 2016 09:59
@isuruf are you there?
Srajan Garg
@srajangarg
May 15 2016 10:27
@chenchfort can you give me a short summary of how the structure of UnivariatePolynomial and UnivariateExprPolynomial was before. And what is the structure now (as in #940) , plus why the change was needed? I am not up to date with the symbolic side of the polynomials in SymEngine.
Isuru Fernando
@isuruf
May 15 2016 11:41
@srajangarg, it was needed because we needed a performance and having it immutable is not good for performance
UnivariatePolynomial is not used by anything now
Iris Lui
@irislq
May 15 2016 20:07
@srajangarg Before, UnivariatePolynomial had a map_int_Expr dict_ while UnivariateExprPolynomial had an RCP of UnivariatePolynomial. Now #940 has UnivariateExprPolynomial containing map_int_Expression dict_ and UnivariatePolynomial has a UnivariateExprPolynomial expr_dict_ (which is basically the reverse of the original implementation)
Isuru Fernando
@isuruf
May 15 2016 20:11
@irislq, I sent a PR
Otherwise it looks good to merge
Iris Lui
@irislq
May 15 2016 20:34
@isuruf Done
Iris Lui
@irislq
May 15 2016 20:43
@isuruf Is there any way to cancel the builds for the older commits on Travis?
Isuru Fernando
@isuruf
May 15 2016 20:45
Done
Iris Lui
@irislq
May 15 2016 20:52
@isuruf Thanks! For UnivariateExprPolynomial, what should be done for operator<<? Since there's __str__(), I don't think this is needed anymore
Isuru Fernando
@isuruf
May 15 2016 20:56
Let's keep it for now for convenience
Charles Chen
@chenchfort
May 15 2016 22:19
@isuruf Looks like it’s ready. Do we need to do anything with codecov/patch?