These are chat archives for symengine/symengine

15th
Aug 2016
Ondřej Čertík
@certik
Aug 15 2016 03:19
@coder0xff sorry for all the troubles you are getting. I am aware that the way we use cmake is ok, but newer cmake allows a more natural way, and I have started working on it here: symengine/symengine#757
Everything works, except the cmake external package thing, which I didn't have time to figure out yet, that's why it isn't merged yet.
The idea is that things should just work for you in MSVC, and it's either a bug in our cmake files, or a bug in cmake itself.
Isuru Fernando
@isuruf
Aug 15 2016 03:23
It's a bug in our cmake files introduced in #675
Ondřej Čertík
@certik
Aug 15 2016 03:25
Will #757 fix the bug?
@bluescarni, that would be awesome. Please keep us updated.
Isuru Fernando
@isuruf
Aug 15 2016 03:28
No. We have to fix the documentation.
Btw, for #757, I'm not sure whether we need it.
Ondřej Čertík
@certik
Aug 15 2016 03:30
Why not?
It simplifies the code, and leaves things for cmake to figure out, which is the way it's meant to be used, the author of cmake told me.
Isuru Fernando
@isuruf
Aug 15 2016 03:31
Yes, I remember. The only problem is that all the Find*.cmake files in CMake source goes against it
Isuru Fernando
@isuruf
Aug 15 2016 03:40
@certik, it seems that now they are using the approach in #757. So, we should finish #757
Ondřej Čertík
@certik
Aug 15 2016 03:52
@isuruf my understanding is that all the *.cmake files in CMake actually use the #757 approach or at least they are transitioning to it.
Isuru Fernando
@isuruf
Aug 15 2016 04:02
@certik, can you check whether this is okay, https://github.com/isuruf/symengine/tree/cmake#external-libraries ?
Ondřej Čertík
@certik
Aug 15 2016 04:03
@isuruf I think that's correct.
Srajan Garg
@srajangarg
Aug 15 2016 20:43
@isuruf @certik what must I submit as part of the final evaluation for GSoC? I was thinking of the PRs (by me) on github and my blog
Also, @certik can you have a look at https://github.com/symengine/symengine/wiki/Univariate-Polynomials-in-SymEngine, and tell me what parts need to be elaborated more (the "Structure" part still needs to be described)