These are chat archives for symengine/symengine

28th
Mar 2017
Srajan Garg
@srajangarg
Mar 28 2017 01:49
@prateeksingh0001 run ./bin/test_format_local.sh, commit and push
Prateek Singh
@prateeksingh0001
Mar 28 2017 04:09
@srajangarg the problem with running the above command is that it formats each and every file that's present in symengine. Is there any way I could run this script selectively, or I may be able to specify the files which need to be formatted ?
Isuru Fernando
@isuruf
Mar 28 2017 04:10
@prateeksingh0001, use clang-format-3.7
BHAVISHYA
@bhavishyagopesh
Mar 28 2017 08:22
@isuruf ,Since I was on mac I couldnt find .so(in mac, it was .dylib ), but I still couldnt figure out, how the version is decided?
Isuru Fernando
@isuruf
Mar 28 2017 08:23
@bhavishyagopesh, the version should probably be major.minor for the dylib
BHAVISHYA
@bhavishyagopesh
Mar 28 2017 08:56
@isuruf I guess, I should add ,something similar to gmp, in ~/symengine/cmake/SymEngineConfig.cmake.in for libsymengine.so, Am I right?
Isuru Fernando
@isuruf
Mar 28 2017 08:57
SymEngineConfig.cmake is a file for other projects to find SymEngine
BHAVISHYA
@bhavishyagopesh
Mar 28 2017 09:00
I have got major.minor for project(symengine)....Do I have to use that for libsymengine.so?
Isuru Fernando
@isuruf
Mar 28 2017 09:00
yes
BHAVISHYA
@bhavishyagopesh
Mar 28 2017 09:01
ok...I'm trying
BHAVISHYA
@bhavishyagopesh
Mar 28 2017 09:21
@isuruf Is this the right thing to do : In CMakeLists.txt add this : set_target_properties(symengine PROPERTIES VERSION ${SYMENGINE_VERSION} SOVERSION ${SYMENGINE_VERSION_MAJOR} )
Isuru Fernando
@isuruf
Mar 28 2017 09:24
Does that work?
BHAVISHYA
@bhavishyagopesh
Mar 28 2017 09:25
Actually I asked you before doing anything and also I'm on linux now(If that matters),Should I try that?
BHAVISHYA
@bhavishyagopesh
Mar 28 2017 09:35
No, it didnt worked
BHAVISHYA
@bhavishyagopesh
Mar 28 2017 09:59
I think where that line has to be added would also matter...Any suggestions
Isuru Fernando
@isuruf
Mar 28 2017 10:00
There was a PR recently, symengine/symengine#1239
BHAVISHYA
@bhavishyagopesh
Mar 28 2017 10:08
I made those changes (suggested by @kanchanarp), but do they work?I'm still not getting any versions..
BHAVISHYA
@bhavishyagopesh
Mar 28 2017 11:09
@isuruf For #1219 , do we have to implement CSE on the lines of cse
Isuru Fernando
@isuruf
Mar 28 2017 11:11
@bhavishyagopesh, yes
BHAVISHYA
@bhavishyagopesh
Mar 28 2017 14:56
@isuruf I tried running cmake but couldnt find INTEGER_CLASS:, Could you please mention the exact command(The cmake shows that FLINT and Piranha both are off).
Isuru Fernando
@isuruf
Mar 28 2017 15:06
what's the output when you run cmake
BHAVISHYA
@bhavishyagopesh
Mar 28 2017 15:29
@isuruf It was GMP ,finally ,I was missing on grep...
Christopher Rackauckas
@ChrisRackauckas
Mar 28 2017 18:30
happy to see that's coming along.
Prateek Singh
@prateeksingh0001
Mar 28 2017 23:34
@isuruf Thanks for the help, I've formatted the code and repushed it. Kindly check it symengine/symengine#1228