These are chat archives for symfony2admingenerator/GeneratorBundle

10th
Apr 2015
what about Puli?
I think Puli is exactly here for this kind of things: locating a resource independently of files locations and so on... no?
Matej Velikonja
@matejvelikonja
Apr 10 2015 08:09
looks good, will you give it a try?
Stéphane
@sescandell
Apr 10 2015 08:22
Maybe this week-end... not sure I'll have time, I have a conference on another subject to prepare... but I can try
Bob van de Vijver
@bobvandevijver
Apr 10 2015 09:09
Why would we use another external library while the Symfony core already provides what we need?
Stéphane
@sescandell
Apr 10 2015 09:15

Actually, I think it just depends about which replacement we are talking about.
For example in Commands: it migh be logic to use symfony kernel resolution
But for Builder/Generator: I'm not sure Kernel might be used here (have to check that point)

And about Puli, it is a library that initially was thinked specifically for these kind of issues: how do I refer a resource from a plugin into a global application (starting from Bundle and Symfony integrations and so on). I alredy was thinking about using it for Templates (but needed to test it to see if it can really help).

I'm not saying "we have to use Puli". Just guessing it might be a solution and that we should not change DIR and FILE calls without really looking at "what are we trying to do? Why are we using this code here and for what?"

This message was deleted
ioleo
@ioleo
Apr 10 2015 12:31
#96 looks OK to me, just waiting for last travis build to finish
ahh ffs another stalled build? :/
ioleo
@ioleo
Apr 10 2015 13:04
ok all green, merged and created new tag, v2.0-beta.32, gJ @sescandell :+1:
Bob van de Vijver
@bobvandevijver
Apr 10 2015 13:05
Whoohoo, now we can move from 1.1 to 2.0 :+1:
ioleo
@ioleo
Apr 10 2015 13:07
My next issue on the wishlist is #115 :P
Bob van de Vijver
@bobvandevijver
Apr 10 2015 13:11
We're gonna use filters on top, so that's already there
Although I needed to extract some of the JS from adminLTE
ioleo
@ioleo
Apr 10 2015 13:23
Maybe you could share your opinion on #98 ?
Bob van de Vijver
@bobvandevijver
Apr 10 2015 13:25
Then I night to take a look at that first, I did not yet spot that change... I will look tonight
ioleo
@ioleo
Apr 10 2015 13:26
I've posted another image to compare
yay, test coverage increasted by 1%... to stunning total of 11% :P
Tobias Feijten
@tobias-93
Apr 10 2015 15:20
@loostro please review #126 soon
Tobias Feijten
@tobias-93
Apr 10 2015 15:35
it is blocking if the excel feature is used...
Bob van de Vijver
@bobvandevijver
Apr 10 2015 16:45
@loostro For #98, see the new comment ;)
In short, :+1: