These are chat archives for symfony2admingenerator/GeneratorBundle

8th
Jun 2015
Matej Velikonja
@matejvelikonja
Jun 08 2015 08:39
hey guys. Why the #156 is still not merged? Any special reason?
Stéphane
@sescandell
Jun 08 2015 09:47

Hi @matejvelikonja

Because we are waiting for a per-field customization

rather than just a "global" one
It should not be a big deal... almost everything is described here: https://github.com/symfony2admingenerator/GeneratorBundle/pull/156#issuecomment-108761702
Matej Velikonja
@matejvelikonja
Jun 08 2015 09:49
but what? You were always convincing me than this is already implemented?
but still, what you are saying is another feature, and can be done. we are in a really hurry with this grid feature, since our customer is waiting for it
Stéphane
@sescandell
Jun 08 2015 09:52

but what? You were always convincing me than this is already implemented?

are we talking about the same thing... or did I missed something?

What @tobias-93 is talking about is a customization trick for fieldsets. We are here talking about per-field configuration. No?

Matej Velikonja
@matejvelikonja
Jun 08 2015 09:53
yes, this trick
i was under opinion that you can already set field width with this trick
Stéphane
@sescandell
Jun 08 2015 09:53
As far as I know, you cannot
But you can easily implement it for your customer even if nothing is merged yet
Matej Velikonja
@matejvelikonja
Jun 08 2015 09:54
i guess noone knows :)
Stéphane
@sescandell
Jun 08 2015 09:54
you can create your own Column class
with methods I mentionned in my comment
hmmm... not sure Column class is overridable
let me check
ok... you can with your own [Doctrine|DoctrineODM|Propel]Generator
and by customizing templates

I personnally will not have time to make it in the bundle today. So:
1- You can push a PR with this feature, I'll merge it
2- Use this "project configuration" on your side waiting for a native implementation

If you can make a PR that would be better :)

Matej Velikonja
@matejvelikonja
Jun 08 2015 10:02
but I still don't see the reason for not merging #156 because it's a different feature and also non BC
but ok, your bundle, your decision :)
Stéphane
@sescandell
Jun 08 2015 10:02
no no no
not MY bundle My Decision
it's a "community project"
for me, a "global" grid class doesn't make a lot of sense for all fields
but if you think it does
let's merge it
Bob van de Vijver
@bobvandevijver
Jun 08 2015 10:03
You're sure it's not BC-breaking?
Stéphane
@sescandell
Jun 08 2015 10:04
I'm almost sure it is not
Matej Velikonja
@matejvelikonja
Jun 08 2015 10:04
?
why would it be/
Bob van de Vijver
@bobvandevijver
Jun 08 2015 10:04
Love the edit functionality ;)
Stéphane
@sescandell
Jun 08 2015 10:04
:)
if the property doesn't exists, it still use the col-md-4, so it should not break anything
Matej Velikonja
@matejvelikonja
Jun 08 2015 10:05
it's not BC, since it fallbacks to col-md-4 if gridClass is not provided
but yes, I also agree, that we should have also possibility to change per-field class
and one more favour. when you merge, can you tag it?
Dražen Perić
@peric
Jun 08 2015 11:18
ok, let's merge this and do other improvements in separate "task" :)