Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Divyanshu Thakur
    @divyanshu132

    I think that it would suffice to add a test for the relative orders being primes.

    That kind of tests are already there, should we add more tests.

    I don't understand how Codecov works.
    Kalevi Suominen
    @jksuom
    It seems that the handbook assumes that the relative orders are prime in the induced pcgs algorithm. I tried to look more carefully where it would be needed but could not find such a place. So it looks like the test is not necessary for the algorithm.
    I don't understand either how Codecov works but perhaps we should not worry too much.
    Divyanshu Thakur
    @divyanshu132

    So it looks like the test is not necessary for the algorithm.

    So, Is it good to go?

    Kalevi Suominen
    @jksuom
    I think it can be merged now.
    Divyanshu Thakur
    @divyanshu132
    Thanks!
    Kalevi Suominen
    @jksuom
    The Sphinx documentation now passes the tests. Have you built the html? Does it look ok?
    Divyanshu Thakur
    @divyanshu132
    Yes, it looks good to me.
    Should I share some screenshots?
    Kalevi Suominen
    @jksuom
    That would be helpful for me.
    Divyanshu Thakur
    @divyanshu132
    Ok!
    Divyanshu Thakur
    @divyanshu132
    sympy1.png
    sympy2.png
    sympy3.png
    sympy4.png
    sympy5.png
    Kalevi Suominen
    @jksuom
    Thanks. That looks ok. I left a comment on relative_order that would probably look better as upright text.
    Divyanshu Thakur
    @divyanshu132
    Okay.
    Kalevi Suominen
    @jksuom
    There is one thing that I forgot to mention. Namely, single backticks generate LaTeX (and mathit) in SymPy's Sphinx configuration. That makes code like pcgs and pc_series[4] look different from what we would want. We should use double backticks instead.
    Divyanshu Thakur
    @divyanshu132
    Ok, I'll push the changes by tonight.
    Kalevi Suominen
    @jksuom
    It looks like the rst file is ready to be included though I could not make the html. My sphinx version (ubuntu 16.04) may be too old.
    Divyanshu Thakur
    @divyanshu132
    Do you need few screenshots as per above changes.
    Kalevi Suominen
    @jksuom
    Can you send the page on the computation of polycyclic presentation?
    Divyanshu Thakur
    @divyanshu132
    sympy6.png
    Have a look!
    Kalevi Suominen
    @jksuom
    Thanks. That looks ok to me.
    I think it can be merged.
    Divyanshu Thakur
    @divyanshu132
    Thanks!
    Kalevi Suominen
    @jksuom
    There is one more thing that you could work with. It would be useful to have more information in the docstrings of classes and their methods. In particular, "Parameters" could be added. We generally follow the numpy conventions as explained here.
    There are some differences. Double backticks instead of single ones for variables, for example, and ===== for underlining (with exactly the same length).
    Divyanshu Thakur
    @divyanshu132
    Ok, I'll try!
    Divyanshu Thakur
    @divyanshu132
    @jksuom I've opened a PR on extending the docstrings of polycyclic groups. Have a look sympy/sympy#17476
    Kalevi Suominen
    @jksuom
    Ok, thanks.
    Divyanshu Thakur
    @divyanshu132
    \{ is generating error, can't we use escape sequence in docstrings?
    Kalevi Suominen
    @jksuom
    It should be possible if the docstring is raw: r""" ... """.
    Divyanshu Thakur
    @divyanshu132
    oohh!
    Divyanshu Thakur
    @divyanshu132
    @jksuom I've added the final report, please have a look and let me know if anything needs improvement https://github.com/sympy/sympy/wiki/GSoC-2019-Report
    Kalevi Suominen
    @jksuom
    Ok. I'll do that tomorrow.
    Divyanshu Thakur
    @divyanshu132
    Ok!
    Kalevi Suominen
    @jksuom
    That looks fine to me. (Though I'm not sure of the word "whosoever".) I think that google would expect a link to the actual report https://github.com/sympy/sympy/wiki/GSoC-2019-Report-Divyanshu-Thakur:-Group-Theory. I'll have to check the instructions.
    Divyanshu Thakur
    @divyanshu132
    I'll replace the word "whosoever".

    I think that google would expect a link to the actual report

    Okay!

    Divyanshu Thakur
    @divyanshu132
    @jksuom thanks a lot for the help during this project. You taught me a lot of things, you were so nice throughout the journey and answered my all the silly questions. Once again thanks for your time!!
    Kalevi Suominen
    @jksuom
    Thanks. The subject of polycyclic groups was probably harder than you expected as the handbook does not deal with the creation of polycyclic presentations. It seems that GAP was not helpful either.
    Divyanshu Thakur
    @divyanshu132
    That's right, Thanks!
    Mohit Gupta
    @mohitacecode
    Hello everyone, My name is Mohit Gupta I will directly come to point I want to work on Group Theory module in GSOC 2020.I have seen the idea page of Group Theory and saw the following things are unImplemented
    • Computation of various subgroups of infinite finitely presented groups
    • Computation of Galois groups for a given polynomial
    • Finding kernels of homomorphisms with infinite domains
    • Extend functionalities of polycyclic groups
    • Quotient groups
    • Automorphism groups
      I also have some Ideas that I want to add such as :
    • Triple Product Property (https://en.wikipedia.org/wiki/Triple_product_property) we can do it for both groups and sets.
    • Normal Groups - While learning about Triple Product Property I also found that currently we do not have Implemented Normal subgroups so maybe this will be a new addition.
    • Intersection of subgroups
      This is not the final ideas I have just briefed I am still researching and going through code base.(will be able to spend more time once my exams get overed.
      I am working in sympy from Jan 2020. Any suggestions are welcome. Please tell if any there are any stalled Pr or where I can start the work from .
      @jksuom @divyanshu132 @asmeurer @RavicharanN
    Kalevi Suominen
    @jksuom
    Have you also been thinking about possible implementations? I seems to me that there is time for only a few of those topics in one summer.
    Mohit Gupta
    @mohitacecode
    Actually these were the things that I have seen or noticed while working in sympy.
    Yeah you are right I think we have to select only few ideas out of them that can be possibly completed in a summer.I am still working to narrow down this list (I will come up with much more descriptive and sensible list asap my universities exam gets over).
    I was looking for your insight that what do you think about the ideas and what can be improved or removed to make a balanced amount of work for summer.
    Kalevi Suominen
    @jksuom
    About normal subgroups. Normality is a property. Either a subgroup is normal or it is not so there is no special implementation. What could be implemented is a normality test. I would look into GAP to see what was implemented there.