Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Feb 21 04:14
    Jack-Barry commented #46
  • Feb 13 02:45
    andykais labeled #53
  • Feb 13 02:45
    andykais opened #53
  • Feb 11 10:52
    kierans commented #9
  • Jan 21 16:35
    ramonsan closed #52
  • Jan 21 16:35
    ramonsan commented #52
  • Jan 21 16:24
    ramonsan edited #52
  • Jan 21 16:00
    Jack-Barry commented #46
  • Jan 20 15:35
    Jack-Barry commented #46
  • Jan 20 09:43
    ramonsan labeled #52
  • Jan 20 09:43
    ramonsan opened #52
  • Dec 30 2019 00:34
    Jack-Barry commented #46
  • Dec 29 2019 05:06
    jpspringall commented #46
  • Dec 19 2019 05:52
    larixer commented #46
  • Dec 18 2019 22:17
    Jack-Barry commented #46
  • Dec 18 2019 06:50
    larixer commented #46
  • Dec 18 2019 03:42
    Jack-Barry commented #46
  • Dec 17 2019 14:02
    Jack-Barry commented #46
  • Dec 16 2019 12:43
    Jack-Barry commented #51
  • Dec 15 2019 17:07
    JamesMcMahon commented #34
Victor Vlasenko
@larixer
I don't know
I have started to maintain the fork when original author was long gone
And the only info I have is the original repo
Looks like this issue was the reason to switch to in memory:
zinserjan/mocha-webpack#25
Andrew Kaiser
@andykais
gotcha, I figured it was an perf improvement
Victor Vlasenko
@larixer
yes, better they keep the original way too :)
But what is good, the patch is not that big:
https://github.com/zinserjan/mocha-webpack/pull/83/files
So by reading this patch it is possible to add back old behavior too
It is much better than adding writing to disk from scratch
Andrew Kaiser
@andykais
yeah thats a very good point

so is this something you would be able to work on?

So, adding flag for using disk, sounds good for me

if its something that makes more sense for me to pr, Ill do my best, but Im not sure I can contribute during work hours, so it may be slow going, but I am willing to give it a go!

supremeo
@supremeo
hello all
having trouble with --watch
Victor Vlasenko
@larixer
hey
what problem?
supremeo
@supremeo
hi victor
its not detecting changes
so basically need to kill the term and run again
using mix-laravel and vue
Victor Vlasenko
@larixer
what version of mochapack do you use ? 1.1.1 ?
supremeo
@supremeo
"mochapack": "^1.1.1",
yep
"test:watch": "mochapack --watch --webpack-config=node_modules/laravel-mix/setup/webpack.config.js --require tests/JavaScript/setup.js tests/JavaScript/**/*.spec.js",
Victor Vlasenko
@larixer
can you try "mochapack": "1.1.0" ?
supremeo
@supremeo
sure
Victor Vlasenko
@larixer
I have made related changes to watching in 1.1.1, maybe I have broken something
supremeo
@supremeo
no.. doesn't seem to be it
i suspect it's not playing nicely with docker perhaps
Victor Vlasenko
@larixer
maybe, but maybe you don't read docs :)
the globs must be in double quotes
I'm not 100% sure, this is the reason, but it very well might be
supremeo
@supremeo
oh wow
how did i miss that
let me try
weird because the test runs... It just doesn't watch
You should consider throwing a warning for semi-blind people like me :)
Victor Vlasenko
@larixer
well, I can't, because your shell might unroll globs and mochapack sees final result
supremeo
@supremeo
no diff...
can you verify this format please
"test:watch": "mochapack --watch --webpack-config=node_modules/laravel-mix/setup/webpack.config.js --require tests/JavaScript/setup.js \"tests/JavaScript/**/*.spec.js\"",
Victor Vlasenko
@larixer
yes, the format is correct
well, I have no other clues, I need some example to reproduce myself
supremeo
@supremeo
do you have any experience with laravel-mix ?
Victor Vlasenko
@larixer
no, I have no
supremeo
@supremeo
so mix is a wrapper for webpack
Victor Vlasenko
@larixer
if you could set up some minimalistic project on github or point me to it, I can try to reproduce myself and look whats wrong
supremeo
@supremeo
i suspect it's not emitting changes
Ok thanks Victor, I'll try to work it out, if not make a repo. It's not a high priority though. I'll report back if I resolve it in case you care to know
thanks for the help
Victor Vlasenko
@larixer
sure, thank you !