These are chat archives for systemaccounting/mxfactorial

4th
Jun 2016
Kishan Jobanputra
@kishanj918
Jun 04 2016 04:11
okay
Kishan Jobanputra
@kishanj918
Jun 04 2016 06:34
have created pull request.
Max Funk
@mxfactorial
Jun 04 2016 06:35
Already merged.
Kishan Jobanputra
@kishanj918
Jun 04 2016 06:35
okayyy
Max Funk
@mxfactorial
Jun 04 2016 06:35
Your task is delivered, Kishan. Thank you.
Will negotiate another with Vivek.
Wish to clean up the code now to prepare for involvement from others.
Kishan Jobanputra
@kishanj918
Jun 04 2016 06:38
okay!! :+1:
bryantcj5691
@bryantcj5691
Jun 04 2016 10:17
Hi everyone, I'm Bryant. I'm implementing endpoint for user creation. I completed that task and bind it to the web client. Upon successful creation i should redirect user to the login page.
i'm new to react JS and i need help on how to redirect pragmatically.
bryantcj5691
@bryantcj5691
Jun 04 2016 12:15
I was able to figure out.
I created a pull request. But the CI build failed. the error message is ->
The command "openssl aes-256-cbc -K $encrypted_5979ecf7a4d6_key -iv $encrypted_5979ecf7a4d6_iv -in test/encrypted/client-secret.json.enc -out test/encrypted/client-secret.json -d" failed and exited with 1 during .
is it because the unit tests are not properly set up yet? or something wrong in my commit? in my local machine everything worked fine. However, i did added a new node module.
Max Funk
@mxfactorial
Jun 04 2016 17:20
Travis avoids building pull requests from forked repositories as a security measure: https://docs.travis-ci.com/user/pull-requests#Security-Restrictions-when-testing-Pull-Requests
Max Funk
@mxfactorial
Jun 04 2016 17:32
The https://github.com/systemaccounting/mxfactorial/pull/22/files pull request contains changes to /app.js, which is a file that belongs to the 'Bookshelf' boilerplate app from Google (along with the /books & /views directories). The root file for mxfactorial is /main.js.
Since the code in /app.js will be removed, did you intend these changes for /main.js? Also, since the npm start script in package.json invokes node main.js, how did your testing succeed if your code was added to app.js?
Max Funk
@mxfactorial
Jun 04 2016 17:54
Updated https://github.com/systemaccounting/mxfactorial/wiki/Code-Delivery-Workflow (step 11) with explanation of why builds from pull requests from forked repositories fail.