These are chat archives for systemaccounting/mxfactorial

26th
Jun 2016
Krishnal
@krishnal
Jun 26 2016 05:31
Guys, Appreciate if anyone can help me to get out of this error. I am trying to run web client - Need to replace one api route from /users to /account (suggestion per @mxfactorial ) Screen Shot 2016-06-26 at 10.59.58 AM
Using node v0.12.14 and npm 2.15.1
Max Funk
@mxfactorial
Jun 26 2016 06:01
You ran npm install before bundling?
Krishnal
@krishnal
Jun 26 2016 11:39
yes i did it before build
Nguyen Ho Tay
@hotay
Jun 26 2016 12:45
Have you tried upgrade to npm v3.5.1?
Krishnal
@krishnal
Jun 26 2016 12:46
let me do it . have to update to 4.4 or 5 so npm ill get 3.5
man i may need one more help.
i refined users route to /account
Nguyen Ho Tay
@hotay
Jun 26 2016 12:47
Just 3.5.1
I'm not sure it will work on 4.4
Krishnal
@krishnal
Jun 26 2016 12:47
so i have to replace it in webclient too, i am trying my own if something pops up, i ill ask you to help
okay than i ill go for 3.5.1
Nguyen Ho Tay
@hotay
Jun 26 2016 12:48
Ok
Krishnal
@krishnal
Jun 26 2016 12:48
just writing a small change in api. i ill do these npm update after
Nguyen Ho Tay
@hotay
Jun 26 2016 12:48
I will be around
Krishnal
@krishnal
Jun 26 2016 12:48
thanks
Krishnal
@krishnal
Jun 26 2016 13:54
@hotay, i just changed my part and also changed in webclient
can you just brief me how create account works ? is it 100% working?
Nguyen Ho Tay
@hotay
Jun 26 2016 14:08
Ok let me try
Can I have the detail what you changed?
Support application/json ?
Krishnal
@krishnal
Jun 26 2016 14:16
no no. I just changed user_create to account_name and password_create to password in following file
app/actions/signUpActions.js
app/components/CreateAccountForms/sixthForm.js
app/containers/CreateAccountForms.js
also changed /users to /account in app/actions/signUpActions.js
nothing else
now i want to test it
Nguyen Ho Tay
@hotay
Jun 26 2016 14:19
You should wait @mxfactorial
He will test it for you
It's 7am at his end, you can create PR at this time
And I will review it for you
Krishnal
@krishnal
Jun 26 2016 14:21
sure thing. Just adding apidoc now and i ill give him a PR
Krishnal
@krishnal
Jun 26 2016 15:28
@mxfactorial I pushed my changes and gave you PR. I added apidoc
npm install apidoc -g
and than
apidoc -i account/ -o apidoc/
this will create document for account endpoint
i ill add more once you approve this initial doc work
Max Funk
@mxfactorial
Jun 26 2016 16:30
Thank you. Occupied until this evening, will test then. Adding documentation will wait until after the project switches to Firebase. No wish to continue until the project is using a database solution that doesn't lose property values, and is serviced by a reliable API. Will create those tasks and offer them to active members over the next couple days.