Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Sep 10 09:34
    takayahilton closed #195
  • Sep 10 09:34
    takayahilton opened #195
  • Sep 10 06:56
    takayahilton closed #37
  • Sep 10 06:56
    takayahilton opened #37
  • Jul 31 10:08
    JensRichnow opened #194
  • Jul 08 17:32

    gakuzzzz on play2.7

    play2.7 (compare)

  • Jul 08 17:30

    gakuzzzz on play2.7

    play2.7 (compare)

  • Jul 07 10:56

    gakuzzzz on play2.6

    temp (compare)

  • Jul 06 14:29

    gakuzzzz on play2.6

    temp commit (compare)

  • Jul 05 10:12

    gakuzzzz on play2.6

    Change withLoggedIn signature t… (compare)

  • May 11 18:45
    fdoumet commented #184
  • May 11 18:45
    fdoumet commented #184
  • Apr 13 18:03
    tokkiyaa closed #190
  • Aug 23 2018 12:19
    jAANUSZEK0700 opened #193
  • Jul 11 2018 20:56
    mycaule closed #181
  • Jul 02 2018 12:59
    philliptaylorpro opened #192
  • Jun 19 2018 14:58
    Enalmada commented #184
  • Jun 19 2018 07:14
    Enalmada commented #184
  • Jun 18 2018 01:33
    Enalmada commented #184
  • Jun 18 2018 01:32
    Enalmada commented #184
mhzajac
@mhzajac
Unless some brave soul can find another way to make it work.
nafg
@nafg
@mhzajac I would like to. Can you give me exact instructions what needs to be done?
mhzajac
@mhzajac
I don't know if it's theoretically possible with runtime DI. The main roadblock that I ran into is that AuthConfig contains three type aliases, which made it difficult to make that component (and basically all others) difficult to inject and runtime and also know about the correct types at compile time. Using a type parameter (same trick that play-silhouette uses) cut down on the required boilerplate, but I couldn't find a way to make it work without guice.
As I needed TypeLiteral bindings in the module.
It looks like play-silhouette only works with guice right now, too.
We opted not to use silhouette because it is massive and would require a decent amount of rework in our applications with the risk of it also becoming abandonware down the road. Porting play2-auth to work with guice was straightforward enough, but with some limitations to keep a similar API.
Confining ourselves to guice was a small sacrifice since Play seems to provide the most out-of-the-box support for it.
nafg
@nafg
@mhzajac I know silhouette does not require guice
Yes, most examples for it and play use guice
I think play is moving away from that though
It's very unidiomatic Scala, and really unnecessary
mhzajac
@mhzajac
Play attempts to provide an API that is DI framework agnostic, but I don't think they're "moving away from that". That was kind of the entire reason this library ceases to work in Play 2.6. To say a DI framework is unnecessary (if that's what you meant to say) though is very dismissive. I was resistant at first, but it has taken away many headaches from building and testing applications. .. but that's neither here nor there.
In any case, the alternatives are 1.) Figure out a way to get runtime DI to work without TypeLiteral, or 2.) provide components for compile-time DI.
nafg
@nafg
What I meant is, my understanding was they're moving away from the examples defaulting to guice
I'd like 2 ;)
mhzajac
@mhzajac
Right, they're trying to be DI framework agnostic, but guice provides more features than other DI frameworks.
and unfortunately I needed one of them.
nafg
@nafg
I like play2-auth and compile-time DI (a.k.a. plain old constructor parameters), so if I can add support for that I'd like to
mhzajac
@mhzajac
I'm willing to investigate (2) a little more if I have time, but my current implementation is working fairly smoothly for me, and requires few changes to migrate existing applications.
I've never used compile-time DI as recommended by the Play docs as I've always felt they've given it significantly less attention than the runtime DI docs.
nafg
@nafg
Agreed
nafg
@nafg
@mhzajac do you want me to look into it? I would be happy to but I might need some more pointers
mhzajac
@mhzajac
If you want to. I don't know what direction to take it in without spending some time looking, but I might be able to answer questions about the current architecture since I've gone through the library code inside and out at this point.
Alexander
@XLPI
sorry? say me please? this module supply Oauth2 implimentation?
CHIRAG SINGHAL
@chirag-singhal
@all Does t2v provides two factor authentication ?
Nilesh Gupta
@n1gupta_twitter
I am upgrading play framework from 2.3.9 to 2.7.3 . I see there is no official version of t2v/play2-auth which supports play 2.7.3 which is dependency injection based . There are couple fork i can see but I am not sure how reliable they are to use .
Nilesh Gupta
@n1gupta_twitter
There is feature branch play2.7 by @gakuzzzz . How long it will be taking to merge in master ?
t2v/play2-auth@b09a163 when will it ready to use with play 2.7.* ?
Volodymyr Lubenchenko
@lvn2000

Hi all,

I have question regarding action in controller :
in version 0.14.2 there is AsyncAuth for making Action with authentication. But, in version play-2.7.x-auth-0.15-RC1 that I'm using now, AsyncAuth is nor exists.
I don't understand - how I need implement action ?
Thank you.