Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Mar 12 2019 17:44

    tbranyen on master

    chore: remove link to sketchy "… Update README.md Merge pull request #508 from wa… (compare)

  • Mar 12 2019 17:44
    tbranyen closed #508
  • Mar 12 2019 17:44
    tbranyen commented #508
  • Mar 12 2019 16:56
    wabreisch synchronize #508
  • Mar 12 2019 16:27
    wabreisch commented #508
  • Mar 12 2019 16:26
    wabreisch commented #508
  • Mar 12 2019 16:25
    wabreisch opened #508
  • Sep 19 2018 16:53
    tbranyen closed #502
  • Sep 19 2018 16:53
    tbranyen closed #409
  • Sep 19 2018 16:53
    tbranyen closed #386
  • Sep 19 2018 16:53
    tbranyen closed #379
  • Aug 01 2018 00:43

    tbranyen on master

    No longer maintained (compare)

  • Jul 19 2018 00:34
    ansonlouis commented #507
  • Jul 19 2018 00:27
    atomictag commented #507
  • Jul 19 2018 00:18
    ansonlouis commented #507
  • Jul 19 2018 00:00
    atomictag commented #507
  • Jul 18 2018 23:59
    atomictag commented #507
  • Jul 18 2018 23:26
    ansonlouis commented #507
  • Jul 18 2018 23:19
    atomictag commented #507
  • Jul 18 2018 23:18
    atomictag commented #507
Tim Branyen
@tbranyen
i don't get how that's happening
arathi-sreekumar
@arathi-sreekumar
because the $el.parent() returns '.p13n-dd-menu'
element
so is the dom broken?
as in link to the dom
Tim Branyen
@tbranyen
Could be, but without being able to debug it myself, I can't say for certain
arathi-sreekumar
@arathi-sreekumar
I guess thats true
I will try the code
that completely broke
didnt work at all
Tim Branyen
@tbranyen
well shit
too much is going on then
arathi-sreekumar
@arathi-sreekumar
this.setViews({
            '.p13n-dd-login': new LoginView(this.viewOpts()),
            '.p13n-dd-register': new RegisterView(this.viewOpts({
                additionalFields: this.options.additionalFields,
                permissions: this.options.permissions
            }))
        });

        this.$('.p13n-dd-menu').append(new MenuView(this.viewOpts({
            itemsLink: this.options.itemsLink,
            searchesLink: this.options.searchesLink,
            accountLink: this.options.accountLink,
            items: this.options.items,
            searches: this.options.searches,
            fname: this.options.app.account.get('fname'),
            lname: this.options.app.account.get('lname')
        })).$el)
thats what I tried
Tim Branyen
@tbranyen
yup
that should be identical to setViews
like nearly identical
unless something is doing getViews somewhere else
i'm guessing that app has a lot more going on
arathi-sreekumar
@arathi-sreekumar
i am still on the old version though
because my upgrade kinda made everything to stop working
so had to revert
Tim Branyen
@tbranyen
right that's why i linked the upgrade guide, you'd have to migrate code
probably wouldn't be easy
arathi-sreekumar
@arathi-sreekumar
hmmm
I will have to see if I can migrate, since this is one among the many projects I am sharing time on as well
and tend to get pulled out
:(
Tim Branyen
@tbranyen
that sucks
arathi-sreekumar
@arathi-sreekumar
I did want to upgrade, but might not have enough time
I'll give it another go
but I have to upgrade backbone.js as well
from 1.0.0 to 1.2.1
arathi-sreekumar
@arathi-sreekumar
is 1.2.1 the backbone version it depends on?
arathi-sreekumar
@arathi-sreekumar
Ok, will have to park it, I tried, seems like backbone is way out of date
so I would have to update backbone and literally rewrite a lot of the code across multiple files :(
I might just revert to one id and keep that as solution for now
thanks for the time and effort in trying to help me out
:)
Simen Bekkhus
@SimenB
Has anyone had any luck passing the promise from render().promise() to bluebird (Promise.resolve(view.render().promise()))? It crashes the site for me...
Simen Bekkhus
@SimenB
created #483 for it
Tim Branyen
@tbranyen
@SimenB hrm, i hate to say this, but i feel like what you did may be overkill. what if we just did:
// Proxy `then` for easier invocation.
then: function(success, failure) {
  return this.promise().then(success, failure);
},
Simen Bekkhus
@SimenB
@tbranyen If that works, even better! I'll test it out :smile:
Simen Bekkhus
@SimenB
Doesn't work... I'll take the discussion in the issue
Tim Branyen
@tbranyen
How is that possible though?
that's valid promise syntax
Oh, wait it's not then related is it? It's the promise function that's the culprit
urgh, this is a tough one
foligny
@foligny
Hi !
I'm trying to find out when all the child views have rendered.