Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Apr 03 2020 11:08
    ADepic commented #90
  • Jan 20 2020 11:32
    tcarlsen commented #92
  • Jan 18 2020 10:44
    pensierinmusica closed #92
  • Jan 18 2020 10:44
    pensierinmusica commented #92
  • Jan 13 2020 12:02
    tcarlsen commented #92
  • Jan 13 2020 11:59
    pensierinmusica opened #92
  • Jan 13 2020 11:45
    pensierinmusica commented on 529dcb5
  • Dec 01 2019 04:54
    Brolly0204 opened #91
  • Nov 18 2019 14:37
    tcarlsen labeled #71
  • Nov 18 2019 14:36
    tcarlsen labeled #88
  • Nov 18 2019 14:35
    tcarlsen closed #87
  • Nov 18 2019 14:35
    tcarlsen commented #87
  • Nov 18 2019 14:34
    tcarlsen closed #86
  • Nov 18 2019 14:33
    tcarlsen closed #77
  • Nov 18 2019 14:31
    tcarlsen commented #90
  • Nov 18 2019 14:31

    tcarlsen on 1.3.1

    (compare)

  • Nov 18 2019 14:31

    tcarlsen on master

    Release 1.3.1 (compare)

  • Nov 18 2019 14:26

    tcarlsen on master

    Update MessagePanelView.js Update MessagePanelView.js Update MessagePanelView.js and 1 more (compare)

  • Nov 18 2019 14:26
    tcarlsen closed #90
  • Nov 11 2019 04:27
    neur0hak commented #90
Thomas Carlsen
@tcarlsen
so just merge that to master and I will release 1.1.3
Joe Fitzgerald
@joefitzgerald
still not clear
(1) i come up with a new feature
(2) i create feature branch ("add-new-feature") and push it
Thomas Carlsen
@tcarlsen
I like the master to be the source of the released (npm) version
Joe Fitzgerald
@joefitzgerald
(3) i create PR from "add-new-feature" > "1.2.0"
(4) who closes PR? after what time?
Thomas Carlsen
@tcarlsen
and you merge then tested
Joe Fitzgerald
@joefitzgerald
(5) i create PR from "1.2.0" > "master" for release
(6) you merge PR and release npm update
(4) is what i am not clear on
Thomas Carlsen
@tcarlsen
I merge (no testing you allready done) and I release
Joe Fitzgerald
@joefitzgerald
ok, i can give it a go that way
will let you know if anthing gets in my way
i will probably get a bit more aggressive than that if something sits around for 2 weeks with no comment?
Thomas Carlsen
@tcarlsen
I release to npm the you give me a milestone branch to master pt
okay?
I release to npm the you give me a milestone branch to master pt
Am I odd?
I will comment .. The reason I delay things is becouse I didt had time to test
so I promise to comment If you do the testing
Joe Fitzgerald
@joefitzgerald
got it
Thomas Carlsen
@tcarlsen
I like stucture… sry
Joe Fitzgerald
@joefitzgerald
structure is good, i'm fine with it, it's your project
Thomas Carlsen
@tcarlsen
cool and thanks for doing this
was sad to see that I lost my time and amp could die :(
Joe Fitzgerald
@joefitzgerald
fun fact: mary, princess of denmark went to my elementary school in tasmania, australia :wink:
a totally random fact, but i saw you are danish
Thomas Carlsen
@tcarlsen
Haha that fun
I like random
Joe Fitzgerald
@joefitzgerald
i dont live in australia anymore (denver, USA)
Thomas Carlsen
@tcarlsen
Job? Education???
Joe Fitzgerald
@joefitzgerald
yeah, i work here
Joe Fitzgerald
@joefitzgerald
@tcarlsen pushed a final change to remove the last deprecation
Thomas Carlsen
@tcarlsen
1.1.3 is live
Joe Fitzgerald
@joefitzgerald
@tcarlsen: we need a new version based on #52
please review
Thomas Carlsen
@tcarlsen
done and done!
Thomas Carlsen
@tcarlsen
@Glavin001 you there?
Thomas Carlsen
@tcarlsen
what was the reson to remove the pnae feature??
tcarlsen/atom-message-panel@3d88f4d
Joe Fitzgerald
@joefitzgerald
We don't dock to a pane anymore - we dock to a panel
Thomas Carlsen
@tcarlsen
okay :D
having time agian
so was updating all my packeges to the new amp
Anmol Desai
@arrayoutofbounds
Hi, I am using atom message panel for research project at university. Just wondering if there is a way to allow the panel to take input in?
Thomas Carlsen
@tcarlsen
Not sure want you mean?
Like from the package user inside atom?
Joe Fitzgerald
@joefitzgerald
@arrayoutofbounds use an mini-editor or editor instead of a message panel
derwentx
@derwentx
Hey, is anyone around? I'd like to write a fix for tcarlsen/atom-message-panel#79 and I'm looking for some advice, thanks.
Thomas Carlsen
@tcarlsen
Your more then welcome. As you can see I'm at a stop in developing of this package. To much work and no free space
derwentx
@derwentx
I totally understand :P but if I submitted a PR would you have a look at it?
Thomas Carlsen
@tcarlsen
yes. and I did answer on Github ;)