Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Jun 18 12:45
    bhack commented #569
  • Jun 18 12:28
    bhack commented #569
  • Jun 18 12:28
    bhack commented #569
  • Jun 18 01:09
    digantamisra98 commented #569
  • Jun 17 09:59
    bhack commented #2500
  • Jun 17 05:17
    tetsuyasu commented #2503
  • Jun 17 01:52
    tetsuyasu commented #2503
  • Jun 17 01:48
    tetsuyasu edited #2504
  • Jun 17 01:46
    tetsuyasu edited #2504
  • Jun 17 01:37
    tetsuyasu commented #2503
  • Jun 17 01:37
    tetsuyasu commented #2503
  • Jun 17 00:58
    bhack commented #2503
  • Jun 17 00:57
    bhack review_requested #2504
  • Jun 17 00:55
    tetsuyasu commented #2503
  • Jun 16 23:47
    tetsuyasu synchronize #2504
  • Jun 16 08:19
    tetsuyasu ready_for_review #2504
  • Jun 16 08:17
    tetsuyasu commented on ff1ae8a
  • Jun 16 08:14
    tetsuyasu converted_to_draft #2504
  • Jun 16 08:01
    google-cla[bot] labeled #2504
  • Jun 16 08:01
    boring-cyborg[bot] labeled #2504
bhack
@bhack
@abhinavsp0730 I don't see the error of the single test but probably it could be related to tensorflow/addons#1909 that it is still not merged
Try to run install_so_files.sh before running test and again when you modify c++ files of customs ops

Hey, I was wondering how are we going to avoid overlapping contributions with TF models? Are TF Addons contributions supposed to be different than TF models?

When you open an issue in github for a feature request for the model that you want to add in TFA then one of the core maintainers of TFA will label the issue as ecosystem-review. Then from google someone will review whether the model is in their roadmap or not if not then it'll may approved as a feature PR

More in detail see this specific comment with the next one https://github.com/tensorflow/addons/issues/2201#issuecomment-757019509

Abhinav Prakash
@abhinavsp0730
Thanks bhack will do.
Harshith MohanKumar
@Harsh188
Thanks bhack
Nanubala Gnana Sai
@jonpsy
Hi
So I've been working on addig a new metric and the pre commit hook is taking way too long
And it's showing errors which aren't even related to my files, any insights? Thanks
Sean Morgan
@seanpmorgan
Push a PR and you can use the CI runners to complete the tests. Then we can also look at the errors if they are indeed not related to your changes
Nanubala Gnana Sai
@jonpsy
I could, but then that would be wasting the CI's cycle wouldn't it?
Sean Morgan
@seanpmorgan
It’s free
Nanubala Gnana Sai
@jonpsy
Can't I just run flake8 and black checks and then push? That should be enough right?
Sean Morgan
@seanpmorgan
Yeah please do. The precommit also runs CI tests
You’ll need them to pass before the PR can merge regardless
Nanubala Gnana Sai
@jonpsy
Indeed
I've made a PR, would you be interested in reviewing?
Although I'm not sure if that file lies in your subdomain
Sean Morgan
@seanpmorgan
Yeah I’ve been swamped at work so have very little time to work on Addons will try my best
Nanubala Gnana Sai
@jonpsy
Thanks, appreciate it!
Nanubala Gnana Sai
@jonpsy
Hey, so I'm working on Matthew metric and I strongly believe the Multiclass implementation is wrong. More on #2339.
Matthews loss*
Suraj Upadhyay
@SurajUpadhyay0_twitter
Hii, where can I find design document for Tensorflow ? I just want to make a sense of the codebase
Harshith MohanKumar
@Harsh188
Kind of unrelated to Addons, but I wanted to ask if there's a significant industry-level difference between AWS and GCP for building and deploying models onto the internet. Should I prefer one over the other?
After reading several articles, I've noticed that there are similar services in both ends but GCP seems to have better integrations with TF. However, if a model doesn't currently exist on TF would that advantage be lost? For example we are trying to implement and deploy PEGASUS and we aren't sure which route to go down.
Sean Morgan
@seanpmorgan
I work for AWS, so I try to avoid conversations like this when its associated with Addons. I'll keep it short and say that both are perfectly viable options.
Jason Zaman
@perfinion
I dont work for either so here are my two cents: underneath both AWS and GCP are regular intel or AMD cpus with nvidia gpus running linux. they are extremely similar to each other so use whichever one you want. the only recommendation i'd have it to use the optimized VM images, iirc AWS calls them "DeepLearningAMIs" and GCP has "deep learning optimized images" and they both put a lot of work in to make sure TensorFlow is optimized (as opposed to using eg generic ubuntu)
Sean Morgan
@seanpmorgan
:thumbsup:
bhack
@bhack
More you go down to the bare metal more they are similar (if you exclude TPU).. more you are using managed services more they diverge
Harshith MohanKumar
@Harsh188
Thanks for the responses!
Nanubala Gnana Sai
@jonpsy
From what I understand, instead of letting users manually use the command export TF_ADDONS_PY_OPS=1, we would wrap it under a function?
Basically this, in options.py?
Nanubala Gnana Sai
@jonpsy
sorry, it was meant for @windqaq
Nanubala Gnana Sai
@jonpsy
hey @bhack , i wanted to discuss something. Lemme know if you're free
bhack
@bhack

hey @bhack , i wanted to discuss something. Lemme know if you're free

Hi, what is the topic?

Nanubala Gnana Sai
@jonpsy
Two things,
a) The LookAhead module, I thought of a stand-in solution by overriding __setattr__ of the LookAhead to set learning rate of the internal optimizer. Maybe we could do that for all the wrappers by introducing a Mixin of a sort and letting the wrappers inherit that?
b)The Matthew correlation implementation is wrong imo, there've been some discussion and I've made a PR. Might you be interested? tensorflow/addons#2406
good day ! :)
Harshith MohanKumar
@Harsh188

Hey @seanpmorgan @bhack,

As I was going through the "TensorFlow Project Ideas" document for google summer of code when I noticed that TF Addons was listed under the propose your own idea section.

I was wondering what projects/tasks I could propose that would be beneficial for TFAddons. I would love to hear your suggestions on possible projects that I could work on. I remember @seanpmorgan talking about custom ops during the last SIG meeting and how it could be an interesting task for a university student which fits my interests.

So far I have only made minor changes/fixes, however, I would be more than happy to tackle a challenging task :)

kartikey rawat
@carrycooldude
Hello everyone, I am Kartikey Rawat and I am Open Source and ML Enthusiast and I am really want to contribute in tensorflow.js and even I am also advocating tensorflow.js through my speaker session love to be a part of this community
Sean Morgan
@seanpmorgan
Hey @Harsh188, apologies for the slow answer. Unfortunetely I won’t have time right now to be a mentor. If there is any one else that is willing to sponsor a project though that may work. The custom op idea is not really enough of a GSoC project in as far as it’s more maintainence and reviewing code than anything
Not to say there couldn’t be a way to incorporate that into a project but nothing is coming to mind
Harshith MohanKumar
@Harsh188
Thanks for the reply! By any chance would you know any other members in TFAddons who would be willing to mentor for GSoC?
KiranKhanna721
@KiranKhanna721
Hello everyone , I am Kiran Khanna .
bhack
@bhack
Hi
Abhinav Prakash
@abhinavsp0730
Hi, @bhack @seanpmorgan do you know How to reach the mentors of this year's GSOC 2021.
Last year I've applied for GSOC but I didn't hear anything from TF team . It was written that kindly mail your drafted proposal so that we can assign you the Mentor to refine your proposal. But unluckily I've mailed them but I didn't got any reply. So, this year I want to discuss about my project Ideas with mentor. So that I'll include only those things which are relevant to TF ecosystem.
bhack
@bhack

Last year I've applied for GSOC but I didn't hear anything from TF team . It was written that kindly mail your drafted proposal so that we can assign you the Mentor to refine your proposal. But unluckily I've mailed them but I didn't got any reply. So, this year I want to discuss about my project Ideas with mentor. So that I'll include only those things which are relevant to TF ecosystem.

You can try to post in https://groups.google.com/a/tensorflow.org/g/developers

Sean Morgan
@seanpmorgan
Hmmm not able to join the meeting...
image.png
Is it just me?
Rehan Guha
@rehanguha

@seanpmorgan It will be great if we have a list of checks(all possible CI checks) with required package versions used in CI available in the repo for development purpose.
This will reduce the commit counts.
Eg.

black --check addons
flake8 addons

I am not sure whether it is already in place or not. :-)