tensorflow/sig-addons

where SIG Addons talks

Rehan Guha

@rehanguha

@seanpmorgan It will be great if we have a list of checks(all possible CI checks) with required package versions used in CI available in the repo for development purpose.
This will reduce the commit counts.
Eg.

black --check addons
flake8 addons

I am not sure whether it is already in place or not. :-)

bhack

@bhack

Is there the meeting?

I cannot access

@seanpmorgan ?

vulkomilev

@vulkomilev

does somebody needs a help on some issue/project ?

bhack

@bhack

@vulkomilev We are going to clean up open issues and PRs in the next days

vulkomilev

@vulkomilev

okay if you have something specific in mind let me know

vulkomilev

@vulkomilev

@bhack can you assist me about tensorflow/addons#2593 I have found the solution to the problem and I just need to merge it

I don't have a lot of experience in this

bhack

@bhack

@vulkomilev Ok the First step Is:

Do you have a test or can you extend an existing test to cover this case?

vulkomilev

@vulkomilev

Sorry for the late answer but the modification is for Triangular2CyclicalLearningRate and I am not aware of any test for this class

bhack

@bhack

Test https://github.com/tensorflow/addons/blob/e83e71cf07f65773d0f3ba02b6de66ec3b190db7/tensorflow_addons/optimizers/tests/cyclical_learning_rate_test.py#L57

vulkomilev

@vulkomilev

okay since he have test what is the next thing to do ?

to test it and after that?

bhack

@bhack

I think that we Need or to modify or to add a new test case with a PR. If tests are not failing now It mean that we don't have enoug test coverage for that case

Then you could add commit on that PR to let the new test to pass

vulkomilev

@vulkomilev

okay

Philip May

@PhilipMay

Can anybody please recommend a good consumer GPU for ML tasks that is available on the market? For about 1200€ ?

vulkomilev

@vulkomilev

3080 but it was available of this price along time ago.Basically anything from nvidia

vulkomilev

@vulkomilev

when I try to run the tests I get this

==================================================================================================================================================================================================== short test summary info ====================================================================================================================================================================================================
XFAIL tensorflow_addons/optimizers/tests/conditional_gradient_test.py::test_minimize_sparse_resource_variable_frobenius[gpu-float16]
reason: See tensorflow/addons#347
FAILED tensorflow_addons/seq2seq/tests/beam_search_ops_test.py::test_bad_parent_values_on_gpu[custom_ops-gpu] - tensorflow.python.framework.errors_impl.InvalidArgumentError: Saw invalid parent id -1 at (batch, time, beam) == (0, 0, 1) [Op:Addons>GatherTree]
============================================================================================================================================================================ 1 failed, 199 passed, 2336 deselected, 1 xfailed, 8 warnings in 21.78s =============================================================================================================================================================================

Exception ignored in: <function Pool.__del__ at 0x7ff3c3540040>
Traceback (most recent call last):
  File "/home/x000ff4/anaconda3/lib/python3.8/multiprocessing/pool.py", line 268, in __del__
    self._change_notifier.put(None)
  File "/home/x000ff4/anaconda3/lib/python3.8/multiprocessing/queues.py", line 368, in put
    self._writer.send_bytes(obj)
  File "/home/x000ff4/anaconda3/lib/python3.8/multiprocessing/connection.py", line 200, in send_bytes
    self._send_bytes(m[offset:offset + size])
  File "/home/x000ff4/anaconda3/lib/python3.8/multiprocessing/connection.py", line 411, in _send_bytes
    self._send(header + buf)
  File "/home/x000ff4/anaconda3/lib/python3.8/multiprocessing/connection.py", line 368, in _send
    n = write(self._handle, buf)
OSError: [Errno 9] Bad file descriptor
Exception ignored in: <function Pool.__del__ at 0x7ff3c3540040>
Traceback (most recent call last):
  File "/home/x000ff4/anaconda3/lib/python3.8/multiprocessing/pool.py", line 268, in __del__
    self._change_notifier.put(None)
  File "/home/x000ff4/anaconda3/lib/python3.8/multiprocessing/queues.py", line 368, in put
    self._writer.send_bytes(obj)
  File "/home/x000ff4/anaconda3/lib/python3.8/multiprocessing/connection.py", line 200, in send_bytes
    self._send_bytes(m[offset:offset + size])
  File "/home/x000ff4/anaconda3/lib/python3.8/multiprocessing/connection.py", line 411, in _send_bytes
    self._send(header + buf)
  File "/home/x000ff4/anaconda3/lib/python3.8/multiprocessing/connection.py", line 368, in _send
    n = write(self._handle, buf)
OSError: [Errno 9] Bad file descriptor

bhack

@bhack

What TF/TF Addons version?

David Lin

@kdlin

Is there a conda package for TF-addons v0.14.0 or v0.15.0? I have TF=2.6.0.

bhack

@bhack

@kdlin https://github.com/tensorflow/addons/issues/201#issuecomment-996140688

David Lin

@kdlin

@bhack Thanks for the link. It does not look new conda version will come out soon. Maybe I should downgrade my TF to 2.5.0? Then I can use the v0.13.0 from esri. Thought?

vulkomilev

@vulkomilev

@bhack tf addons version nightly tensorflow -version 2.5.1 python version 3.8.1

sorry for the delay gitter was not working for me for some reason

bhack

@bhack

@vulkomilev Have you tried to install it in a venv?

vulkomilev

@vulkomilev

okay I will try

NeedMoreData

@Aditya-Jha2002

Hey everyone. I am Aditya Jha, trying to get more involved in Opensource and Tensorflow Community. I am a Google Developer Student Club Lead, as well as a Google Explore ML with Crowdsource Facilitator. Really enjoying my time talking and spreading knowledge regarding tensorflow. I have also taken up the following issue #2665. Looking forward to contributing to SIG addons :)

Regarding the issue #2665, do I need to make a custom implementation of one hot encoding, or importing it from somewhere else would work?

Where communities thrive

People

Repo info

Activity