Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 11:32
    renovate[bot] edited #239
  • 05:52
    renovate[bot] edited #239
  • 03:55
    renovate[bot] edited #239
  • 00:49
    renovate[bot] edited #239
  • Aug 07 22:46
    renovate[bot] edited #239
  • Aug 07 21:04
    renovate[bot] edited #239
  • Aug 07 18:34
    renovate[bot] edited #239
  • Aug 07 14:13
    renovate[bot] edited #239
  • Aug 07 11:29
    renovate[bot] edited #239
  • Aug 07 06:04
    renovate[bot] edited #239
  • Aug 07 03:56
    renovate[bot] edited #239
  • Aug 07 01:16
    renovate[bot] edited #239
  • Aug 06 23:00
    renovate[bot] edited #239
  • Aug 06 20:37
    renovate[bot] edited #239
  • Aug 06 18:18
    renovate[bot] edited #239
  • Aug 06 15:35
    renovate[bot] edited #239
  • Aug 06 13:49
    renovate[bot] edited #239
  • Aug 06 10:28
  • Aug 06 10:28

    nukosuke on indirect

    (compare)

  • Aug 06 10:28

    nukosuke on master

    Update module go to 1.19 (#243)… (compare)

Andy McCall
@tamccall
it might make sense to call it filepath since filename is an actual field in the api response
nukosuke
@nukosuke
OK, thank you for your PR. I’ll check it later.
nukosuke
@nukosuke
I'm thinking of finalizing these milestones for the next release.
go-zendesk v0.2.0 milestone
terraform-provider-zendesk v0.0.0 milestone
nukosuke
@nukosuke
Zendesk approved the sponsored account request :tada:
I forwarded the message to your private chat and invited you as admin of the instance.
Please check it when you have time.
Andy McCall
@tamccall
i got into the account
as far as the milestones go i would say add in a read and delete story for zendesk attachments
otherwise i think that looks good.
i was able to get into the zendesk accout
Andy McCall
@tamccall
should we look into adding this into the build before we call our terraform provider in v0.0.0
Andy McCall
@tamccall
i'll write up a story for it in any case. Let me know what you think
nukosuke
@nukosuke
yeah, I agree. Then we would support CRUD operations for these resources for the next release.
  • ticket field
  • ticket form
  • group
  • brand
  • attachment (except update)
Let me know if there is anything missing.
Andy McCall
@tamccall
maybe get the rest of the crud operations for trigger implemented since that resource is already exposed
nukosuke
@nukosuke
Oh, it also should be completed.
Andy McCall
@tamccall
i also added this issue for whenever we make the 0.0.0 release nukosuke/terraform-provider-zendesk#65
nukosuke
@nukosuke
OK, it sounds great. Thanks.
Andy McCall
@tamccall
for this acceptance test do you have any concerns about adding an api token to our build using https://docs.travis-ci.com/user/encryption-keys/
nukosuke
@nukosuke
No problem. But we should restrict to particular branch for it, or it would send too many requests to Zendesk API.
Andy McCall
@tamccall
you don't think we should just run the acceptance test for any pr?
also is there any doc you could point me to on that front
nukosuke
@nukosuke
hmm
disable them for pull requests entirely
I think it better because it's hard to consider the situation when multiple PRs are sent at the same time.
nukosuke
@nukosuke
I respect your opinion. If you are already working on this issue, you could go on.
I don't think that the concern would become a problem soon.
Andy McCall
@tamccall
im going to try and get the acceptance tests to only run for master
nukosuke
@nukosuke
Noted with thanks.
Andy McCall
@tamccall
we might need to figure out a way to rate limit the client for these acceptance tests. I was really burning through our API limits and i only wrote tests for 1 file.
Andy McCall
@tamccall
on a more positive note i found some bugs when i was testing
nukosuke
@nukosuke
OK, would you create a issue?
Andy McCall
@tamccall
ok i have some acceptance tests written for the ticket field resource if you want to review that.
still haven't updated the build bc i have been having some trouble getting secrets to work like i want them to.
nukosuke
@nukosuke
It looks fine.
Andy McCall
@tamccall
ok finally got the build working
now i think the acceptance tests won't run for prs
nukosuke
@nukosuke
Thank you for your effort.
Could I merge the PR and run acceptance tests?
Andy McCall
@tamccall
i merged it
it works!
nukosuke
@nukosuke
Yes!! :tada:
Andy McCall
@tamccall
you can see it calling the zendesk api too
well i guess i can't upload pictures
but you can look at the api activity here: https://d3v-terraform-provider.zendesk.com/agent/admin/api/activity
also got the test coverage up a bit https://coveralls.io/builds/22267396
nukosuke
@nukosuke
Awesome. I could confirm it.
nukosuke
@nukosuke
rate limit, 400 requests per minute seems to be enough for testing.
Andy McCall
@tamccall
yeah we can also just continue to monitor it until we see it creeping up close to the limit