terraform-provider-zendesk/Lobby

General topic about Terraform & Zendesk

Andy McCall

@tamccall

otherwise i think that looks good.

i was able to get into the zendesk accout

should we look into adding this into the build before we call our terraform provider in v0.0.0

https://www.terraform.io/docs/extend/testing/acceptance-tests/index.html

Andy McCall

@tamccall

i'll write up a story for it in any case. Let me know what you think

nukosuke

@nukosuke

yeah, I agree. Then we would support CRUD operations for these resources for the next release.

ticket field
ticket form
group
brand
attachment (except update)

Let me know if there is anything missing.

Andy McCall

@tamccall

maybe get the rest of the crud operations for trigger implemented since that resource is already exposed

nukosuke

@nukosuke

Oh, it also should be completed.

Again. This is the revised version.
https://github.com/nukosuke/terraform-provider-zendesk/milestone/3

Andy McCall

@tamccall

i also added this issue for whenever we make the 0.0.0 release nukosuke/terraform-provider-zendesk#65

nukosuke

@nukosuke

OK, it sounds great. Thanks.

Andy McCall

@tamccall

for this acceptance test do you have any concerns about adding an api token to our build using https://docs.travis-ci.com/user/encryption-keys/

nukosuke

@nukosuke

No problem. But we should restrict to particular branch for it, or it would send too many requests to Zendesk API.

Andy McCall

@tamccall

you don't think we should just run the acceptance test for any pr?

also is there any doc you could point me to on that front

i guess there is this concern https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions

nukosuke

@nukosuke

hmm

disable them for pull requests entirely

I think it better because it's hard to consider the situation when multiple PRs are sent at the same time.

nukosuke

@nukosuke

I respect your opinion. If you are already working on this issue, you could go on.
I don't think that the concern would become a problem soon.

Andy McCall

@tamccall

im going to try and get the acceptance tests to only run for master

nukosuke

@nukosuke

Noted with thanks.

Andy McCall

@tamccall

we might need to figure out a way to rate limit the client for these acceptance tests. I was really burning through our API limits and i only wrote tests for 1 file.

Andy McCall

@tamccall

on a more positive note i found some bugs when i was testing

nukosuke

@nukosuke

OK, would you create a issue?

Andy McCall

@tamccall

ok i have some acceptance tests written for the ticket field resource if you want to review that.

still haven't updated the build bc i have been having some trouble getting secrets to work like i want them to.

nukosuke

@nukosuke

It looks fine.

Andy McCall

@tamccall

ok finally got the build working

now i think the acceptance tests won't run for prs

nukosuke

@nukosuke

Thank you for your effort.

Could I merge the PR and run acceptance tests?

Andy McCall

@tamccall

i merged it

https://travis-ci.org/nukosuke/terraform-provider-zendesk/jobs/508368138

it works!

nukosuke

@nukosuke

Yes!! :tada:

Andy McCall

@tamccall

you can see it calling the zendesk api too

well i guess i can't upload pictures

but you can look at the api activity here: https://d3v-terraform-provider.zendesk.com/agent/admin/api/activity

also got the test coverage up a bit https://coveralls.io/builds/22267396

nukosuke

@nukosuke

Awesome. I could confirm it.

nukosuke

@nukosuke

rate limit, 400 requests per minute seems to be enough for testing.

Andy McCall

@tamccall

yeah we can also just continue to monitor it until we see it creeping up close to the limit

nukosuke

@nukosuke

I’m working on adding support for brand and group to resources.

Andy McCall

@tamccall

i've starting on uplifting the client with the rest of the methods for forms

Andy McCall

@tamccall

i don't think i am going to be able to write an acceptance test for the ticket forms at least until our trial period is over

keep getting the following error when running my test.

{
            "title": "Forbidden",
            "message": "You do not have access to this page. Please contact the account owner of this help desk for further help."
          }
        }

and when i look in the admin console there is a message there saying that we need to upgrade to create ticket forms

Andy McCall

@tamccall

i'll just add a skip to the test that i wrote and file an issue to get it fixed

nukosuke

@nukosuke

trial period will be expired about one month later.

Where communities thrive

People

Repo info

Activity