terraform-provider-zendesk/Lobby

General topic about Terraform & Zendesk

nukosuke

@nukosuke

hmm

disable them for pull requests entirely

I think it better because it's hard to consider the situation when multiple PRs are sent at the same time.

nukosuke

@nukosuke

I respect your opinion. If you are already working on this issue, you could go on.
I don't think that the concern would become a problem soon.

Andy McCall

@tamccall

im going to try and get the acceptance tests to only run for master

nukosuke

@nukosuke

Noted with thanks.

Andy McCall

@tamccall

we might need to figure out a way to rate limit the client for these acceptance tests. I was really burning through our API limits and i only wrote tests for 1 file.

Andy McCall

@tamccall

on a more positive note i found some bugs when i was testing

nukosuke

@nukosuke

OK, would you create a issue?

Andy McCall

@tamccall

ok i have some acceptance tests written for the ticket field resource if you want to review that.

still haven't updated the build bc i have been having some trouble getting secrets to work like i want them to.

nukosuke

@nukosuke

It looks fine.

Andy McCall

@tamccall

ok finally got the build working

now i think the acceptance tests won't run for prs

nukosuke

@nukosuke

Thank you for your effort.

Could I merge the PR and run acceptance tests?

Andy McCall

@tamccall

i merged it

https://travis-ci.org/nukosuke/terraform-provider-zendesk/jobs/508368138

it works!

nukosuke

@nukosuke

Yes!! :tada:

Andy McCall

@tamccall

you can see it calling the zendesk api too

well i guess i can't upload pictures

but you can look at the api activity here: https://d3v-terraform-provider.zendesk.com/agent/admin/api/activity

also got the test coverage up a bit https://coveralls.io/builds/22267396

nukosuke

@nukosuke

Awesome. I could confirm it.

nukosuke

@nukosuke

rate limit, 400 requests per minute seems to be enough for testing.

Andy McCall

@tamccall

yeah we can also just continue to monitor it until we see it creeping up close to the limit

nukosuke

@nukosuke

I’m working on adding support for brand and group to resources.

Andy McCall

@tamccall

i've starting on uplifting the client with the rest of the methods for forms

Andy McCall

@tamccall

i don't think i am going to be able to write an acceptance test for the ticket forms at least until our trial period is over

keep getting the following error when running my test.

{
            "title": "Forbidden",
            "message": "You do not have access to this page. Please contact the account owner of this help desk for further help."
          }
        }

and when i look in the admin console there is a message there saying that we need to upgrade to create ticket forms

Andy McCall

@tamccall

i'll just add a skip to the test that i wrote and file an issue to get it fixed

nukosuke

@nukosuke

trial period will be expired about one month later.

i’m wondering if we could test form feature manually

nukosuke

@nukosuke

if all the features are completed before that time

Andy McCall

@tamccall

i think we can test it manually with a different account i just don't want to check in a test that will break the build

Andy McCall

@tamccall

do you care if i just push a change to you r branch i think i have the fix coded up locally for those tests

Andy McCall

@tamccall

this is the change

https://github.com/nukosuke/terraform-provider-zendesk/pull/74#discussion_r267950449

nukosuke

@nukosuke

Sorry for late reply

nukosuke

@nukosuke

You could push changes to my repository for pull requests if you'd like.

nukosuke

@nukosuke

But I don't recommend pushing to same branch without merge. It would confuse review process.

Andy McCall

@tamccall

no worries that is why i asked first

nukosuke

@nukosuke

nukosuke/terraform-provider-zendesk#76

This problem still occurs

nukosuke

@nukosuke

I submitted go-zendesk PR of trigger support. nukosuke/go-zendesk#93

nukosuke

@nukosuke

go-zendesk v0.2.0 has been released :tada:
Thank you for your many contributions.

Andy McCall

@tamccall

yeah im seeing an issue with the ticket forms looks like it will always think it needs to update bc the form will have unspecified ticket fields in the response body. The unspecified fields are the system fields.

trying to decide what is the best way to handle that

Andy McCall

@tamccall

i think i am going to try and create a datasource to import the system fields. Let me know if you have any issue with that

Where communities thrive

People

Repo info

Activity