Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Jan 21 12:28
    Coveralls nukosuke/go-zendesk (master) 0%
  • Jan 21 12:28

    nukosuke on master

    Add support for go1.17 / drop g… Merge pull request #213 from nu… (compare)

  • Jan 21 12:28

    nukosuke on support-go1.17

    (compare)

  • Jan 21 12:28
    nukosuke closed #213
  • Jan 21 12:27
    nukosuke auto_merge_disabled #213
  • Jan 21 12:24
    nukosuke auto_merge_enabled #213
  • Jan 21 12:24
    Coveralls nukosuke/go-zendesk (support-go1.17) 0%
  • Jan 21 12:24
    nukosuke assigned #213
  • Jan 21 12:23
    nukosuke opened #213
  • Jan 21 12:23
    Coveralls nukosuke/go-zendesk (support-go1.17) 0%
  • Jan 21 12:22

    nukosuke on support-go1.17

    Add support for go1.17 / drop g… (compare)

  • Nov 28 2021 15:57
    SureshVytla edited #212
  • Nov 28 2021 15:49
    SureshVytla opened #212
  • Nov 27 2021 02:46
    pypypyo14 opened #221
  • Nov 27 2021 00:20
    pypypyo14 opened #211
  • Nov 17 2021 01:44
    nukosuke closed #174
  • Nov 16 2021 13:04
    nukosuke closed #175
  • Nov 05 2021 04:55
    Coveralls nukosuke/go-zendesk (refs/tags/v0.10.1) 0%
  • Nov 05 2021 04:55

    nukosuke on v0.10.1

    (compare)

  • Nov 05 2021 04:54
    Coveralls nukosuke/go-zendesk (master) 0%
Andy McCall
@tamccall
do you care if i just push a change to you r branch i think i have the fix coded up locally for those tests
Andy McCall
@tamccall
this is the change
nukosuke
@nukosuke
Sorry for late reply
nukosuke
@nukosuke
You could push changes to my repository for pull requests if you'd like.
nukosuke
@nukosuke
But I don't recommend pushing to same branch without merge. It would confuse review process.
Andy McCall
@tamccall
no worries that is why i asked first
This problem still occurs
nukosuke
@nukosuke
I submitted go-zendesk PR of trigger support. nukosuke/go-zendesk#93
nukosuke
@nukosuke
go-zendesk v0.2.0 has been released :tada:
Thank you for your many contributions.
Andy McCall
@tamccall
yeah im seeing an issue with the ticket forms looks like it will always think it needs to update bc the form will have unspecified ticket fields in the response body. The unspecified fields are the system fields.
trying to decide what is the best way to handle that
Andy McCall
@tamccall
i think i am going to try and create a datasource to import the system fields. Let me know if you have any issue with that
Andy McCall
@tamccall
got a pr up for that. had a few questions for you on it let me know what you think.
Andy McCall
@tamccall
attachment resource should be ready for review now.
nukosuke
@nukosuke
I merged it. thanks
Andy McCall
@tamccall

Zendesk approved the sponsored account request :tada:
I forwarded the message to your private chat and invited you as admin of the instance.
Please check it when you have time.

you know anything about us being able to make forms for our sponsored account

looks like we still cant
nukosuke
@nukosuke
Sorry for late reply. I'll check it.
nukosuke
@nukosuke
Hmm, It seems that the account has been expired. I’ll contact Zendesk support again. Thank you for your report.
Andy McCall
@tamccall
looks like our account is usable again and it seems that forms can be created again i am gonna start working on getting the form acceptance tests working.
nukosuke
@nukosuke
I replaced HoundCI to GolangCI. It seems better for golang project.
https://golangci.com/
nukosuke
@nukosuke
⟩ go get github.com/nukosuke/go-zendesk@master
go: errors parsing go.mod:
/Users/nukosuke/workspace/v0.3-test-project/go.mod:5: invalid module version "v0.3": no matching versions for query "v0.3"
nukosuke
@nukosuke
@tamccall
I got an error when import master branch of go-zendesk on go1.12.
Do you know how to import current master revision without v0.3.0 tag?
Andy McCall
@tamccall
i suppose this fixed that?
nukosuke
@nukosuke
Yeah, we should take these commits back when release v0.3.0
Andy McCall
@tamccall
how would we feel about making renovate run go mod tidy for the terraform provider?
nukosuke
@nukosuke
@tamccall It's what I wanted. Thank you!!
nukosuke
@nukosuke
Do you have DockerHub account?
GitHub integration did not connect you as a collaborator of the image repository. I will add your account so that you could access terraform-providee-zendesk dashboard if you’d like.
nukosuke
@nukosuke
nukosuke
@nukosuke
Andy McCall
@tamccall
hey i've been traveling over the past few days sorry for not answering
here is my docker hub account
nukosuke
@nukosuke
Thanks. I sent the invitation. But, I'm planning to migrate the image repository to GitHub packages in future.
Andy McCall
@tamccall
hey just wanted to let you know i merged nukosuke/go-zendesk#142
let me know if you want me to make a release for 0.4.2
nukosuke
@nukosuke
Thank you :+1:
I released v0.4.2 and created the v0.5.0 milestone.
Andy McCall
@tamccall
after your pr is merged for terraform 0.12 should we release 0.0.0 on the terraform provider? I believe we will have hit all the milestones we had previously set.
Andy McCall
@tamccall

Also i was looking at the target code in the zendesk client. I am wondering if we should do a little refactoring to it.

https://developer.zendesk.com/rest_api/docs/support/targets#json-format

there are a bunch of different targets that need various information. Currently we are supporting that by adding a bunch of unnecessary fields to the target struct to support both web and email clients.

Should we try and refactor that to be 3 structs? Like a Target that contains the common properties an EmailTarget that has the email related stuff & a HTTPTarget that has all of the webhook stuff?

nukosuke
@nukosuke

after your pr is merged for terraform 0.12 should we release 0.0.0 on the terraform provider? I believe we will have hit all the milestones we had previously set.

Yes, v0.0.0 has been released. Thank you :tada:

nukosuke
@nukosuke
The binaries are available on release page
nukosuke
@nukosuke

Also i was looking at the target code in the zendesk client

This feature was added at nukosuke/go-zendesk#137.

Should we try and refactor that to be 3 structs? Like a Target that contains the common properties an EmailTarget that has the email related stuff & a HTTPTarget that has all of the webhook stuff?

That's nice idea. I added the link to this conversation to nukosuke/terraform-provider-zendesk#184.

Andy McCall
@tamccall
@nukosuke i saw some issues with the acceptance tests on the latest prs we recieved. We might need to look into the prs to see how we could make travis run the acceptance tests on the pr after the unit tests pass. Otherwise people checking those in will need to wait quite awhile until i can get around to checking if the tests work or not.
alternatively we may want to consider giving a token to RWejlgaard so he can run the tests on his own
Andy McCall
@tamccall
based on my job here https://travis-ci.org/nukosuke/terraform-provider-zendesk/jobs/619970865 i don't know if we can ever expect to run the acceptance tests as part of the pr