terraform-provider-zendesk/Lobby

General topic about Terraform & Zendesk

Andy McCall

@tamccall

i think i am going to try and create a datasource to import the system fields. Let me know if you have any issue with that

Andy McCall

@tamccall

got a pr up for that. had a few questions for you on it let me know what you think.

Andy McCall

@tamccall

attachment resource should be ready for review now.

nukosuke

@nukosuke

I merged it. thanks

Andy McCall

@tamccall

Zendesk approved the sponsored account request :tada:
I forwarded the message to your private chat and invited you as admin of the instance.
Please check it when you have time.

you know anything about us being able to make forms for our sponsored account

looks like we still cant

nukosuke

@nukosuke

Sorry for late reply. I'll check it.

nukosuke

@nukosuke

Hmm, It seems that the account has been expired. I’ll contact Zendesk support again. Thank you for your report.

Andy McCall

@tamccall

looks like our account is usable again and it seems that forms can be created again i am gonna start working on getting the form acceptance tests working.

nukosuke

@nukosuke

I replaced HoundCI to GolangCI. It seems better for golang project.
https://golangci.com/

nukosuke

@nukosuke

⟩ go get github.com/nukosuke/go-zendesk@master
go: errors parsing go.mod:
/Users/nukosuke/workspace/v0.3-test-project/go.mod:5: invalid module version "v0.3": no matching versions for query "v0.3"

nukosuke

@nukosuke

@tamccall
I got an error when import master branch of go-zendesk on go1.12.
Do you know how to import current master revision without v0.3.0 tag?

Andy McCall

@tamccall

i suppose this fixed that?

nukosuke/go-zendesk@f436a4a

nukosuke

@nukosuke

Yeah, we should take these commits back when release v0.3.0

Andy McCall

@tamccall

how would we feel about making renovate run go mod tidy for the terraform provider?

I think you just need to add this property

https://github.com/terraform-providers/terraform-provider-aws/blob/master/renovate.json#L5

nukosuke

@nukosuke

@tamccall It's what I wanted. Thank you!!

nukosuke

@nukosuke

Do you have DockerHub account?
GitHub integration did not connect you as a collaborator of the image repository. I will add your account so that you could access terraform-providee-zendesk dashboard if you’d like.

nukosuke

@nukosuke

released go-zendesk@v0.2.1. It includes nukosuke/go-zendesk#129.

nukosuke

@nukosuke

released go-zendesk@v0.4.0

https://github.com/nukosuke/go-zendesk/releases/tag/v0.4.0

Andy McCall

@tamccall

hey i've been traveling over the past few days sorry for not answering

here is my docker hub account

https://hub.docker.com/u/tamccall

nukosuke

@nukosuke

Thanks. I sent the invitation. But, I'm planning to migrate the image repository to GitHub packages in future.

Andy McCall

@tamccall

hey just wanted to let you know i merged nukosuke/go-zendesk#142

let me know if you want me to make a release for 0.4.2

nukosuke

@nukosuke

Thank you :+1:
I released v0.4.2 and created the v0.5.0 milestone.

Andy McCall

@tamccall

after your pr is merged for terraform 0.12 should we release 0.0.0 on the terraform provider? I believe we will have hit all the milestones we had previously set.

Andy McCall

@tamccall

Also i was looking at the target code in the zendesk client. I am wondering if we should do a little refactoring to it.

https://developer.zendesk.com/rest_api/docs/support/targets#json-format

there are a bunch of different targets that need various information. Currently we are supporting that by adding a bunch of unnecessary fields to the target struct to support both web and email clients.

Should we try and refactor that to be 3 structs? Like a Target that contains the common properties an EmailTarget that has the email related stuff & a HTTPTarget that has all of the webhook stuff?

nukosuke

@nukosuke

after your pr is merged for terraform 0.12 should we release 0.0.0 on the terraform provider? I believe we will have hit all the milestones we had previously set.

Yes, v0.0.0 has been released. Thank you :tada:

nukosuke

@nukosuke

The binaries are available on release page

nukosuke

@nukosuke

Also i was looking at the target code in the zendesk client

This feature was added at nukosuke/go-zendesk#137.

Should we try and refactor that to be 3 structs? Like a Target that contains the common properties an EmailTarget that has the email related stuff & a HTTPTarget that has all of the webhook stuff?

That's nice idea. I added the link to this conversation to nukosuke/terraform-provider-zendesk#184.

Andy McCall

@tamccall

@nukosuke i saw some issues with the acceptance tests on the latest prs we recieved. We might need to look into the prs to see how we could make travis run the acceptance tests on the pr after the unit tests pass. Otherwise people checking those in will need to wait quite awhile until i can get around to checking if the tests work or not.

alternatively we may want to consider giving a token to RWejlgaard so he can run the tests on his own

Andy McCall

@tamccall

based on my job here https://travis-ci.org/nukosuke/terraform-provider-zendesk/jobs/619970865 i don't know if we can ever expect to run the acceptance tests as part of the pr

Andy McCall

@tamccall

that being the case i think it might make sense to come up with at least some sort of recommended process to get those developed and document it in the readme.

nukosuke

@nukosuke

Sorry for late reply. I'll be back in a week :bow:

Andy McCall

@tamccall

@nukosuke do you want me to make a release for the go-zendesk client

nukosuke

@nukosuke

yeah, that would be so helpful. Thank you.

Andy McCall

@tamccall

Hey just wanted to check in. I was curious if you saw my prs that i opened up for nukosuke/go-zendesk#152. Was curious if you had any thoughts.

Andy McCall

@tamccall

hi @nukosuke i hope you are doing well in these trying times. Wanted to know if you would be against me releasing 0.7.3 of the zendesk client. Need those changes to finish the pr that was started a few weeks back in the terraform-provider.

nukosuke

@nukosuke

@tamccall Sorry for late reply. I just released v0.7.3 now.

Andy McCall

@tamccall

it looks like the problem is that there is no active field on the sla resource

https://developer.zendesk.com/rest_api/docs/support/sla_policies#json-format

i'll remove that check from the test for now. Not sure what we should do about the client though as removing it would be backward incompatible.

nukosuke

@nukosuke

So, should we just remove "active" field from the client and the provider?

nukosuke

@nukosuke

I think that we should officialy support only for acc-passed resource. Even if next version break SLA backward compatibility, we should make it work.

Andy McCall

@tamccall

seems sensible to me. I took a few minutes tonight to see if i can fix the Acc tests. Still failing on the second read step. Going to push up what i have but it isn't ready to merge yet

Where communities thrive

People

Repo info

Activity