Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Jesse
    @Jjagg
    Actually, I remember reading about that
    IIRC there are incompatibilities between tasks for VS msbuild vs dotnet msbuild
    I use dotnet CLI which works fine to build the project
    https://natemcmaster.com/blog/2017/07/05/msbuild-task-in-nuget/#the-problem
    Tim Jones
    @tgjones
    @mrvux maybe that works as a workaround?
    @Jjagg thanks.
    Jesse
    @Jjagg
    The link has a solution as well. There's an MSBuild property that indicates if the full or portable MSBuild is being used. We could conditionally use the .NET Standard version of SyntaxGenerator or another compiled for .NET Framework
    mrvux
    @mrvux
    ok can't check today, but will have a go and report tomorrow, should not be too bad to fix
    Jesse
    @Jjagg
    :thumbsup:
    mrvux
    @mrvux
    also had this idea at some point (open for discuss), regarding #133 , what about allowing to have some form of "profile" for completion mostly (like allow to opt out some features)
    basically you could opt out xbox intrinsics, anything dx9 (got those two on my mind right now, but there's others)
    lua9520
    @lua9520
    Hello guys, Im new here!
    And I wanna to know any progress about vs2019
    Tim Jones
    @tgjones
    Hi! Progress from my end is basically zero at the moment. Real life (in the form of 2 young children) is taking up all my time at the moment. I hope to get back to HLSL Tools at some point, but in the meantime, PRs are gratefully accepted...
    stef-levesque
    @stef-levesque

    @tgjones I've added your Language Server in my VSCode extension, under an experimental flag.

    stef-levesque/vscode-shader@493da5c

    I've tested it under MacOS, Linux and Win10, sharing the same .DLLs and all works fine. Although, it does require to have the .Net Core 2.1 runtime installed.

    Tim Jones
    @tgjones
    Awesome :) Yeah, I meant to add a thing to download the dependencies at runtime, or else do a self-contained build.
    FYI, I still hope to release ShaderTools at some point, but I have no problem with you including the LSP stuff, I’m glad it can be useful. I think it’s unfinished though?
    stef-levesque
    @stef-levesque
    Well, it's way more precise than the RegEx implementation I made for my extension :)
    And I want to test it in a real-work environment, see where the limitations are.
    For one, I did notice an unsaved file doesn't get the proper syntax, the scheme untitled:// need to be added to the existing file:// ( and possibly vsls:// ?)
    Tim Jones
    @tgjones
    Oh, yes. I just copied that file scheme stuff from another LSP server.
    lua9520
    @lua9520
    Hello, I do a little work about upgrade to vs2019.I did some simple tests with vs2019,Win10.It seems fine.Have a check please.tgjones/HlslTools#136
    Tim Jones
    @tgjones
    @lua9520 great, thank you! Going to review it now.
    Jesse
    @Jjagg
    @tgjones How did you set up your coding environment so the generated Syntax files are found (in VS or VS Code)?
    Tim Jones
    @tgjones
    I don’t remember doing anything special for that. Maybe I had to restart VS, not sure.
    I’d like to use something like CodeGeneration.Roslyn to make that more robust.
    Jesse
    @Jjagg
    I'll handle it :)
    It's a lot easier than I thought because we can just keep all the writing logic, but parse it with Roslyn after the writing
    Tim Jones
    @tgjones
    Oh yeah, that’s a great idea.
    Jesse
    @Jjagg
    PR is up! Still doesn't seem to work with OmniSharp in Code :pensive:
    Still, it's a lot neater
    Jesse
    @Jjagg
    Nevermind, it's working!
    I needed to add the new project (that I was testing) to the solution
    I thought OmniSharp didn't care about solutions, but it appears it does!
    Okay, no something is tripping it up
    Scoping Code to just my project works, so definitely a bug in OmniSharp. Might be because of all the projects that fail to load on Linux.
    Harry
    @harry-cpp
    Whats missing to make the VS Code extension work on Linux?
    Tim Jones
    @tgjones
    AFAIK, the only thing missing is actually building the binary :) I don't have a Linux installation locally so I didn't do it for the initial release. What I did start to do, though, was moving the CI over to Azure DevOps so that I can build automatically on Windows, Linux, and Mac. I need to finish that.
    Harry
    @harry-cpp
    if you need any help with that I can help, I have added Azure DevOps to the following repo: https://github.com/GtkSharp/GtkSharp
    https://cra0zy.visualstudio.com/GtkSharp
    Henry Ventura
    @hvent90_twitter
    Anyone get the error "Couldn't start client HLSL Tools Language Client"? 
    [Error - 5:07:39 PM] Starting client failed
Launching server using command /Users/name/.vscode/extensions/timgjones.hlsltools-1.1.300/bin/osx-x64/ShaderTools.LanguageServer failed.
    Tim Jones
    @tgjones
    That doesn’t sound good. Do you get any more details than that? Does it happen every time?
    Tossrock
    @Tossrock
    @hvent90_twitter did you ever fix this? I'm experiencing the same issue.
    Tossrock
    @Tossrock
    Update for people who might experience this in the future: the extension binary was installed without executable permission; chmod +x fixed it.
    Thanks for this extension!
    Yorick van de Haar
    @Cambesa
    Hello! I just downloaded the hlsl tools for visual studio and it's amazing, is it possible for me to assign this tool to .compute and .shader files as well? Unity is using these extensions but they're simply hlsl
    Tim Jones
    @tgjones
    @Tossrock thanks! I'll get that fixed in a release soon.
    Tim Jones
    @tgjones
    @Cambesa You can assign whatever file extensions you like - see here: https://twitter.com/_tim_jones_/status/707968702176571392?lang=en - but that will only work well for .compute files, which are just HLSL. .shader files aren't just HLSL so you'll get all kinds of syntax errors.
    Yorick van de Haar
    @Cambesa
    Thank you!
    Tim Jones
    @tgjones
    I've just released v1.1.301, which should fix the macOS (and Linux!) executable permission problem. Thanks for reporting that @hvent90_twitter and @Tossrock .